mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "David Wilk" <davidwilk@gmail.com>
To: "Hugh Dickins" <hugh@veritas.com>
Cc: "Chris Wright" <chrisw@sous-sol.org>, "Greg KH" <greg@kroah.com>,
	"Marcelo Tosatti" <marcelo.tosatti@cyclades.com>,
	stable@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [stable] 2.6.16.6 breaks java... sort of
Date: Tue, 25 Apr 2006 12:08:49 -0600	[thread overview]
Message-ID: <a4403ff60604251108x7ed6d4e3q10cb3597ea27876c@mail.gmail.com> (raw)
In-Reply-To: <a4403ff60604241359q408a6ea7je620cb05d3dafe8@mail.gmail.com>

Ok, I think I need to apologize to everyone here.  I have found the
problem, and it is not with your patch, Hugh.  For some reason, the
config for my 2.6.16.7 source tree had a 1G/3G user/kernel split
configured.  This is very bizaar as I copy my .config from tree to
tree to avoid any changes in the configuration of my test kernels.

I imagine this is the expected behavior when you only have 1G
configured for user space?  right.  I will be sure to include my
/proc/config.gz in the future to prevent this from happening again.

I've tested 2.6.16.7 and 2.6.16.9 and neither of them have the mmap constraint.

again, my apologies.  I thank you for your patience and your hardwork
on the kernel.

thanks,
Dave

On 4/24/06, David Wilk <davidwilk@gmail.com> wrote:
> On 4/23/06, Hugh Dickins <hugh@veritas.com> wrote:
> > On Fri, 21 Apr 2006, David Wilk wrote:
> > > I finally got strace into the tomcat startup scripts properly and
> > > grabbed the attached output.  I don't see any of the two lines you
> > > propose.  I hope you guys can find this useful.
> >
> > Thanks for getting that, David.  As you observe, it doesn't involve
> > shm at all, and the only mprotect is PROT_NONE.  Do the abbreviated
> > messages in the final lines of the trace fit with the errors you
> > were originally reporting?  (I think so.)  Or is this particular
> > trace failing for some other reason, earlier than before, and we
> > need to try something else to identify the problem?
>
> I think this trace was taken while java was doing exactly what it was
> doing before.  I actually restarted java many, many times with
> 2.6.16.9 and watched in amazement as it failed each and every time,
> with the exact same error message.  This is tomcat, specifically, and
> it would die immediately after startup and it was started the exact
> same way with the init script.  So, yeah, I think this trace is
> representative.  I have no idea why it doesn't contain what you would
> consider relevant.  I'm no programmer, unfortunately.  However, I
> would like to help out any way that I can.
> >
> > > mmap2(NULL, 872415232, PROT_READ|PROT_WRITE|PROT_EXEC, MAP_PRIVATE|MAP_ANONYMOUS|MAP_NORESERVE, -1, 0) = -1 ENOMEM (Cannot allocate memory)
> > > write(1, "Error occurred during initializa"..., 43) = 43
> > > write(1, "Could not reserve enough space f"..., 46) = 46
> > > write(1, "\n", 1)                       = 1
> > > unlink("/tmp/hsperfdata_tomcat/12273")  = 0
> > > write(2, "Could not create the Java virtua"..., 43) = 43
> >
> > To judge by this trace, I'd have to say that your problem has
> > nothing whatever to do with the shm/mprotect fix in 2.6.16.6,
> > and we've no evidence yet to complicate that fix.  Interestingly,
> > nobody else has so far reported any problem with it.
>
> bizaar.  I must say that this patch 'fixing' the problem just cannot
> be coincidental.  Tomcat will never start without it, and never fails
> with it.
> >
> > Judging by the mmap addresses throughout the trace (top down, from
> > 0x37f2e000), it looks like you've got CONFIG_VMSPLIT_1G (not a good
> > choice for a box with only 1G of RAM: whereas CONFIG_VMSPLIT_3G_OPT
> > would maximize your userspace while avoiding the need for HIGHMEM);
> > and with the above 832M mmap, the remaining hole in user address
> > space is just too small to hold it.
>
> well, this is just a test box for a system we deploy on a dual-cpu
> server with 4GB of ram.
>
> can you describe the CONFIG_VMSPLIT_3G_OPT and how I might find it in
> 'make menuconfig'?  is it the second option (3G/1G user/kernel)?  I"ve
> got the first option selected which is 3G/1G user/kernel as well, but
> different somehow.  As this is new to 2.6.16, I'm not familiar with
> the options.  Perhaps my 1GB workstations would benefit from this
> second 3G/1G option?
> >
> > But that leaves me quite unable to explain why you should have
> > thought the shm/mprotect patch responsible, and why you should
> > find the more complicated version works.  Stack randomization
> > changes the numbers a little, but I think not enough to explain
> > how it sometimes could fit 832M in there, sometimes not.
>
> Unfortunately I cannot speculate as to the cause, but experimentally
> (anecdotally anyway) the patch is 100% effective.
> >
> > Tell me I'm talking nonsense and we'll have another go:
> > I guess adding some printks on top of the "replacement"
> > patch, so it can tell us when it's having an effect.
>
> I'd never accuse you of nonsense, but I cannot refute the evidence. ; )
>
> if there is anything else you would like me todo to try to squeeze
> more data from this thing, please let me know.
> >
> > Hugh
> >
>

  parent reply	other threads:[~2006-04-25 18:08 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <a4403ff60604191152u5a71e70fr9f54c104a654fc99@mail.gmail.com>
2006-04-19 19:28 ` Greg KH
2006-04-19 19:57   ` Hugh Dickins
2006-04-20 16:24     ` Hugh Dickins
2006-04-20 17:10       ` David Wilk
2006-04-21 19:08       ` David Wilk
2006-04-21 19:27         ` Chris Wright
2006-04-21 20:43           ` David Wilk
2006-04-21 21:56           ` David Wilk
2006-04-23 12:41             ` Hugh Dickins
2006-04-24 20:59               ` David Wilk
2006-04-25 17:51                 ` Hugh Dickins
2006-04-25 18:08                 ` David Wilk [this message]
2006-04-25 18:28                   ` Hugh Dickins
2006-04-26  5:12                   ` Andi Kleen
2006-04-26  8:03                     ` Adrian Bunk
2006-04-26 21:40                     ` David Wilk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a4403ff60604251108x7ed6d4e3q10cb3597ea27876c@mail.gmail.com \
    --to=davidwilk@gmail.com \
    --cc=chrisw@sous-sol.org \
    --cc=greg@kroah.com \
    --cc=hugh@veritas.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo.tosatti@cyclades.com \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®