mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Alexander Beregalov" <a.beregalov@gmail.com>
To: "James Morris" <jmorris@namei.org>
Cc: "David Howells" <dhowells@redhat.com>,
	linux-kernel@vger.kernel.org,
	linux-security-module@vger.kernel.org,
	"Stephen Rothwell" <sfr@canb.auug.org.au>,
	linux-next@vger.kernel.org
Subject: Re: [PATCH] CRED: Take cred_exec_mutex in compat_do_execve() and fix error handling in do_execve()
Date: Wed, 20 Aug 2008 16:00:31 +0400	[thread overview]
Message-ID: <a4423d670808200500m2bba097fg1cab607b9271de20@mail.gmail.com> (raw)
In-Reply-To: <alpine.LRH.1.10.0808200910020.317@tundra.namei.org>

> Applied to
> git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6#next-creds
>
> Hopefully this will be in the next linux-next tree for testing.
>
> Alexander, please let us know if it fixes the problem you saw.

Yes, it seems fixed.
David, there is one more problem.

2.6.27-rc3-next-20080820:

[   22.266394] [ BUG: bad unlock balance detected! ]
[   22.266495] -------------------------------------
[   22.266594] khelper/8 is trying to release lock (&p->cred_exec_mutex) at:
[   22.266775] [<00000000006af9f8>] mutex_unlock+0x10/0x20
[   22.266881] but there are no more locks to release!
[   22.266982]
[   22.266987] other info that might help us debug this:
[   22.267136] no locks held by khelper/8.
[   22.267224]
[   22.267229] stack backtrace:
[   22.267343] Call Trace:
[   22.267436]  [000000000047800c] print_unlock_inbalance_bug+0xe8/0xf8
[   22.267569]  [0000000000478338] lock_release+0x98/0x1ac
[   22.267685]  [00000000006af954] __mutex_unlock_slowpath+0xbc/0x150
[   22.267816]  [00000000006af9f8] mutex_unlock+0x10/0x20
[   22.267931]  [00000000004b81fc] free_bprm+0x1c/0x3c
[   22.268043]  [00000000004b93d4] do_execve+0x230/0x254
[   22.268158]  [00000000004273d8] sparc_execve+0x64/0xb0
[   22.268284]  [0000000000406194] linux_sparc_syscall+0x34/0x44
[   22.268407]  [0000000000432cf0] kernel_execve+0x20/0x34
[   22.268535]  [0000000000462fa8] ____call_usermodehelper+0xf4/0x10c
[   22.268661]  [0000000000427260] kernel_thread+0x3c/0x54
[   22.268779]  [0000000000462e7c] __call_usermodehelper+0x7c/0xb4

      reply	other threads:[~2008-08-20 12:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-19 15:18 David Howells
2008-08-19 23:29 ` James Morris
2008-08-20 12:00   ` Alexander Beregalov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a4423d670808200500m2bba097fg1cab607b9271de20@mail.gmail.com \
    --to=a.beregalov@gmail.com \
    --cc=dhowells@redhat.com \
    --cc=jmorris@namei.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®