From: James Morris <jmorris@namei.org>
To: David Howells <dhowells@redhat.com>
Cc: a.beregalov@gmail.com, linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH] CRED: Take cred_exec_mutex in compat_do_execve() and fix error handling in do_execve()
Date: Wed, 20 Aug 2008 09:29:50 +1000 (EST) [thread overview]
Message-ID: <alpine.LRH.1.10.0808200910020.317@tundra.namei.org> (raw)
In-Reply-To: <20080819151829.24589.30461.stgit@warthog.procyon.org.uk>
On Tue, 19 Aug 2008, David Howells wrote:
> Take cred_exec_mutex in compat_do_execve(). This reflects what do_execve()
> does. The mutex protects credentials calculation against PTRACE_ATTACH needing
> to alter it mid-exec.
>
> Also fix the error handling in do_execve(). The mutex needs to be unlocked if
> an error occurs after it is taken, but before the install_exec_creds()
> released it.
>
> Signed-off-by: David Howells <dhowells@redhat.com>
Applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6#next-creds
Hopefully this will be in the next linux-next tree for testing.
Alexander, please let us know if it fixes the problem you saw.
- James
--
James Morris
<jmorris@namei.org>
next prev parent reply other threads:[~2008-08-19 23:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-19 15:18 David Howells
2008-08-19 23:29 ` James Morris [this message]
2008-08-20 12:00 ` Alexander Beregalov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.1.10.0808200910020.317@tundra.namei.org \
--to=jmorris@namei.org \
--cc=a.beregalov@gmail.com \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®