mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Miles Lane" <miles.lane@gmail.com>
To: "Ingo Molnar" <mingo@elte.hu>
Cc: "Andrew Morton" <akpm@osdl.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: 2.6.18-rc5-mm1 + all hotfixes -- BUG: MAX_STACK_TRACE_ENTRIES too low!
Date: Sun, 3 Sep 2006 11:15:59 -0700	[thread overview]
Message-ID: <a44ae5cd0609031115r3a0d10den8a86a79cd6c5756a@mail.gmail.com> (raw)
In-Reply-To: <a44ae5cd0609031005u263aebebr6e53fb59e0153d0a@mail.gmail.com>

On 9/3/06, Miles Lane <miles.lane@gmail.com> wrote:
> On 9/3/06, Ingo Molnar <mingo@elte.hu> wrote:
> >
> > * Miles Lane <miles.lane@gmail.com> wrote:
> >
> > > Sorry Andrew.  I don't see clues here to help me target the report to
> > > a maintainer. I hope this helps.
> > >
> > > BUG: MAX_STACK_TRACE_ENTRIES too low!
> > > turning off the locking correctness validator.
> >
> > Miles, could you try the patch below? (Andrew: if this solves Miles'
> > problem then i think this is v2.6.18 material too. [The other
> > possibility would be some permanent stack-trace entries leak, in which
> > case the patch will not help. If that happens then we'll have to debug
> > this some more.])
> >
> >         Ingo
> >
> > ---------------->
> > From: Ingo Molnar <mingo@elte.hu>
> > Subject: lockdep: double the number of stack-trace entries
> >
> > Miles Lane reported the "BUG: MAX_STACK_TRACE_ENTRIES too low!" message,
> > which means that during normal use his system produced enough lockdep
> > events so that the 128-thousand entries stack-trace array got exhausted.
> > Double the size of the array.
> >
> > Signed-off-by: Ingo Molnar <mingo@elte.hu>
> > ---
> >  kernel/lockdep_internals.h |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Index: linux/kernel/lockdep_internals.h
> > ===================================================================
> > --- linux.orig/kernel/lockdep_internals.h
> > +++ linux/kernel/lockdep_internals.h
> > @@ -27,7 +27,7 @@
> >   * Stack-trace: tightly packed array of stack backtrace
> >   * addresses. Protected by the hash_lock.
> >   */
> > -#define MAX_STACK_TRACE_ENTRIES        131072UL
> > +#define MAX_STACK_TRACE_ENTRIES        262144UL
> >
> >  extern struct list_head all_lock_classes;
> >
> >
>
> Ingo, there seemed to be a difference between the file you editted and
>  the one in Andrew's tree.  I remade you patch so it applies cleanly.
> I'll test and let you know.  One word of caution, I only hit the
> problem once and I'm not sure how to trigger the condition.  I'll do
> my best.
>
> Thanks,
>         Miles
>
> --- kernel/lockdep_internals.h~ 2006-09-03 09:59:29.000000000 -0700
> +++ kernel/lockdep_internals.h  2006-09-03 10:00:55.000000000 -0700
> @@ -27,7 +27,7 @@
>   * Stack-trace: tightly packed array of stack backtrace
>   * addresses. Protected by the hash_lock.
>   */
> -#define MAX_STACK_TRACE_ENTRIES        131072UL
> +#define MAX_STACK_TRACE_ENTRIES        262144UL
>
>  extern struct list_head all_lock_classes;
>

By the way, after making this change "make all install modules
modules_install" didn't seem to notice that the file had been
modified.  I backed up .config, ran "make mrproper", etc.  Is this a
build dependency checker bug?

Thanks,
        Miles

-- 
VGER BF report: H 4.35163e-06

      reply	other threads:[~2006-09-03 18:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-03  3:03 Miles Lane
2006-09-03  4:20 ` Andrew Morton
2006-09-03 12:54 ` Ingo Molnar
2006-09-03 17:05   ` Miles Lane
2006-09-03 18:15     ` Miles Lane [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a44ae5cd0609031115r3a0d10den8a86a79cd6c5756a@mail.gmail.com \
    --to=miles.lane@gmail.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®