* 2.6.19-rc1-mm1 -- WARNING: "toshoboe_invalid_dev" [drivers/net/irda/donauboe.ko] undefined!
@ 2006-10-10 16:12 Miles Lane
2006-10-10 17:05 ` Jiri Kosina
0 siblings, 1 reply; 2+ messages in thread
From: Miles Lane @ 2006-10-10 16:12 UTC (permalink / raw)
To: LKML
This stops the "make modules_install" process.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: 2.6.19-rc1-mm1 -- WARNING: "toshoboe_invalid_dev" [drivers/net/irda/donauboe.ko] undefined!
2006-10-10 16:12 2.6.19-rc1-mm1 -- WARNING: "toshoboe_invalid_dev" [drivers/net/irda/donauboe.ko] undefined! Miles Lane
@ 2006-10-10 17:05 ` Jiri Kosina
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Kosina @ 2006-10-10 17:05 UTC (permalink / raw)
To: Miles Lane; +Cc: LKML, Andrew Morton, Linus Torvalds
On Tue, 10 Oct 2006, Miles Lane wrote:
> This stops the "make modules_install" process.
This is not only in -mm, but also in Linus' git tree. I just sent the
patch below to Jeff (who is the author of the commit that broke it), which
I believe might be correct:
[PATCH] fix reference to removed toshoboe_invalid_dev() in
drivers/net/irda/donauboe.c
commit c31f28e778ab299a5035ea2bda64f245b8915d7c (which currently is in
mainline) broke drivers/net/irda/donauboe.c, as it removes
toshoboe_invalid_dev(), but this is called from toshoboe_interrupt() (your
patch removed reference to it only from toshoboe_probeinterrupt().
Signed-off-by: Jiri Kosina <jikos@jikos.cz>
diff --git a/drivers/net/irda/donauboe.c b/drivers/net/irda/donauboe.c
index 636d063..14cc217 100644
--- a/drivers/net/irda/donauboe.c
+++ b/drivers/net/irda/donauboe.c
@@ -1158,9 +1158,6 @@ toshoboe_interrupt (int irq, void *dev_i
__u8 irqstat;
struct sk_buff *skb = NULL;
- if (self == NULL && toshoboe_invalid_dev(irq))
- return IRQ_NONE;
-
irqstat = INB (OBOE_ISR);
/* was it us */
--
Jiri Kosina
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-10-10 17:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-10-10 16:12 2.6.19-rc1-mm1 -- WARNING: "toshoboe_invalid_dev" [drivers/net/irda/donauboe.ko] undefined! Miles Lane
2006-10-10 17:05 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®