From: simon@mungewell.org
To: "Michael Bauer" <michael@m-bauer.org>
Cc: linux-input@vger.kernel.org, simon@mungewell.org,
linux-kernel@vger.kernel.org, "Jiri Kosina" <jkosina@suse.cz>
Subject: Re: [PATCH] hid: Fix Logitech Driving Force Pro wheel
Date: Sun, 29 May 2011 10:50:35 -0400 [thread overview]
Message-ID: <a49670b80c887da1f9224080e9e62f32.squirrel@host171.canaca.com> (raw)
In-Reply-To: <201105290846.59531.michael@m-bauer.org>
> Often the control assignement works like this: User clicks "set axis for
> acceleration", application asks "please move the desired axis" and then
> automatically choses the "moving" axis.
> If we report both combined and separate at the same time, the application
> will
> have a hard time deciding which one to use, as they both will change their
> values.
>
Fair enough, I played a little trying to massage the original descriptor
but could not find a sensible solution - so I guess we'll have to provide
a full replacement.
I don't see the need to comment the original/replacement blocks, so
probably a simple 'hex block' would be good.
Regarding the replacement, you appear to have a lot of unnecessary code
there. You could try with something like:
--
...
+0x09, 0x39, /* Usage (Hat Switch), */
+0x81, 0x42, /* Input (Variable), */
+0x75, 0x08, /* Report Size (8), */
+0x95, 0x08, /* Report Count (1), */
+0x65, 0x00, /* Unit, */
+0x06, 0x00, 0xFF, /* Usage Page (FF00h), */
+0x26, 0xFF, 0x00, /* Logical Maximum (255), */
+0x46, 0xFF, 0x00, /* Physical Maximum (255), */
+0x09, 0x01, /* Usage (01h), */
+0x81, 0x02, /* Input (Variable), */
+0xA4, /* Push, */
+0x05, 0x01, /* Usage Page (Desktop), */
+0x95, 0x01, /* Report Count (2), */
+0x09, 0x31, /* Usage (Y), */
+0x09, 0x35, /* Usage (Rz), */
+0x81, 0x02, /* Input (Variable), */
+0xB4, /* Pop, */
+0x81, 0x02, /* Input (Variable), */
+0xC0, /* End Collection, */
...
--
Cheers,
Simon.
next prev parent reply other threads:[~2011-05-29 14:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-28 18:37 Michael Bauer
2011-05-28 21:31 ` simon
2011-05-28 23:47 ` simon
2011-05-29 6:46 ` Michael Bauer
2011-05-29 14:50 ` simon [this message]
2011-05-30 6:17 ` Michael Bauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a49670b80c887da1f9224080e9e62f32.squirrel@host171.canaca.com \
--to=simon@mungewell.org \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@m-bauer.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®