mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: simon@mungewell.org
To: "Michael Bauer" <michael@m-bauer.org>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Jiri Kosina" <jkosina@suse.cz>
Subject: Re: [PATCH] hid: Fix Logitech Driving Force Pro wheel
Date: Sat, 28 May 2011 17:31:58 -0400	[thread overview]
Message-ID: <fd06492f61f15697eb1c8400e29ec7bd.squirrel@host171.canaca.com> (raw)
In-Reply-To: <201105282037.22888.michael@m-bauer.org>

Hi Michael and all,

> As there are significant differences in the descriptor (original
> descriptor
> "hides" the separate axes in a  24 bit FF00 usagepage, new descripter
> replaces
> that with two individual 8 bit desktop.y and desktop.rz usages) I provided
> a
> complete replacement descriptor instead trying to patch the original one.
> Patching the descriptor seems not feasible as the new one is much larger.

I think there a couple problems with your replacement descriptor, although
I don't have a wheel to test with).

1). There is no 'NULL state' on the hatswitch
2). The original does Y then 3 others, the replacement does Y + RZ then 1
other.

When I was looking at doing a similar thing for another wheel I recall
that there was a way of doing a 1 byte NOP, but can't remember how at the
moment.

So you might want to try just patching the original as follows.

> + * 0x95, 0x01,         //          Report Count (1),
> + * 0x75, 0x08,         //          Report Size (8),
> + * 0x26, 0xFF, 0x00,   //          Logical Maximum (255),
> + * 0x46, 0xFF, 0x00,   //          Physical Maximum (255),
> + * 0x09, 0x31,         //          Usage (Y),
> + * 0x81, 0x02,         //          Input (Variable),
> + * 0x06, 0x00, 0xFF,   //          Usage Page (FF00h), -> NOP +
ReportCount(3)
> + * 0x09, 0x00,         //          Usage (00h),        -> usage(Z)
> + * 0x95, 0x03,         //          Report Count (3),   -> usage(Rx)
> + * 0x75, 0x08,         //          Report Size (8),    -> usage(Ry)
> + * 0x81, 0x02,         //          Input (Variable),
> + * 0xC0,               //      End Collection,

Most settings roll over between sections, so don't need to be redefined. I
don't think the exact 'usage()' is important as Linux will just see them
as axis.

Cheers,
Simon


  reply	other threads:[~2011-05-28 21:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-28 18:37 Michael Bauer
2011-05-28 21:31 ` simon [this message]
2011-05-28 23:47   ` simon
2011-05-29  6:46     ` Michael Bauer
2011-05-29 14:50       ` simon
2011-05-30  6:17         ` Michael Bauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fd06492f61f15697eb1c8400e29ec7bd.squirrel@host171.canaca.com \
    --to=simon@mungewell.org \
    --cc=jkosina@suse.cz \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael@m-bauer.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®