From: Guenter Roeck <linux@roeck-us.net>
To: wenswang@yeah.net, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, skhan@linuxfoundation.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH v3 0/2] hwmon: Add support for MPS mp2985
Date: Mon, 23 Mar 2026 08:08:22 -0700 [thread overview]
Message-ID: <a49a7b9b-e3c3-4307-93d9-c4a7594bd73c@roeck-us.net> (raw)
In-Reply-To: <20260323061901.827025-1-wenswang@yeah.net>
On 3/22/26 23:19, wenswang@yeah.net wrote:
> From: Wensheng Wang <wenswang@yeah.net>
>
> Add mp2985 driver in hwmon and add dt-bindings for it.
>
AI feedback is here:
https://sashiko.dev/#/patchset/20260323062104.827263-1-wenswang%40yeah.net
Couple of comments:
- If the mantissa overflow can not happen, please add a comment into the code
explaining the reason.
- EINVAL returns need to be explained. They should only be used
if the chip can not handle reading unsupported registers, and a comment
in the code needs to explain that.
- Ignore the concern about the chip being left on page 2 after an error
reading MFR_VR_MULTI_CONFIG_R[12] for now. It makes me wonder if
pmbus_init_common() should explicitly select page 0 for multi-page
chips.
- The alignment of
+ ret = i2c_smbus_read_word_data(client, page == 0 ?
+ MFR_VR_MULTI_CONFIG_R1 :
+ MFR_VR_MULTI_CONFIG_R2);
still seems odd. Why the large indentation ?
Thanks,
Guenter
prev parent reply other threads:[~2026-03-23 15:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 6:19 wenswang
2026-03-23 6:21 ` [PATCH v3 1/2] dt-bindings: hwmon: Add " wenswang
2026-03-23 6:21 ` [PATCH v3 2/2] hwmon: add MP2985 driver wenswang
2026-03-23 15:08 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a49a7b9b-e3c3-4307-93d9-c4a7594bd73c@roeck-us.net \
--to=linux@roeck-us.net \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=wenswang@yeah.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®