[PATCH next] initramfs_test: Fix NULL vs IS_ERR() bug in initramfs_test_data()

[PATCH next] initramfs_test: Fix NULL vs IS_ERR() bug in initramfs_test_data()

[Dan Carpenter]

The filp_open() function returns error pointers.  It never returns
NULL pointers.  Update the check to match.

Fixes: b6736cfccb58 ("initramfs_test: kunit tests for initramfs unpacking")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
 init/initramfs_test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/init/initramfs_test.c b/init/initramfs_test.c
index 6231fe012583..7d14f70beabc 100644
--- a/init/initramfs_test.c
+++ b/init/initramfs_test.c
@@ -222,7 +222,7 @@ static void __init initramfs_test_data(struct kunit *test)
 	KUNIT_EXPECT_NULL(test, err);
 
 	file = filp_open(c[0].fname, O_RDONLY, 0);
-	if (!file) {
+	if (IS_ERR(file)) {
 		KUNIT_FAIL(test, "open failed");
 		goto out;
 	}
-- 
2.47.2

Re: [PATCH next] initramfs_test: Fix NULL vs IS_ERR() bug in initramfs_test_data()

[Christian Brauner]

On Thu, 06 Mar 2025 12:48:40 +0300, Dan Carpenter wrote:
> The filp_open() function returns error pointers.  It never returns
> NULL pointers.  Update the check to match.
> 
> 

Folded the fix. Thanks!

---

Applied to the vfs-6.15.initramfs branch of the vfs/vfs.git tree.
Patches in the vfs-6.15.initramfs branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs-6.15.initramfs

[1/1] initramfs_test: Fix NULL vs IS_ERR() bug in initramfs_test_data()
      (no commit info)