From: Alan Stern <stern@rowland.harvard.edu>
To: Daniel Palmer <daniel@thingy.jp>
Cc: peter.chen@kernel.org, gregkh@linuxfoundation.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 1/2] usb: ehci: Add option to override ehci_readl()/ehci_writel()
Date: Mon, 13 Jul 2026 10:45:57 -0400 [thread overview]
Message-ID: <a4fbe866-397d-4fb4-b4d4-e71e7771931d@rowland.harvard.edu> (raw)
In-Reply-To: <CAFr9PX=0Bx7OBzbUXXZPsXdXyCV0NPqi4YaJ1DCeMXGk9UDQKg@mail.gmail.com>
On Mon, Jul 13, 2026 at 11:37:19PM +0900, Daniel Palmer wrote:
> Hi Alan,
>
> On Mon, 13 Jul 2026 at 23:21, Alan Stern <stern@rowland.harvard.edu> wrote:
> > > +config HAVE_BROKEN_EHCI_HCD
> > > + bool
> >
> > That is not a good choice of name; it's far too generic. EHCI
> > controllers can be broken in so many different ways...
> >
> > How about USB_EHCI_MMIO_OVERRIDES instead?
>
> Noted. Based on that we'd have a config for each piece that needs to
> be overridden so drivers can pick the ones they need?
Maybe. What other things will need to be overridden? It's hard to tell
what you're planning from just a single sample.
Note that some of the things that are already present in the code can be
thought of as overrides (although generally not for a broken feature).
Alan Stern
next prev parent reply other threads:[~2026-07-13 14:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-13 12:22 [RFC PATCH 0/2] usb: ehci: Allow ehci accessors to be overridden Daniel Palmer
2026-07-13 12:22 ` [RFC PATCH 1/2] usb: ehci: Add option to override ehci_readl()/ehci_writel() Daniel Palmer
2026-07-13 14:21 ` Alan Stern
2026-07-13 14:37 ` Daniel Palmer
2026-07-13 14:45 ` Alan Stern [this message]
2026-07-13 15:07 ` Daniel Palmer
2026-07-13 16:18 ` Alan Stern
2026-07-13 12:22 ` [RFC PATCH 2/2] usb: chipidea: use the generic ehci_writel override for i.MX28 Daniel Palmer
2026-07-15 5:51 ` Peter Chen
2026-07-18 2:26 ` Daniel Palmer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4fbe866-397d-4fb4-b4d4-e71e7771931d@rowland.harvard.edu \
--to=stern@rowland.harvard.edu \
--cc=daniel@thingy.jp \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter.chen@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®