* [PATCH] PM / devfreq: sun8i: addd COMMON_CLK dependency @ 2021-12-15 14:03 ` Arnd Bergmann 2021-12-16 2:29 ` Chanwoo Choi 0 siblings, 1 reply; 2+ messages in thread From: Arnd Bergmann @ 2021-12-15 14:03 UTC (permalink / raw) To: MyungJoo Ham, Kyungmin Park, Chanwoo Choi, Samuel Holland Cc: Arnd Bergmann, Dong Aisheng, linux-pm, linux-kernel From: Arnd Bergmann <arnd@arndb.de> Compile-testing the driver without CONFIG_COMMON_CLK causes a link failure: arm-linux-gnueabi-ld: drivers/devfreq/sun8i-a33-mbus.o: in function `sun8i_a33_mbus_remove': sun8i-a33-mbus.c:(.text+0x450): undefined reference to `clk_rate_exclusive_put' arm-linux-gnueabi-ld: sun8i-a33-mbus.c:(.text+0x460): undefined reference to `clk_rate_exclusive_put' arm-linux-gnueabi-ld: drivers/devfreq/sun8i-a33-mbus.o: in function `sun8i_a33_mbus_probe': sun8i-a33-mbus.c:(.text+0x85c): undefined reference to `clk_rate_exclusive_get' arm-linux-gnueabi-ld: sun8i-a33-mbus.c:(.text+0x878): undefined reference to `clk_rate_exclusive_get' Fixes: 8bfd4858b4bb ("PM / devfreq: Add a driver for the sun8i/sun50i MBUS") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/devfreq/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig index b94eb04761f6..87eb2b837e68 100644 --- a/drivers/devfreq/Kconfig +++ b/drivers/devfreq/Kconfig @@ -135,6 +135,7 @@ config ARM_RK3399_DMC_DEVFREQ config ARM_SUN8I_A33_MBUS_DEVFREQ tristate "sun8i/sun50i MBUS DEVFREQ Driver" depends on ARCH_SUNXI || COMPILE_TEST + depends on COMMON_CLK select DEVFREQ_GOV_SIMPLE_ONDEMAND help This adds the DEVFREQ driver for the MBUS controller in some -- 2.29.2 ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] PM / devfreq: sun8i: addd COMMON_CLK dependency 2021-12-15 14:03 ` [PATCH] PM / devfreq: sun8i: addd COMMON_CLK dependency Arnd Bergmann @ 2021-12-16 2:29 ` Chanwoo Choi 0 siblings, 0 replies; 2+ messages in thread From: Chanwoo Choi @ 2021-12-16 2:29 UTC (permalink / raw) To: Arnd Bergmann, MyungJoo Ham, Kyungmin Park, Samuel Holland Cc: Arnd Bergmann, Dong Aisheng, linux-pm, linux-kernel On 12/15/21 11:03 PM, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > Compile-testing the driver without CONFIG_COMMON_CLK causes > a link failure: > > arm-linux-gnueabi-ld: drivers/devfreq/sun8i-a33-mbus.o: in function `sun8i_a33_mbus_remove': > sun8i-a33-mbus.c:(.text+0x450): undefined reference to `clk_rate_exclusive_put' > arm-linux-gnueabi-ld: sun8i-a33-mbus.c:(.text+0x460): undefined reference to `clk_rate_exclusive_put' > arm-linux-gnueabi-ld: drivers/devfreq/sun8i-a33-mbus.o: in function `sun8i_a33_mbus_probe': > sun8i-a33-mbus.c:(.text+0x85c): undefined reference to `clk_rate_exclusive_get' > arm-linux-gnueabi-ld: sun8i-a33-mbus.c:(.text+0x878): undefined reference to `clk_rate_exclusive_get' > > Fixes: 8bfd4858b4bb ("PM / devfreq: Add a driver for the sun8i/sun50i MBUS") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/devfreq/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig > index b94eb04761f6..87eb2b837e68 100644 > --- a/drivers/devfreq/Kconfig > +++ b/drivers/devfreq/Kconfig > @@ -135,6 +135,7 @@ config ARM_RK3399_DMC_DEVFREQ > config ARM_SUN8I_A33_MBUS_DEVFREQ > tristate "sun8i/sun50i MBUS DEVFREQ Driver" > depends on ARCH_SUNXI || COMPILE_TEST > + depends on COMMON_CLK > select DEVFREQ_GOV_SIMPLE_ONDEMAND > help > This adds the DEVFREQ driver for the MBUS controller in some > Thanks. Applied it. -- Best Regards, Chanwoo Choi Samsung Electronics ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-16 2:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20211215140534epcas1p4a39eed46b3bd0e8582837321d1f279e6@epcas1p4.samsung.com>
2021-12-15 14:03 ` [PATCH] PM / devfreq: sun8i: addd COMMON_CLK dependency Arnd Bergmann
2021-12-16 2:29 ` Chanwoo Choi
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®