mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jiri Slaby <jslaby@suse.cz>
To: SF Markus Elfring <elfring@users.sourceforge.net>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-serial@vger.kernel.org
Cc: "Guilherme G. Piccoli" <gpiccoli@linux.vnet.ibm.com>,
	Joe Perches <joe@perches.com>,
	kernel-janitors@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: jsm_tty: Fix a possible null pointer dereference in two functions
Date: Thu, 30 Nov 2017 07:41:11 +0100	[thread overview]
Message-ID: <a571b1cb-ce63-2efa-10b2-990f84da2f20@suse.cz> (raw)
In-Reply-To: <089a4b85-64e8-cb4a-c5f8-9abb2556e5e5@users.sourceforge.net>

On 11/29/2017, 07:19 PM, SF Markus Elfring wrote:
>>> It's pretty unlikely, but it is an actual defect.
>>
>> No it is not, those variables will never be set to NULL,
>> so this can never be triggered.  Walk up the call chain.
> 
> If the involved software developers are convinced about the validity
> of this pointer:
> 
> How do you think about to delete the following condition check
> instead in the discussed function implementations?
> 
> 	if (!ch)
> 		return;

ACK

thanks,
-- 
js
suse labs

  reply	other threads:[~2017-11-30  6:41 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-29 16:40 [PATCH] " SF Markus Elfring
2017-11-29 17:23 ` Joe Perches
2017-11-29 17:35   ` Greg Kroah-Hartman
2017-11-29 17:51     ` Joe Perches
2017-11-29 18:05       ` Greg Kroah-Hartman
2017-11-29 18:16         ` Joe Perches
2017-11-29 18:19         ` SF Markus Elfring
2017-11-30  6:41           ` Jiri Slaby [this message]
2017-12-06 16:16           ` Guilherme G. Piccoli
2017-12-16  6:27             ` jsm_tty: Deletion of a null pointer check in two functions? SF Markus Elfring
2017-12-18 14:36               ` Guilherme G. Piccoli
2017-12-18 17:14                 ` SF Markus Elfring
2017-11-29 19:16   ` [PATCH] jsm_tty: Fix a possible null pointer dereference in two functions Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a571b1cb-ce63-2efa-10b2-990f84da2f20@suse.cz \
    --to=jslaby@suse.cz \
    --cc=elfring@users.sourceforge.net \
    --cc=gpiccoli@linux.vnet.ibm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=joe@perches.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®