mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Frank Wang <frank.wang@rock-chips.com>
To: Heiko Stuebner <heiko@sntech.de>
Cc: johnyoun@synopsys.com, gregkh@linuxfoundation.org,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
	linux-rockchip@lists.infradead.org, huangtao@rock-chips.com,
	kever.yang@rock-chips.com, william.wu@rock-chips.com,
	elaine.zhang@rock-chips.com, frank.wang@rock-chips.com
Subject: Re: [RESEND PATCH 0/1] add multiple clock handling for dwc2 driver
Date: Mon, 6 Feb 2017 09:40:35 +0800	[thread overview]
Message-ID: <a573a8d1-7df8-24cd-1291-4dfdc8068f18@rock-chips.com> (raw)
In-Reply-To: <3508420.z4eX5F6ytJ@phil>

Hi Heiko,

On 2017/2/5 17:41, Heiko Stuebner wrote:
> Hi Frank,
>
> Am Sonntag, 5. Februar 2017, 10:51:00 CET schrieb Frank Wang:
>> The original posting on Jan 19th have not received any responses, so I
>> resend them.
>>
>> The Current default dwc2 just handle one clock named otg, however, it may
>> have two or more clock need to manage for some new SoCs(such as RK3328), so
>> this adds change clk to clk's array of dwc2_hsotg to handle more clocks
>> operation.
> can you please give a bit more detail on the specific layout.
>
> I guess you're talking about hclk_otg_pmu, right? What component does it
> supply, because I didn't find anything in the partial TRM in the PMU section
> relating to the "otg".

Yes, it is hclk_otg_pmu.

The rock-chip hclk_otg_pmu is an input clock for dwc2 PMU module which 
named pmu_hclk in chapter 2.4 of dwc otg databook v3.10.
Please refer to the following simple clock tree from CRU part of rk3328 
TRM.
                                  _ _ _ ...
                                 |
                                 |- - -> G19_8 - - - hclk_otg - - - - - - ->
hclk_peri_pre - - ->|
|- - -> G19_9 - - - hclk_otg_pmu - - ->
                                 |_ _ _ ...

BR.
Frank

> This meant to make sure, you're actually controlling some part of the dwc2
> with that second/third/... clock and not some separate component.
>
>
> Heiko
>
>
>

  reply	other threads:[~2017-02-06  1:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-05  2:51 Frank Wang
2017-02-05  2:51 ` [RESEND PATCH 1/1] usb: dwc2: add multiple clock handling Frank Wang
2017-02-07  0:06   ` Heiko Stuebner
2017-02-07  3:18     ` Frank Wang
2017-02-07  9:51       ` John Youn
2017-02-05  9:41 ` [RESEND PATCH 0/1] add multiple clock handling for dwc2 driver Heiko Stuebner
2017-02-06  1:40   ` Frank Wang [this message]
2017-02-06 23:53     ` Heiko Stuebner
     [not found] <eb6931a1-4679-1579-27fe-d444ae84a122@rock-chips.com>
2017-02-06  2:20 ` Frank Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a573a8d1-7df8-24cd-1291-4dfdc8068f18@rock-chips.com \
    --to=frank.wang@rock-chips.com \
    --cc=elaine.zhang@rock-chips.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heiko@sntech.de \
    --cc=huangtao@rock-chips.com \
    --cc=johnyoun@synopsys.com \
    --cc=kever.yang@rock-chips.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=william.wu@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®