From: Pratyush Brahma <quic_pbrahma@quicinc.com>
To: Dmitry Baryshkov <lumag@kernel.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
<linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arm64: dts: qcom: qcs8300: add the pcie smmu node
Date: Wed, 12 Mar 2025 15:49:17 +0530 [thread overview]
Message-ID: <a59c99a0-262d-4f16-99a4-985486849218@quicinc.com> (raw)
In-Reply-To: <rj4jtqchuetrbtczbhvaa5hcp5olumwdbao3x4pulkxiqcq2ag@v6ftffk6bcc5>
On 3/12/2025 2:14 PM, Dmitry Baryshkov wrote:
> On Wed, Mar 12, 2025 at 12:41:38PM +0530, Pratyush Brahma wrote:
>> On 3/12/2025 12:23 PM, Dmitry Baryshkov wrote:
>>> On Thu, Feb 06, 2025 at 07:13:17PM +0530, Pratyush Brahma wrote:
>>>> Add the PCIe SMMU node to enable address translations
>>>> for pcie.
>>>>
>>>> Signed-off-by: Pratyush Brahma <quic_pbrahma@quicinc.com>
>>>> ---
>>>> arch/arm64/boot/dts/qcom/qcs8300.dtsi | 75 +++++++++++++++++++++++++++++++++++
>>>> 1 file changed, 75 insertions(+)
>>>>
>>> Reviewed-by: Dmitry Baryshkov <lumag@kernel.org>
>>>
>>> Though I see a little benefit in having this SMMU node if it is not
>>> followed by the PCIe enablement.
>> Thanks for the review!
>>
>> PCIe enablement changes for qcs8300 have been posted already [1] and [1]
>> needs
>> this patch as mentioned in [2].
> Ack. In future please consider posting series in a logical way: if PCIe
> SMMU is only useful for PCIe and it is required for PCIe to work it
> makes much more sense to have it as a part of the PCIe enablement series
> rather than having it as a separate patch which can easily get lost.
Sure, will keep this in mind further.
>
>> [1] https://lore.kernel.org/lkml/20250310063103.3924525-8-quic_ziyuzhan@quicinc.com
>> [2] https://lore.kernel.org/lkml/20250310063103.3924525-1-quic_ziyuzhan@quicinc.com
>>
>> --
>> Thanks and Regards
>> Pratyush Brahma
>>
--
Thanks and Regards
Pratyush Brahma
next prev parent reply other threads:[~2025-03-12 10:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-06 13:43 Pratyush Brahma
2025-03-11 22:05 ` Pratyush Brahma
2025-03-12 6:53 ` Dmitry Baryshkov
2025-03-12 7:11 ` Pratyush Brahma
2025-03-12 8:44 ` Dmitry Baryshkov
2025-03-12 10:19 ` Pratyush Brahma [this message]
2025-03-14 22:00 ` Konrad Dybcio
2025-03-28 8:51 ` Pratyush Brahma
2025-04-03 18:46 ` Pratyush Brahma
2025-04-03 20:48 ` Konrad Dybcio
2025-04-12 0:01 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a59c99a0-262d-4f16-99a4-985486849218@quicinc.com \
--to=quic_pbrahma@quicinc.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lumag@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®