* [PATCH v6 1/6] dt-bindings: display/msm: Document the DPU for QCS8300
2025-08-06 3:16 [PATCH v6 0/6] Display enablement changes for Qualcomm QCS8300 platform Yongxing Mou
@ 2025-08-06 3:16 ` Yongxing Mou
2025-08-06 3:16 ` [PATCH v6 2/6] dt-bindings: display/msm: dp-controller: document QCS8300 compatible Yongxing Mou
` (4 subsequent siblings)
5 siblings, 0 replies; 17+ messages in thread
From: Yongxing Mou @ 2025-08-06 3:16 UTC (permalink / raw)
To: Rob Clark, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang,
Sean Paul, Marijn Suijten, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Neil Armstrong, Kuogee Hsieh,
Bjorn Andersson, Konrad Dybcio
Cc: linux-arm-msm, dri-devel, freedreno, devicetree, linux-kernel,
Yongxing Mou
Document the DPU for Qualcomm QCS8300 platform. It use the same DPU
hardware with SA8775P and reuse it's driver.
Signed-off-by: Yongxing Mou <quic_yongmou@quicinc.com>
---
.../devicetree/bindings/display/msm/qcom,sm8650-dpu.yaml | 15 ++++++++++-----
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm8650-dpu.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm8650-dpu.yaml
index 0a46120dd8680371ed031f7773859716f49c3aa1..d9b980a897229860dae76f25bd947405e3910925 100644
--- a/Documentation/devicetree/bindings/display/msm/qcom,sm8650-dpu.yaml
+++ b/Documentation/devicetree/bindings/display/msm/qcom,sm8650-dpu.yaml
@@ -13,11 +13,16 @@ $ref: /schemas/display/msm/dpu-common.yaml#
properties:
compatible:
- enum:
- - qcom,sa8775p-dpu
- - qcom,sm8650-dpu
- - qcom,sm8750-dpu
- - qcom,x1e80100-dpu
+ oneOf:
+ - enum:
+ - qcom,sa8775p-dpu
+ - qcom,sm8650-dpu
+ - qcom,sm8750-dpu
+ - qcom,x1e80100-dpu
+ - items:
+ - enum:
+ - qcom,qcs8300-dpu
+ - const: qcom,sa8775p-dpu
reg:
items:
--
2.34.1
^ permalink raw reply [flat|nested] 17+ messages in thread* [PATCH v6 2/6] dt-bindings: display/msm: dp-controller: document QCS8300 compatible
2025-08-06 3:16 [PATCH v6 0/6] Display enablement changes for Qualcomm QCS8300 platform Yongxing Mou
2025-08-06 3:16 ` [PATCH v6 1/6] dt-bindings: display/msm: Document the DPU for QCS8300 Yongxing Mou
@ 2025-08-06 3:16 ` Yongxing Mou
2025-08-06 3:46 ` Dmitry Baryshkov
2025-08-06 3:16 ` [PATCH v6 3/6] dt-bindings: display/msm: Document MDSS on QCS8300 Yongxing Mou
` (3 subsequent siblings)
5 siblings, 1 reply; 17+ messages in thread
From: Yongxing Mou @ 2025-08-06 3:16 UTC (permalink / raw)
To: Rob Clark, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang,
Sean Paul, Marijn Suijten, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Neil Armstrong, Kuogee Hsieh,
Bjorn Andersson, Konrad Dybcio
Cc: linux-arm-msm, dri-devel, freedreno, devicetree, linux-kernel,
Yongxing Mou
Add compatible string for the DisplayPort controller found on the
Qualcomm QCS8300 SoC.
Signed-off-by: Yongxing Mou <quic_yongmou@quicinc.com>
---
Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
index 2893f097df826a5f941fbb754fb4a96a1e410a70..f5930f29c91ec95e9182c7b8ee83c0549c6657cc 100644
--- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
@@ -18,6 +18,7 @@ properties:
compatible:
oneOf:
- enum:
+ - qcom,qcs8300-dp
- qcom,sa8775p-dp
- qcom,sc7180-dp
- qcom,sc7280-dp
@@ -186,6 +187,7 @@ allOf:
compatible:
contains:
enum:
+ - qcom,qcs8300-dp
- qcom,sa8775p-dp
- qcom,sc7280-dp
- qcom,sc8180x-dp
--
2.34.1
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [PATCH v6 2/6] dt-bindings: display/msm: dp-controller: document QCS8300 compatible
2025-08-06 3:16 ` [PATCH v6 2/6] dt-bindings: display/msm: dp-controller: document QCS8300 compatible Yongxing Mou
@ 2025-08-06 3:46 ` Dmitry Baryshkov
2025-08-06 4:07 ` Yongxing Mou
0 siblings, 1 reply; 17+ messages in thread
From: Dmitry Baryshkov @ 2025-08-06 3:46 UTC (permalink / raw)
To: Yongxing Mou
Cc: Rob Clark, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang,
Sean Paul, Marijn Suijten, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Neil Armstrong, Kuogee Hsieh,
Bjorn Andersson, Konrad Dybcio, linux-arm-msm, dri-devel,
freedreno, devicetree, linux-kernel
On Wed, Aug 06, 2025 at 11:16:46AM +0800, Yongxing Mou wrote:
> Add compatible string for the DisplayPort controller found on the
> Qualcomm QCS8300 SoC.
Typical comment: you've missed the explanation, why it can not use
fallback.
>
> Signed-off-by: Yongxing Mou <quic_yongmou@quicinc.com>
> ---
> Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> index 2893f097df826a5f941fbb754fb4a96a1e410a70..f5930f29c91ec95e9182c7b8ee83c0549c6657cc 100644
> --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> @@ -18,6 +18,7 @@ properties:
> compatible:
> oneOf:
> - enum:
> + - qcom,qcs8300-dp
> - qcom,sa8775p-dp
> - qcom,sc7180-dp
> - qcom,sc7280-dp
> @@ -186,6 +187,7 @@ allOf:
> compatible:
> contains:
> enum:
> + - qcom,qcs8300-dp
> - qcom,sa8775p-dp
> - qcom,sc7280-dp
> - qcom,sc8180x-dp
>
> --
> 2.34.1
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v6 2/6] dt-bindings: display/msm: dp-controller: document QCS8300 compatible
2025-08-06 3:46 ` Dmitry Baryshkov
@ 2025-08-06 4:07 ` Yongxing Mou
2025-08-06 5:09 ` Dmitry Baryshkov
0 siblings, 1 reply; 17+ messages in thread
From: Yongxing Mou @ 2025-08-06 4:07 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Rob Clark, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang,
Sean Paul, Marijn Suijten, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Neil Armstrong, Kuogee Hsieh,
Bjorn Andersson, Konrad Dybcio, linux-arm-msm, dri-devel,
freedreno, devicetree, linux-kernel
On 2025/8/6 11:46, Dmitry Baryshkov wrote:
> On Wed, Aug 06, 2025 at 11:16:46AM +0800, Yongxing Mou wrote:
>> Add compatible string for the DisplayPort controller found on the
>> Qualcomm QCS8300 SoC.
>
>
> Typical comment: you've missed the explanation, why it can not use
> fallback.
>
Hi, Dmitry, we move this explanation to DP controller patch (patch 6).
There we provide a detailed explanation of the DP controller,why we need
this compatible, and why not use fallback. Thanks.
>>
>> Signed-off-by: Yongxing Mou <quic_yongmou@quicinc.com>
>> ---
>> Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
>> index 2893f097df826a5f941fbb754fb4a96a1e410a70..f5930f29c91ec95e9182c7b8ee83c0549c6657cc 100644
>> --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
>> +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
>> @@ -18,6 +18,7 @@ properties:
>> compatible:
>> oneOf:
>> - enum:
>> + - qcom,qcs8300-dp
>> - qcom,sa8775p-dp
>> - qcom,sc7180-dp
>> - qcom,sc7280-dp
>> @@ -186,6 +187,7 @@ allOf:
>> compatible:
>> contains:
>> enum:
>> + - qcom,qcs8300-dp
>> - qcom,sa8775p-dp
>> - qcom,sc7280-dp
>> - qcom,sc8180x-dp
>>
>> --
>> 2.34.1
>>
>
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v6 2/6] dt-bindings: display/msm: dp-controller: document QCS8300 compatible
2025-08-06 4:07 ` Yongxing Mou
@ 2025-08-06 5:09 ` Dmitry Baryshkov
2025-08-06 5:26 ` Yongxing Mou
0 siblings, 1 reply; 17+ messages in thread
From: Dmitry Baryshkov @ 2025-08-06 5:09 UTC (permalink / raw)
To: Yongxing Mou
Cc: Rob Clark, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang,
Sean Paul, Marijn Suijten, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Neil Armstrong, Kuogee Hsieh,
Bjorn Andersson, Konrad Dybcio, linux-arm-msm, dri-devel,
freedreno, devicetree, linux-kernel
On Wed, Aug 06, 2025 at 12:07:55PM +0800, Yongxing Mou wrote:
>
>
> On 2025/8/6 11:46, Dmitry Baryshkov wrote:
> > On Wed, Aug 06, 2025 at 11:16:46AM +0800, Yongxing Mou wrote:
> > > Add compatible string for the DisplayPort controller found on the
> > > Qualcomm QCS8300 SoC.
> >
> >
> > Typical comment: you've missed the explanation, why it can not use
> > fallback.
> >
> Hi, Dmitry, we move this explanation to DP controller patch (patch 6). There
> we provide a detailed explanation of the DP controller,why we need this
> compatible, and why not use fallback. Thanks.
They are different patches, reviewed by different people. C&P might be
helpful enough.
> > >
> > > Signed-off-by: Yongxing Mou <quic_yongmou@quicinc.com>
> > > ---
> > > Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 2 ++
> > > 1 file changed, 2 insertions(+)
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v6 2/6] dt-bindings: display/msm: dp-controller: document QCS8300 compatible
2025-08-06 5:09 ` Dmitry Baryshkov
@ 2025-08-06 5:26 ` Yongxing Mou
0 siblings, 0 replies; 17+ messages in thread
From: Yongxing Mou @ 2025-08-06 5:26 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Rob Clark, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang,
Sean Paul, Marijn Suijten, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Neil Armstrong, Kuogee Hsieh,
Bjorn Andersson, Konrad Dybcio, linux-arm-msm, dri-devel,
freedreno, devicetree, linux-kernel
On 2025/8/6 13:09, Dmitry Baryshkov wrote:
> They are different patches, reviewed by different people. C&P might be
> helpful enough.
Got it, thanks, will update in next version.
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH v6 3/6] dt-bindings: display/msm: Document MDSS on QCS8300
2025-08-06 3:16 [PATCH v6 0/6] Display enablement changes for Qualcomm QCS8300 platform Yongxing Mou
2025-08-06 3:16 ` [PATCH v6 1/6] dt-bindings: display/msm: Document the DPU for QCS8300 Yongxing Mou
2025-08-06 3:16 ` [PATCH v6 2/6] dt-bindings: display/msm: dp-controller: document QCS8300 compatible Yongxing Mou
@ 2025-08-06 3:16 ` Yongxing Mou
2025-08-06 3:16 ` [PATCH v6 4/6] drm/msm: mdss: Add QCS8300 support Yongxing Mou
` (2 subsequent siblings)
5 siblings, 0 replies; 17+ messages in thread
From: Yongxing Mou @ 2025-08-06 3:16 UTC (permalink / raw)
To: Rob Clark, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang,
Sean Paul, Marijn Suijten, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Neil Armstrong, Kuogee Hsieh,
Bjorn Andersson, Konrad Dybcio
Cc: linux-arm-msm, dri-devel, freedreno, devicetree, linux-kernel,
Yongxing Mou
Document the MDSS hardware found on the Qualcomm QCS8300 platform.
Signed-off-by: Yongxing Mou <quic_yongmou@quicinc.com>
---
.../bindings/display/msm/qcom,qcs8300-mdss.yaml | 282 +++++++++++++++++++++
1 file changed, 282 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/msm/qcom,qcs8300-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,qcs8300-mdss.yaml
new file mode 100644
index 0000000000000000000000000000000000000000..1cc51e286a667e956ca66955f594b7ccc9ef724f
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/msm/qcom,qcs8300-mdss.yaml
@@ -0,0 +1,282 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/msm/qcom,qcs8300-mdss.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm Technologies, Inc. QCS8300 Display MDSS
+
+maintainers:
+ - Yongxing Mou <quic_yongmou@quicinc.com>
+
+description:
+ QCS8300 MSM Mobile Display Subsystem(MDSS), which encapsulates sub-blocks like
+ DPU display controller, DP interfaces and EDP etc.
+
+$ref: /schemas/display/msm/mdss-common.yaml#
+
+properties:
+ compatible:
+ const: qcom,qcs8300-mdss
+
+ clocks:
+ items:
+ - description: Display AHB
+ - description: Display hf AXI
+ - description: Display core
+
+ iommus:
+ maxItems: 1
+
+ interconnects:
+ maxItems: 3
+
+ interconnect-names:
+ maxItems: 3
+
+patternProperties:
+ "^display-controller@[0-9a-f]+$":
+ type: object
+ additionalProperties: true
+
+ properties:
+ compatible:
+ contains:
+ const: qcom,qcs8300-dpu
+
+ "^displayport-controller@[0-9a-f]+$":
+ type: object
+ additionalProperties: true
+
+ properties:
+ compatible:
+ items:
+ - const: qcom,qcs8300-dp
+
+ "^phy@[0-9a-f]+$":
+ type: object
+ additionalProperties: true
+ properties:
+ compatible:
+ contains:
+ const: qcom,qcs8300-edp-phy
+
+required:
+ - compatible
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interconnect/qcom,icc.h>
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+ #include <dt-bindings/clock/qcom,qcs8300-gcc.h>
+ #include <dt-bindings/clock/qcom,sa8775p-dispcc.h>
+ #include <dt-bindings/interconnect/qcom,qcs8300-rpmh.h>
+ #include <dt-bindings/power/qcom,rpmhpd.h>
+ #include <dt-bindings/power/qcom-rpmpd.h>
+
+ mdss: display-subsystem@ae00000 {
+ compatible = "qcom,qcs8300-mdss";
+ reg = <0x0ae00000 0x1000>;
+ reg-names = "mdss";
+
+ interconnects = <&mmss_noc MASTER_MDP0 QCOM_ICC_TAG_ACTIVE_ONLY
+ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ACTIVE_ONLY>,
+ <&mmss_noc MASTER_MDP1 QCOM_ICC_TAG_ACTIVE_ONLY
+ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ACTIVE_ONLY>,
+ <&gem_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ACTIVE_ONLY
+ &config_noc SLAVE_DISPLAY_CFG QCOM_ICC_TAG_ACTIVE_ONLY>;
+ interconnect-names = "mdp0-mem",
+ "mdp1-mem",
+ "cpu-cfg";
+
+ resets = <&dispcc_core_bcr>;
+ power-domains = <&dispcc_gdsc>;
+
+ clocks = <&dispcc_ahb_clk>,
+ <&gcc GCC_DISP_HF_AXI_CLK>,
+ <&dispcc_mdp_clk>;
+
+ interrupts = <GIC_SPI 92 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-controller;
+ #interrupt-cells = <1>;
+
+ iommus = <&apps_smmu 0x1000 0x402>;
+
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges;
+
+ display-controller@ae01000 {
+ compatible = "qcom,qcs8300-dpu", "qcom,sa8775p-dpu";
+ reg = <0x0ae01000 0x8f000>,
+ <0x0aeb0000 0x2008>;
+ reg-names = "mdp", "vbif";
+
+ clocks = <&gcc GCC_DISP_HF_AXI_CLK>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_AHB_CLK>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_MDP_LUT_CLK>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_MDP_CLK>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_VSYNC_CLK>;
+ clock-names = "nrt_bus",
+ "iface",
+ "lut",
+ "core",
+ "vsync";
+
+ assigned-clocks = <&dispcc0 MDSS_DISP_CC_MDSS_VSYNC_CLK>;
+ assigned-clock-rates = <19200000>;
+ operating-points-v2 = <&mdp_opp_table>;
+ power-domains = <&rpmhpd RPMHPD_MMCX>;
+
+ interrupt-parent = <&mdss>;
+ interrupts = <0>;
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ port@0 {
+ reg = <0>;
+
+ dpu_intf0_out: endpoint {
+ remote-endpoint = <&mdss_dp0_in>;
+ };
+ };
+ };
+
+ mdp_opp_table: opp-table {
+ compatible = "operating-points-v2";
+
+ opp-375000000 {
+ opp-hz = /bits/ 64 <375000000>;
+ required-opps = <&rpmhpd_opp_svs_l1>;
+ };
+
+ opp-500000000 {
+ opp-hz = /bits/ 64 <500000000>;
+ required-opps = <&rpmhpd_opp_nom>;
+ };
+
+ opp-575000000 {
+ opp-hz = /bits/ 64 <575000000>;
+ required-opps = <&rpmhpd_opp_turbo>;
+ };
+
+ opp-650000000 {
+ opp-hz = /bits/ 64 <650000000>;
+ required-opps = <&rpmhpd_opp_turbo_l1>;
+ };
+ };
+ };
+
+ mdss_dp0_phy: phy@aec2a00 {
+ compatible = "qcom,qcs8300-edp-phy", "qcom,sa8775p-edp-phy";
+
+ reg = <0x0aec2a00 0x200>,
+ <0x0aec2200 0xd0>,
+ <0x0aec2600 0xd0>,
+ <0x0aec2000 0x1c8>;
+
+ clocks = <&dispcc MDSS_DISP_CC_MDSS_DPTX0_AUX_CLK>,
+ <&dispcc MDSS_DISP_CC_MDSS_AHB_CLK>;
+ clock-names = "aux",
+ "cfg_ahb";
+
+ #clock-cells = <1>;
+ #phy-cells = <0>;
+
+ vdda-phy-supply = <&vreg_l1c>;
+ vdda-pll-supply = <&vreg_l4a>;
+ };
+
+ displayport-controller@af54000 {
+ compatible = "qcom,qcs8300-dp";
+
+ pinctrl-0 = <&dp_hot_plug_det>;
+ pinctrl-names = "default";
+
+ reg = <0xaf54000 0x104>,
+ <0xaf54200 0x0c0>,
+ <0xaf55000 0x770>,
+ <0xaf56000 0x09c>,
+ <0xaf57000 0x09c>;
+
+ interrupt-parent = <&mdss>;
+ interrupts = <12>;
+ clocks = <&dispcc0 MDSS_DISP_CC_MDSS_AHB_CLK>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_AUX_CLK>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_LINK_CLK>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_LINK_INTF_CLK>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_PIXEL0_CLK>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_PIXEL1_CLK>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_PIXEL2_CLK>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_PIXEL3_CLK>;
+ clock-names = "core_iface",
+ "core_aux",
+ "ctrl_link",
+ "ctrl_link_iface",
+ "stream_pixel",
+ "stream_1_pixel",
+ "stream_2_pixel",
+ "stream_3_pixel";
+ assigned-clocks = <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_LINK_CLK_SRC>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_PIXEL0_CLK_SRC>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_PIXEL1_CLK_SRC>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_PIXEL2_CLK_SRC>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_PIXEL3_CLK_SRC>;
+ assigned-clock-parents = <&mdss_dp0_phy 0>,
+ <&mdss_dp0_phy 1>,
+ <&mdss_dp0_phy 1>,
+ <&mdss_dp0_phy 1>;
+ phys = <&mdss_dp0_phy>;
+ phy-names = "dp";
+ operating-points-v2 = <&dp_opp_table>;
+ power-domains = <&rpmhpd RPMHPD_MMCX>;
+
+ #sound-dai-cells = <0>;
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+
+ mdss_dp0_in: endpoint {
+ remote-endpoint = <&dpu_intf0_out>;
+ };
+ };
+
+ port@1 {
+ reg = <1>;
+
+ mdss_dp_out: endpoint { };
+ };
+ };
+
+ dp_opp_table: opp-table {
+ compatible = "operating-points-v2";
+
+ opp-160000000 {
+ opp-hz = /bits/ 64 <160000000>;
+ required-opps = <&rpmhpd_opp_low_svs>;
+ };
+
+ opp-270000000 {
+ opp-hz = /bits/ 64 <270000000>;
+ required-opps = <&rpmhpd_opp_svs>;
+ };
+
+ opp-540000000 {
+ opp-hz = /bits/ 64 <540000000>;
+ required-opps = <&rpmhpd_opp_svs_l1>;
+ };
+
+ opp-810000000 {
+ opp-hz = /bits/ 64 <810000000>;
+ required-opps = <&rpmhpd_opp_nom>;
+ };
+ };
+ };
+ };
+...
--
2.34.1
^ permalink raw reply [flat|nested] 17+ messages in thread* [PATCH v6 4/6] drm/msm: mdss: Add QCS8300 support
2025-08-06 3:16 [PATCH v6 0/6] Display enablement changes for Qualcomm QCS8300 platform Yongxing Mou
` (2 preceding siblings ...)
2025-08-06 3:16 ` [PATCH v6 3/6] dt-bindings: display/msm: Document MDSS on QCS8300 Yongxing Mou
@ 2025-08-06 3:16 ` Yongxing Mou
2025-08-06 3:34 ` Dmitry Baryshkov
2025-08-06 3:16 ` [PATCH v6 5/6] soc: qcom: ubwc: Add QCS8300 UBWC cfg Yongxing Mou
2025-08-06 3:16 ` [PATCH v6 6/6] drm/msm/dp: Add DisplayPort controller for QCS8300 Yongxing Mou
5 siblings, 1 reply; 17+ messages in thread
From: Yongxing Mou @ 2025-08-06 3:16 UTC (permalink / raw)
To: Rob Clark, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang,
Sean Paul, Marijn Suijten, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Neil Armstrong, Kuogee Hsieh,
Bjorn Andersson, Konrad Dybcio
Cc: linux-arm-msm, dri-devel, freedreno, devicetree, linux-kernel,
Yongxing Mou
Add Mobile Display Subsystem (MDSS) support for the QCS8300 platform.
Signed-off-by: Yongxing Mou <quic_yongmou@quicinc.com>
---
drivers/gpu/drm/msm/msm_mdss.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c
index 1f5fe7811e016909282087176a42a2349b21c9c4..d77b4dcb6d798f9f0598c64a593f0bbebe85e831 100644
--- a/drivers/gpu/drm/msm/msm_mdss.c
+++ b/drivers/gpu/drm/msm/msm_mdss.c
@@ -556,6 +556,7 @@ static const struct of_device_id mdss_dt_match[] = {
{ .compatible = "qcom,mdss", .data = &data_153k6 },
{ .compatible = "qcom,msm8998-mdss", .data = &data_76k8 },
{ .compatible = "qcom,qcm2290-mdss", .data = &data_76k8 },
+ { .compatible = "qcom,qcs8300-mdss", .data = &data_74k },
{ .compatible = "qcom,sa8775p-mdss", .data = &data_74k },
{ .compatible = "qcom,sar2130p-mdss", .data = &data_74k },
{ .compatible = "qcom,sdm670-mdss", .data = &data_76k8 },
--
2.34.1
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [PATCH v6 4/6] drm/msm: mdss: Add QCS8300 support
2025-08-06 3:16 ` [PATCH v6 4/6] drm/msm: mdss: Add QCS8300 support Yongxing Mou
@ 2025-08-06 3:34 ` Dmitry Baryshkov
2025-08-06 4:08 ` Yongxing Mou
0 siblings, 1 reply; 17+ messages in thread
From: Dmitry Baryshkov @ 2025-08-06 3:34 UTC (permalink / raw)
To: Yongxing Mou
Cc: Rob Clark, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang,
Sean Paul, Marijn Suijten, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Neil Armstrong, Kuogee Hsieh,
Bjorn Andersson, Konrad Dybcio, linux-arm-msm, dri-devel,
freedreno, devicetree, linux-kernel
On Wed, Aug 06, 2025 at 11:16:48AM +0800, Yongxing Mou wrote:
> Add Mobile Display Subsystem (MDSS) support for the QCS8300 platform.
>
> Signed-off-by: Yongxing Mou <quic_yongmou@quicinc.com>
> ---
> drivers/gpu/drm/msm/msm_mdss.c | 1 +
> 1 file changed, 1 insertion(+)
>
Nit: the order of patches is incorrect, UBWC should come before MDSS. No
need to resend the series just for the sake of this change.
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v6 4/6] drm/msm: mdss: Add QCS8300 support
2025-08-06 3:34 ` Dmitry Baryshkov
@ 2025-08-06 4:08 ` Yongxing Mou
0 siblings, 0 replies; 17+ messages in thread
From: Yongxing Mou @ 2025-08-06 4:08 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Rob Clark, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang,
Sean Paul, Marijn Suijten, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Neil Armstrong, Kuogee Hsieh,
Bjorn Andersson, Konrad Dybcio, linux-arm-msm, dri-devel,
freedreno, devicetree, linux-kernel
On 2025/8/6 11:34, Dmitry Baryshkov wrote:
> On Wed, Aug 06, 2025 at 11:16:48AM +0800, Yongxing Mou wrote:
>> Add Mobile Display Subsystem (MDSS) support for the QCS8300 platform.
>>
>> Signed-off-by: Yongxing Mou <quic_yongmou@quicinc.com>
>> ---
>> drivers/gpu/drm/msm/msm_mdss.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
> Nit: the order of patches is incorrect, UBWC should come before MDSS. No
> need to resend the series just for the sake of this change.
>
Thanks for point that..
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH v6 5/6] soc: qcom: ubwc: Add QCS8300 UBWC cfg
2025-08-06 3:16 [PATCH v6 0/6] Display enablement changes for Qualcomm QCS8300 platform Yongxing Mou
` (3 preceding siblings ...)
2025-08-06 3:16 ` [PATCH v6 4/6] drm/msm: mdss: Add QCS8300 support Yongxing Mou
@ 2025-08-06 3:16 ` Yongxing Mou
2025-08-06 3:32 ` Dmitry Baryshkov
2025-08-06 8:59 ` Konrad Dybcio
2025-08-06 3:16 ` [PATCH v6 6/6] drm/msm/dp: Add DisplayPort controller for QCS8300 Yongxing Mou
5 siblings, 2 replies; 17+ messages in thread
From: Yongxing Mou @ 2025-08-06 3:16 UTC (permalink / raw)
To: Rob Clark, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang,
Sean Paul, Marijn Suijten, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Neil Armstrong, Kuogee Hsieh,
Bjorn Andersson, Konrad Dybcio
Cc: linux-arm-msm, dri-devel, freedreno, devicetree, linux-kernel,
Yongxing Mou
The QCS8300 supports UBWC 4.0 and 4 channels LP5 memory interface. Use
the SC8280XP as fallback for QCS8300 according to the specification.
Signed-off-by: Yongxing Mou <quic_yongmou@quicinc.com>
---
drivers/soc/qcom/ubwc_config.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/soc/qcom/ubwc_config.c b/drivers/soc/qcom/ubwc_config.c
index bd0a98aad9f3b222abcf0a7af85a318caffa9841..061420826fb9946e58ac1ae5452c603193378839 100644
--- a/drivers/soc/qcom/ubwc_config.c
+++ b/drivers/soc/qcom/ubwc_config.c
@@ -225,6 +225,7 @@ static const struct of_device_id qcom_ubwc_configs[] __maybe_unused = {
{ .compatible = "qcom,msm8998", .data = &msm8998_data },
{ .compatible = "qcom,qcm2290", .data = &qcm2290_data, },
{ .compatible = "qcom,qcm6490", .data = &sc7280_data, },
+ { .compatible = "qcom,qcs8300", .data = &sc8280xp_data, },
{ .compatible = "qcom,sa8155p", .data = &sm8150_data, },
{ .compatible = "qcom,sa8540p", .data = &sc8280xp_data, },
{ .compatible = "qcom,sa8775p", .data = &sa8775p_data, },
--
2.34.1
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [PATCH v6 5/6] soc: qcom: ubwc: Add QCS8300 UBWC cfg
2025-08-06 3:16 ` [PATCH v6 5/6] soc: qcom: ubwc: Add QCS8300 UBWC cfg Yongxing Mou
@ 2025-08-06 3:32 ` Dmitry Baryshkov
2025-08-11 18:30 ` Bjorn Andersson
2025-08-06 8:59 ` Konrad Dybcio
1 sibling, 1 reply; 17+ messages in thread
From: Dmitry Baryshkov @ 2025-08-06 3:32 UTC (permalink / raw)
To: Yongxing Mou
Cc: Rob Clark, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang,
Sean Paul, Marijn Suijten, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Neil Armstrong, Kuogee Hsieh,
Bjorn Andersson, Konrad Dybcio, linux-arm-msm, dri-devel,
freedreno, devicetree, linux-kernel
On Wed, Aug 06, 2025 at 11:16:49AM +0800, Yongxing Mou wrote:
> The QCS8300 supports UBWC 4.0 and 4 channels LP5 memory interface. Use
> the SC8280XP as fallback for QCS8300 according to the specification.
>
> Signed-off-by: Yongxing Mou <quic_yongmou@quicinc.com>
> ---
> drivers/soc/qcom/ubwc_config.c | 1 +
> 1 file changed, 1 insertion(+)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Bjorn, is there a chance that you'd ack merging this through the msm
tree?
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v6 5/6] soc: qcom: ubwc: Add QCS8300 UBWC cfg
2025-08-06 3:32 ` Dmitry Baryshkov
@ 2025-08-11 18:30 ` Bjorn Andersson
0 siblings, 0 replies; 17+ messages in thread
From: Bjorn Andersson @ 2025-08-11 18:30 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Yongxing Mou, Rob Clark, Dmitry Baryshkov, Abhinav Kumar,
Jessica Zhang, Sean Paul, Marijn Suijten, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Neil Armstrong,
Kuogee Hsieh, Konrad Dybcio, linux-arm-msm, dri-devel, freedreno,
devicetree, linux-kernel
On Wed, Aug 06, 2025 at 06:32:20AM +0300, Dmitry Baryshkov wrote:
> On Wed, Aug 06, 2025 at 11:16:49AM +0800, Yongxing Mou wrote:
> > The QCS8300 supports UBWC 4.0 and 4 channels LP5 memory interface. Use
> > the SC8280XP as fallback for QCS8300 according to the specification.
> >
> > Signed-off-by: Yongxing Mou <quic_yongmou@quicinc.com>
> > ---
> > drivers/soc/qcom/ubwc_config.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
>
> Bjorn, is there a chance that you'd ack merging this through the msm
> tree?
Acked-by: Bjorn Andersson <andersson@kernel.org>
Regards,
Bjorn
>
> --
> With best wishes
> Dmitry
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v6 5/6] soc: qcom: ubwc: Add QCS8300 UBWC cfg
2025-08-06 3:16 ` [PATCH v6 5/6] soc: qcom: ubwc: Add QCS8300 UBWC cfg Yongxing Mou
2025-08-06 3:32 ` Dmitry Baryshkov
@ 2025-08-06 8:59 ` Konrad Dybcio
1 sibling, 0 replies; 17+ messages in thread
From: Konrad Dybcio @ 2025-08-06 8:59 UTC (permalink / raw)
To: Yongxing Mou, Rob Clark, Dmitry Baryshkov, Abhinav Kumar,
Jessica Zhang, Sean Paul, Marijn Suijten, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Neil Armstrong,
Kuogee Hsieh, Bjorn Andersson, Konrad Dybcio
Cc: linux-arm-msm, dri-devel, freedreno, devicetree, linux-kernel
On 8/6/25 5:16 AM, Yongxing Mou wrote:
> The QCS8300 supports UBWC 4.0 and 4 channels LP5 memory interface. Use
> the SC8280XP as fallback for QCS8300 according to the specification.
>
> Signed-off-by: Yongxing Mou <quic_yongmou@quicinc.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH v6 6/6] drm/msm/dp: Add DisplayPort controller for QCS8300
2025-08-06 3:16 [PATCH v6 0/6] Display enablement changes for Qualcomm QCS8300 platform Yongxing Mou
` (4 preceding siblings ...)
2025-08-06 3:16 ` [PATCH v6 5/6] soc: qcom: ubwc: Add QCS8300 UBWC cfg Yongxing Mou
@ 2025-08-06 3:16 ` Yongxing Mou
2025-08-06 3:33 ` Dmitry Baryshkov
5 siblings, 1 reply; 17+ messages in thread
From: Yongxing Mou @ 2025-08-06 3:16 UTC (permalink / raw)
To: Rob Clark, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang,
Sean Paul, Marijn Suijten, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Neil Armstrong, Kuogee Hsieh,
Bjorn Andersson, Konrad Dybcio
Cc: linux-arm-msm, dri-devel, freedreno, devicetree, linux-kernel,
Yongxing Mou
The Qualcomm QCS8300 platform comes with one DisplayPort controller
with same base offset as SM8650. But it requires new compatible string
because QCS8300 controller supports 4 MST streams. 4 MST streams will
be enabled as part of MST feature support. Currently, using SM8650 as
fallback to enable SST on QCS8300.
Signed-off-by: Yongxing Mou <quic_yongmou@quicinc.com>
---
drivers/gpu/drm/msm/dp/dp_display.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c
index d87d47cc7ec3eb757ac192c411000bc50b824c59..bb4660585849d1a67921a28e7e12422e0c327ab2 100644
--- a/drivers/gpu/drm/msm/dp/dp_display.c
+++ b/drivers/gpu/drm/msm/dp/dp_display.c
@@ -187,6 +187,7 @@ static const struct msm_dp_desc msm_dp_desc_x1e80100[] = {
};
static const struct of_device_id msm_dp_dt_match[] = {
+ { .compatible = "qcom,qcs8300-dp", .data = &msm_dp_desc_sm8650 },
{ .compatible = "qcom,sa8775p-dp", .data = &msm_dp_desc_sa8775p },
{ .compatible = "qcom,sc7180-dp", .data = &msm_dp_desc_sc7180 },
{ .compatible = "qcom,sc7280-dp", .data = &msm_dp_desc_sc7280 },
--
2.34.1
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [PATCH v6 6/6] drm/msm/dp: Add DisplayPort controller for QCS8300
2025-08-06 3:16 ` [PATCH v6 6/6] drm/msm/dp: Add DisplayPort controller for QCS8300 Yongxing Mou
@ 2025-08-06 3:33 ` Dmitry Baryshkov
0 siblings, 0 replies; 17+ messages in thread
From: Dmitry Baryshkov @ 2025-08-06 3:33 UTC (permalink / raw)
To: Yongxing Mou
Cc: Rob Clark, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang,
Sean Paul, Marijn Suijten, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Neil Armstrong, Kuogee Hsieh,
Bjorn Andersson, Konrad Dybcio, linux-arm-msm, dri-devel,
freedreno, devicetree, linux-kernel
On Wed, Aug 06, 2025 at 11:16:50AM +0800, Yongxing Mou wrote:
> The Qualcomm QCS8300 platform comes with one DisplayPort controller
> with same base offset as SM8650. But it requires new compatible string
> because QCS8300 controller supports 4 MST streams. 4 MST streams will
> be enabled as part of MST feature support. Currently, using SM8650 as
> fallback to enable SST on QCS8300.
>
> Signed-off-by: Yongxing Mou <quic_yongmou@quicinc.com>
> ---
> drivers/gpu/drm/msm/dp/dp_display.c | 1 +
> 1 file changed, 1 insertion(+)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 17+ messages in thread