From: Richard Fitzgerald <rf@opensource.cirrus.com>
To: Ziyi Guo <n7l8m4@u.northwestern.edu>,
Simon Trimmer <simont@opensource.cirrus.com>,
Charles Keepax <ckeepax@opensource.cirrus.com>
Cc: patches@opensource.cirrus.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] firmware: cs_dsp: fix missing pwr_lock in cs_dsp_stop()
Date: Fri, 27 Feb 2026 10:03:27 +0000 [thread overview]
Message-ID: <a5bfa307-c527-4233-aecc-3e5f264d261d@opensource.cirrus.com> (raw)
In-Reply-To: <20260202144153.1668326-1-n7l8m4@u.northwestern.edu>
On 02/02/2026 2:41 pm, Ziyi Guo wrote:
> cs_dsp_signal_event_controls() calls cs_dsp_coeff_write_acked_control()
> which has lockdep_assert_held(&dsp->pwr_lock), but the lock is not held.
>
> cs_dsp_signal_event_controls() is invoked from cs_dsp_stop().
>
> Put mutex_lock() at the top of cs_dsp_stop() to fix the
> missing lock protection, also align with cs_dsp_run().
>
> Signed-off-by: Ziyi Guo <n7l8m4@u.northwestern.edu>
> ---
> v2:
> - Put mutex_lock() at the top of cs_dsp_stop() to fix and align with cs_dsp_run()
>
You need to send this patch to Mark Brown <broonie@kernel.org> and also
add linux-sound@vger.kernel.org to your cc list
prev parent reply other threads:[~2026-02-27 10:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-02 14:41 Ziyi Guo
2026-02-02 14:56 ` Richard Fitzgerald
2026-02-27 10:03 ` Richard Fitzgerald [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5bfa307-c527-4233-aecc-3e5f264d261d@opensource.cirrus.com \
--to=rf@opensource.cirrus.com \
--cc=ckeepax@opensource.cirrus.com \
--cc=linux-kernel@vger.kernel.org \
--cc=n7l8m4@u.northwestern.edu \
--cc=patches@opensource.cirrus.com \
--cc=simont@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®