* [PATCH] ASoC: atmel: mchp-pdmc: Remove unnecessary print function dev_err()
@ 2022-03-10 0:22 Jiapeng Chong
2022-03-10 7:22 ` Codrin.Ciubotariu
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2022-03-10 0:22 UTC (permalink / raw)
To: codrin.ciubotariu
Cc: lgirdwood, broonie, perex, tiwai, nicolas.ferre,
alexandre.belloni, claudiu.beznea, alsa-devel, linux-arm-kernel,
linux-kernel, Jiapeng Chong, Abaci Robot
The print function dev_err() is redundant because
platform_get_irq() already prints an error.
Eliminate the follow coccicheck warning:
./sound/soc/atmel/mchp-pdmc.c:991:2-9: line 991 is redundant because
platform_get_irq() already prints an error.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
sound/soc/atmel/mchp-pdmc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/sound/soc/atmel/mchp-pdmc.c b/sound/soc/atmel/mchp-pdmc.c
index c44636f6207d..2b48bd3434c7 100644
--- a/sound/soc/atmel/mchp-pdmc.c
+++ b/sound/soc/atmel/mchp-pdmc.c
@@ -988,7 +988,6 @@ static int mchp_pdmc_probe(struct platform_device *pdev)
irq = platform_get_irq(pdev, 0);
if (irq < 0) {
- dev_err(dev, "failed to get irq: %d\n", irq);
return irq;
}
--
2.20.1.7.g153144c
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] ASoC: atmel: mchp-pdmc: Remove unnecessary print function dev_err()
2022-03-10 0:22 [PATCH] ASoC: atmel: mchp-pdmc: Remove unnecessary print function dev_err() Jiapeng Chong
@ 2022-03-10 7:22 ` Codrin.Ciubotariu
0 siblings, 0 replies; 2+ messages in thread
From: Codrin.Ciubotariu @ 2022-03-10 7:22 UTC (permalink / raw)
To: jiapeng.chong
Cc: lgirdwood, broonie, perex, tiwai, Nicolas.Ferre,
alexandre.belloni, Claudiu.Beznea, alsa-devel, linux-arm-kernel,
linux-kernel, abaci
On 10.03.2022 02:22, Jiapeng Chong wrote:
> diff --git a/sound/soc/atmel/mchp-pdmc.c b/sound/soc/atmel/mchp-pdmc.c
> index c44636f6207d..2b48bd3434c7 100644
> --- a/sound/soc/atmel/mchp-pdmc.c
> +++ b/sound/soc/atmel/mchp-pdmc.c
> @@ -988,7 +988,6 @@ static int mchp_pdmc_probe(struct platform_device *pdev)
>
> irq = platform_get_irq(pdev, 0);
> if (irq < 0) {
> - dev_err(dev, "failed to get irq: %d\n", irq);
> return irq;
> }
The braces should also be removed. With that addressed, you can add:
Reviewed-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
Thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-10 7:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-10 0:22 [PATCH] ASoC: atmel: mchp-pdmc: Remove unnecessary print function dev_err() Jiapeng Chong
2022-03-10 7:22 ` Codrin.Ciubotariu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®