mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Akshay Gupta <akshay.gupta@amd.com>,
	linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org
Cc: gregkh@linuxfoundation.org, arnd@arndb.de, linux@roeck-us.net,
	Anand.Umarji@amd.com,
	Naveen Krishna Chatradhi <naveenkrishna.chatradhi@amd.com>
Subject: Re: [PATCH v1 3/5] dt-bindings: misc: Move amd,sbrmi.yaml from hwmon to misc
Date: Tue, 29 Jul 2025 08:29:14 +0200	[thread overview]
Message-ID: <a6103665-466b-421a-8181-5110354bafdf@kernel.org> (raw)
In-Reply-To: <20250728061033.1604169-3-akshay.gupta@amd.com>

On 28/07/2025 08:10, Akshay Gupta wrote:
> - AMD SB-RMI patches are moved from drivers/hwmon to
>   drivers/misc to support additional functionality.
>   Move the related bindings documentation files to misc.
> 
> Reviewed-by: Naveen Krishna Chatradhi <naveenkrishna.chatradhi@amd.com>

Really? What was reviewed here exactly? Poor style of commit msg or that
rename actually does rename?

> Signed-off-by: Akshay Gupta <akshay.gupta@amd.com>
> ---
>  Documentation/devicetree/bindings/{hwmon => misc}/amd,sbrmi.yaml | 0

We don't put bindings into MISC.

<form letter>
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.

Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline) or work on fork of kernel
(don't, instead use mainline). Just use b4 and everything should be
fine, although remember about `b4 prep --auto-to-cc` if you added new
patches to the patchset.

You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time.

Please kindly resend and include all necessary To/Cc entries.
</form letter>




Best regards,
Krzysztof

  reply	other threads:[~2025-07-29  6:29 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-28  6:10 [PATCH v1 1/5] misc: amd-sbi: Split core driver as separate module Akshay Gupta
2025-07-28  6:10 ` [PATCH v1 2/5] misc: amd-sbi: Add support for SB-RMI over I3C Akshay Gupta
2025-07-28  6:37   ` Thomas Weißschuh
2025-08-11 11:02     ` Gupta, Akshay
2025-07-29  6:33   ` Krzysztof Kozlowski
2025-08-11 11:03     ` Gupta, Akshay
2025-07-28  6:10 ` [PATCH v1 3/5] dt-bindings: misc: Move amd,sbrmi.yaml from hwmon to misc Akshay Gupta
2025-07-29  6:29   ` Krzysztof Kozlowski [this message]
2025-08-11 11:54     ` Gupta, Akshay
2025-08-11 11:56       ` Krzysztof Kozlowski
2025-07-28  6:10 ` [PATCH v1 4/5] dt-bindings: misc: Update the "$id:" to misc path Akshay Gupta
2025-07-29  6:29   ` Krzysztof Kozlowski
2025-07-28  6:10 ` [PATCH v1 5/5] dt-bindings: misc: Add binding document for SB-RMI I3C Akshay Gupta
2025-07-29  6:31   ` Krzysztof Kozlowski
2025-08-11 11:55     ` Gupta, Akshay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a6103665-466b-421a-8181-5110354bafdf@kernel.org \
    --to=krzk@kernel.org \
    --cc=Anand.Umarji@amd.com \
    --cc=akshay.gupta@amd.com \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=naveenkrishna.chatradhi@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®