From: Yongxing Mou <yongxing.mou@oss.qualcomm.com>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: Rob Clark <robin.clark@oss.qualcomm.com>,
Dmitry Baryshkov <lumag@kernel.org>,
Abhinav Kumar <abhinav.kumar@linux.dev>,
Sean Paul <sean@poorly.run>,
Marijn Suijten <marijn.suijten@somainline.org>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Jessica Zhang <jesszhan0024@gmail.com>,
linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Abhinav Kumar <quic_abhinavk@quicinc.com>
Subject: Re: [PATCH v7 08/35] drm/msm/dp: add support to send ACT packets for MST
Date: Thu, 19 Nov 2026 15:35:51 +0800 [thread overview]
Message-ID: <a63614cd-93e4-4c5e-8d76-78a6b77a96f3@oss.qualcomm.com> (raw)
In-Reply-To: <y446bfbdgsqqwuu3masamj33cvcksp2xdeltvaeojpolgga3fg@awtfd4bgpy7h>
On 11/11/2026 10:22 PM, Dmitry Baryshkov wrote:
> On Thu, Oct 15, 2026 at 06:28:52PM +0800, Yongxing Mou wrote:
>>
>>
>> On 10/12/2026 8:23 PM, Dmitry Baryshkov wrote:
>>> On Mon, Oct 12, 2026 at 04:44:06PM +0800, Yongxing Mou wrote:
>>>>
>>>>
>>>> On 10/1/2026 6:32 PM, Dmitry Baryshkov wrote:
>>>>> On Tue, Sep 29, 2026 at 12:25:32PM +0800, Yongxing Mou wrote:
>>>>>> From: Abhinav Kumar <quic_abhinavk@quicinc.com>
>>>>>>
>>>>>> Whenever virtual channel slot allocation changes, the DP
>>>>>> source must send the action control trigger sequence to notify
>>>>>> the sink about the same. This would be applicable during the
>>>>>> start and stop of the pixel stream. Add the infrastructure
>>>>>> to be able to send ACT packets for the DP controller when
>>>>>> operating in MST mode.
>>>>>>
>>>>>> Add REG_DP_MST_ACT, the ACT trigger register used by this sequence.
>>>>>>
>>>>>> Signed-off-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
>>>>>> Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com>
>>>>>> ---
>>>>>> drivers/gpu/drm/msm/dp/dp_ctrl.c | 44 ++++++++++++++++++++++++++++++++++++-
>>>>>> drivers/gpu/drm/msm/dp/dp_ctrl.h | 5 ++++-
>>>>>> drivers/gpu/drm/msm/dp/dp_display.c | 3 ++-
>>>>>> drivers/gpu/drm/msm/dp/dp_display.h | 1 +
>>>>>> drivers/gpu/drm/msm/dp/dp_reg.h | 1 +
>>>>>> 5 files changed, 51 insertions(+), 3 deletions(-)
>>>>>>
>>>>>> diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.c b/drivers/gpu/drm/msm/dp/dp_ctrl.c
>>>>>> index e1614bc49a7c..65d22505c2b6 100644
>>>>>> --- a/drivers/gpu/drm/msm/dp/dp_ctrl.c
>>>>>> +++ b/drivers/gpu/drm/msm/dp/dp_ctrl.c
>>>>>> @@ -142,6 +142,7 @@ struct msm_dp_ctrl_private {
>>>>>> bool core_clks_on;
>>>>>> bool link_clks_on;
>>>>>> bool stream_clks_on[DP_STREAM_MAX];
>>>>>> + bool mst_active;
>>>>>
>>>>> I really don't like the idea of having this flag in two locations. Here
>>>>> and in the msm_dp_display_private. Can we have it in one place only?
>>>>>
>>>> These two fields are intended to represent different states with different
>>>> lifetimes.
>>>>
>>>> msm_dp::mst_active tracks whether the DP connection has an active MST
>>>> session. The controller field records whether the current controller/link is
>>>> operating in MST mode and remains valid until the link is shut down.
>>>>
>>>> I agree that using mst_active for both fields makes them look like
>>>> duplicated state. I propose renaming the controller field to mst_mode while
>>>> keeping the display-side field as mst_active.
>>>>
>>>> Would you agree with this change?
>>>
>>> What is the difference between these two? I.e. what os the difference
>>> between those two?
>>>
>> The difference between these two states mainly shows up during unplug.
>> mst_active is cleared when dp_display starts handling the unplug, while
>> dp_ctrl needs to keep the MST state until all streams are disabled and the
>> link is shut down.
>>
>> So there is a period during teardown where these two states are different,
>> which is expected.
>>
>> My concern with keeping only one state is that we would need to pass the MST
>> mode through multiple dp_ctrl APIs, which would make the code more
>> complicated. Would it make sense to keep this state in dp_ctrl and rename it
>> to mst_mode to make the distinction clearer?
>
> Sorry for the delayed response. How would the driver behave while those
> two disagree? What happens if the user unplugs the MST sink and then,
> without stopping the display, plugs in the SST sink?
>
The window does exist, but it's extremely(130~200ms in my monaco device)
short and hard for a user to actually hit. It only exists when the
disable commit is asynchronous.
We can consider introducing drm_dp_mst_root_conn_atomic_check(). It's
specifically designed to serialize the MST disable commit against the
SST enable commit.
>
next prev parent reply other threads:[~2026-11-19 7:36 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-29 4:25 [PATCH v7 00/35] drm/msm/dp: Add MST support for MSM chipsets Yongxing Mou
2026-09-29 4:25 ` [PATCH v7 01/35] drm/msm/dp: move link-level teardown from display_disable to display_unprepare Yongxing Mou
2026-10-01 10:11 ` Dmitry Baryshkov
2026-09-29 4:25 ` [PATCH v7 02/35] drm/msm/dp: Pass panel to msm_dp_ctrl_config_msa() Yongxing Mou
2026-10-01 10:13 ` Dmitry Baryshkov
2026-09-29 4:25 ` [PATCH v7 03/35] drm/msm/dp: drop redundant config_ctrl_link() from msm_dp_ctrl_on_stream() Yongxing Mou
2026-10-01 10:13 ` Dmitry Baryshkov
2026-09-29 4:25 ` [PATCH v7 04/35] drm/msm/dp: introduce stream_id for each DP panel Yongxing Mou
2026-10-01 10:23 ` Dmitry Baryshkov
2026-09-29 4:25 ` [PATCH v7 05/35] drm/msm/dp: add support for programming p1/p2/p3 register blocks Yongxing Mou
2026-10-01 10:24 ` Dmitry Baryshkov
2026-09-29 4:25 ` [PATCH v7 06/35] drm/msm/dp: add MST stream register definitions Yongxing Mou
2026-10-01 10:26 ` Dmitry Baryshkov
2026-09-29 4:25 ` [PATCH v7 07/35] drm/msm/dp: add stream-aware link register accessors Yongxing Mou
2026-10-01 10:26 ` Dmitry Baryshkov
2026-09-29 4:25 ` [PATCH v7 08/35] drm/msm/dp: add support to send ACT packets for MST Yongxing Mou
2026-10-01 10:32 ` Dmitry Baryshkov
2026-10-12 8:44 ` Yongxing Mou
2026-10-12 12:23 ` Dmitry Baryshkov
2026-10-15 10:28 ` Yongxing Mou
2026-11-11 14:22 ` Dmitry Baryshkov
2026-11-19 7:35 ` Yongxing Mou [this message]
2026-09-29 4:25 ` [PATCH v7 09/35] drm/msm/dp: add support to enable MST in mainlink control Yongxing Mou
2026-09-29 4:25 ` [PATCH v7 10/35] drm/msm/dp: no need to update tu calculation for mst Yongxing Mou
2026-09-29 4:25 ` [PATCH v7 11/35] drm/msm/dp: always program MST_FIFO_CONSTANT_FILL for MST use cases Yongxing Mou
2026-09-29 4:25 ` [PATCH v7 12/35] drm/msm/dp: add support for sending VCPF packets in DP controller Yongxing Mou
2026-09-29 4:25 ` [PATCH v7 13/35] drm/msm/dp: add support for MST channel slot allocation Yongxing Mou
2026-10-01 10:52 ` Dmitry Baryshkov
2026-10-15 13:24 ` Yongxing Mou
2026-11-08 19:20 ` Dmitry Baryshkov
2026-11-10 9:40 ` Yongxing Mou
2026-11-11 14:22 ` Dmitry Baryshkov
2026-09-29 4:25 ` [PATCH v7 14/35] drm/msm/dp: replace power_on with active_stream_cnt Yongxing Mou
2026-09-29 4:25 ` [PATCH v7 15/35] drm/msm/dp: factor out _helper variants of bridge ops accepting a panel Yongxing Mou
2026-09-29 4:25 ` [PATCH v7 16/35] drm/msm/dp: add link_ready to manage link-level operations Yongxing Mou
2026-09-29 4:25 ` [PATCH v7 17/35] drm/msm/dp: add msm_dp_display_get_panel() to initialize DP panel Yongxing Mou
2026-09-29 4:25 ` [PATCH v7 18/35] drm/msm/dp: introduce dp_mst_drm module Yongxing Mou
2026-09-29 4:25 ` [PATCH v7 19/35] drm/msm/dp: add MST connector creation and topology callbacks Yongxing Mou
2026-09-29 4:25 ` [PATCH v7 20/35] drm/msm/dpu: pass msm_display_info to dpu_encoder_get_intf() Yongxing Mou
2026-09-29 4:25 ` [PATCH v7 21/35] drm/msm/dpu: use stream_id to select MST interfaces Yongxing Mou
2026-09-29 4:25 ` [PATCH v7 22/35] drm/msm/dpu: add per-stream MST encoders Yongxing Mou
2026-09-29 4:25 ` [PATCH v7 23/35] drm/msm/dp: move link capabilities to dp_link Yongxing Mou
2026-09-29 4:25 ` [PATCH v7 24/35] drm/msm/dp: add atomic stream handling for MST Yongxing Mou
2026-09-29 4:25 ` [PATCH v7 25/35] drm/bridge_connector: suppress hotplug for IRQ_HPD without status changes Yongxing Mou
2026-09-29 4:25 ` [PATCH v7 26/35] drm/bridge_connector: avoid detect-based HPD notifications for DisplayPort Yongxing Mou
2026-09-29 4:25 ` [PATCH v7 27/35] drm/msm/dp: add HPD callback for dp MST Yongxing Mou
2026-09-29 4:25 ` [PATCH v7 28/35] drm/msm/dp: wire MST helpers into atomic check and commit paths Yongxing Mou
2026-09-29 4:25 ` [PATCH v7 29/35] drm/msm/dp: mark the SST bridge disconnected when mst is active Yongxing Mou
2026-09-29 4:25 ` [PATCH v7 30/35] drm/msm/dp: enable MST on capable sinks Yongxing Mou
2026-09-29 4:25 ` [PATCH v7 31/35] drm/msm/dp: mark the SST bridge disconnected when an MST-capable sink is present Yongxing Mou
2026-09-29 4:25 ` [PATCH v7 32/35] drm/msm/dp: mark the SST connector disconnected when MST is enabled Yongxing Mou
[not found] ` <20260929045429.A51801F00893@smtp.kernel.org>
2026-11-08 1:07 ` Joonhoe Kim
2026-09-29 4:25 ` [PATCH v7 33/35] drm/msm/dp: wake threaded handler for HPD IRQs Yongxing Mou
2026-09-29 4:25 ` [PATCH v7 34/35] drm/msm/dp: order IRQ HPD handling with plug state changes Yongxing Mou
2026-09-29 4:25 ` [PATCH v7 35/35] soc: qcom: pmic-glink-altmode: skip retimer reset on DP IRQ Yongxing Mou
2026-10-03 0:46 ` [PATCH v7 00/35] drm/msm/dp: Add MST support for MSM chipsets Dmitry Baryshkov
2026-10-27 21:04 ` Robert Meijers
2026-11-08 19:25 ` Dmitry Baryshkov
2026-11-10 4:14 ` Yongxing Mou
2026-11-10 4:14 ` Yongxing Mou
2026-11-08 1:14 ` Joonhoe Kim
2026-11-10 4:14 ` Yongxing Mou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a63614cd-93e4-4c5e-8d76-78a6b77a96f3@oss.qualcomm.com \
--to=yongxing.mou@oss.qualcomm.com \
--cc=abhinav.kumar@linux.dev \
--cc=airlied@gmail.com \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jesszhan0024@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lumag@kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=quic_abhinavk@quicinc.com \
--cc=robin.clark@oss.qualcomm.com \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®