From: Julien Panis <jpanis@baylibre.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
lee@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, corbet@lwn.net, arnd@arndb.de,
gregkh@linuxfoundation.org, derek.kiernan@xilinx.com,
dragan.cvetic@xilinx.com
Cc: eric.auger@redhat.com, jgg@ziepe.ca, razor@blackwall.org,
stephen@networkplumber.org, davem@davemloft.net,
christian.koenig@amd.com, contact@emersion.fr,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, sterzik@ti.com, u-kumar1@ti.com,
eblanc@baylibre.com, jneanne@baylibre.com
Subject: Re: [PATCH v3 1/4] dt-bindings: mfd: Add TI TPS6594 PMIC
Date: Wed, 22 Mar 2023 14:55:57 +0100 [thread overview]
Message-ID: <a63d420c-54ad-e7b0-cc10-64bb942b4e6a@baylibre.com> (raw)
In-Reply-To: <de3acab7-cf76-3135-9ff8-a0e5537a434b@linaro.org>
On 3/22/23 09:16, Krzysztof Kozlowski wrote:
> On 22/03/2023 09:01, Julien Panis wrote:
>>>> + ti,multi-phase-id:
>>>> + description: |
>>>> + Describes buck multi-phase configuration, if any. For instance, XY id means
>>>> + that outputs of buck converters X and Y are combined in multi-phase mode.
>>>> + $ref: /schemas/types.yaml#/definitions/uint32-array
>>> No improvements here. As Rob pointed out, this looks like coupled
>>> regulators.
>> I used 'oneOf' logic to handle mutual exclusion. But it seems that I did not
>> understand what you and Rob expected.
>> Does some generic property already exist for 'coupled regulators' ?
> Yes, see regulator.yaml binding.
Krzysztof, I talked with the regulator API/yaml maintainer.
Actually, our multiphase concept is different than coupled regulators:
https://lore.kernel.org/all/ZBr+7X3lcFdI8p%2Fo@sirena.org.uk/
We must not use the generic 'coupled regulator' property here.
So, 'ti,multi-phase-id' can be kept.
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2023-03-22 13:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 17:10 [PATCH v3 0/4] TI TPS6594 PMIC support (Core, ESM, PFSM) Julien Panis
2023-03-21 17:10 ` [PATCH v3 1/4] dt-bindings: mfd: Add TI TPS6594 PMIC Julien Panis
2023-03-22 7:34 ` Krzysztof Kozlowski
2023-03-22 8:01 ` Julien Panis
2023-03-22 8:16 ` Krzysztof Kozlowski
2023-03-22 13:55 ` Julien Panis [this message]
2023-03-22 21:36 ` Krzysztof Kozlowski
2023-03-21 17:10 ` [PATCH v3 2/4] mfd: tps6594: Add driver for " Julien Panis
2023-03-27 15:35 ` Julien Panis
2023-03-29 14:49 ` Lee Jones
2023-03-21 17:10 ` [PATCH v3 3/4] misc: tps6594-esm: Add driver for TI TPS6594 ESM Julien Panis
2023-03-21 17:10 ` [PATCH v3 4/4] misc: tps6594-pfsm: Add driver for TI TPS6594 PFSM Julien Panis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a63d420c-54ad-e7b0-cc10-64bb942b4e6a@baylibre.com \
--to=jpanis@baylibre.com \
--cc=arnd@arndb.de \
--cc=christian.koenig@amd.com \
--cc=contact@emersion.fr \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=derek.kiernan@xilinx.com \
--cc=devicetree@vger.kernel.org \
--cc=dragan.cvetic@xilinx.com \
--cc=eblanc@baylibre.com \
--cc=eric.auger@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jgg@ziepe.ca \
--cc=jneanne@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lee@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=razor@blackwall.org \
--cc=robh+dt@kernel.org \
--cc=stephen@networkplumber.org \
--cc=sterzik@ti.com \
--cc=u-kumar1@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®