Re: [PATCH] hwmon: (k10temp) Add thermal support for AMD Family 1Ah-based models

["Naik, Avadhut" <avadnaik@amd.com>]

On 7/24/2025 10:44, Bjorn Helgaas wrote:
> On Wed, Jul 23, 2025 at 08:23:38PM +0000, Avadhut Naik wrote:
>> Add thermal info support for newer AMD Family 1Ah-based models.
>>
>> Signed-off-by: Avadhut Naik <avadhut.naik@amd.com>
>> ---
>>  drivers/hwmon/k10temp.c | 2 ++
>>  include/linux/pci_ids.h | 2 ++
>>  2 files changed, 4 insertions(+)
>>
>> diff --git a/drivers/hwmon/k10temp.c b/drivers/hwmon/k10temp.c
>> index babf2413d666..7765cd57d746 100644
>> --- a/drivers/hwmon/k10temp.c
>> +++ b/drivers/hwmon/k10temp.c
>> @@ -556,7 +556,9 @@ static const struct pci_device_id k10temp_id_table[] = {
>>  	{ PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_19H_M78H_DF_F3) },
>>  	{ PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_1AH_M00H_DF_F3) },
>>  	{ PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_1AH_M20H_DF_F3) },
>> +	{ PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_1AH_M50H_DF_F3) },
>>  	{ PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_1AH_M60H_DF_F3) },
>> +	{ PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_1AH_M90H_DF_F3) },
>>  	{ PCI_VDEVICE(HYGON, PCI_DEVICE_ID_AMD_17H_DF_F3) },
>>  	{}
>>  };
>> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
>> index e2d71b6fdd84..ae87b6c72981 100644
>> --- a/include/linux/pci_ids.h
>> +++ b/include/linux/pci_ids.h
>> @@ -583,8 +583,10 @@
>>  #define PCI_DEVICE_ID_AMD_19H_M78H_DF_F3 0x12fb
>>  #define PCI_DEVICE_ID_AMD_1AH_M00H_DF_F3 0x12c3
>>  #define PCI_DEVICE_ID_AMD_1AH_M20H_DF_F3 0x16fb
>> +#define PCI_DEVICE_ID_AMD_1AH_M50H_DF_F3 0x12cb
>>  #define PCI_DEVICE_ID_AMD_1AH_M60H_DF_F3 0x124b
>>  #define PCI_DEVICE_ID_AMD_1AH_M70H_DF_F3 0x12bb
>> +#define PCI_DEVICE_ID_AMD_1AH_M90H_DF_F3 0x127b
> 
> Per the comment at top:
> 
>  *      Do not add new entries to this file unless the definitions
>  *      are shared between multiple drivers.
> 
> I would suggest adding these #defines to k10temp.c itself.
> 
Okay. Will move these definitions to k10temp.c

>>  #define PCI_DEVICE_ID_AMD_MI200_DF_F3	0x14d3
>>  #define PCI_DEVICE_ID_AMD_MI300_DF_F3	0x152b
>>  #define PCI_DEVICE_ID_AMD_VANGOGH_USB	0x163a
>>
>> base-commit: a2609b707b58561b9e52f92f3f571d0510201f2f
>> -- 
>> 2.43.0
>>

-- 
Thanks,
Avadhut Naik