* [PATCH] hwmon: (k10temp) Add thermal support for AMD Family 1Ah-based models
@ 2025-07-23 20:23 Avadhut Naik
2025-07-23 22:26 ` Guenter Roeck
2025-07-24 15:44 ` Bjorn Helgaas
0 siblings, 2 replies; 4+ messages in thread
From: Avadhut Naik @ 2025-07-23 20:23 UTC (permalink / raw)
To: linux-hwmon; +Cc: linux, jdelvare, yazen.ghannam, linux-kernel, avadhut.naik
Add thermal info support for newer AMD Family 1Ah-based models.
Signed-off-by: Avadhut Naik <avadhut.naik@amd.com>
---
drivers/hwmon/k10temp.c | 2 ++
include/linux/pci_ids.h | 2 ++
2 files changed, 4 insertions(+)
diff --git a/drivers/hwmon/k10temp.c b/drivers/hwmon/k10temp.c
index babf2413d666..7765cd57d746 100644
--- a/drivers/hwmon/k10temp.c
+++ b/drivers/hwmon/k10temp.c
@@ -556,7 +556,9 @@ static const struct pci_device_id k10temp_id_table[] = {
{ PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_19H_M78H_DF_F3) },
{ PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_1AH_M00H_DF_F3) },
{ PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_1AH_M20H_DF_F3) },
+ { PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_1AH_M50H_DF_F3) },
{ PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_1AH_M60H_DF_F3) },
+ { PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_1AH_M90H_DF_F3) },
{ PCI_VDEVICE(HYGON, PCI_DEVICE_ID_AMD_17H_DF_F3) },
{}
};
diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
index e2d71b6fdd84..ae87b6c72981 100644
--- a/include/linux/pci_ids.h
+++ b/include/linux/pci_ids.h
@@ -583,8 +583,10 @@
#define PCI_DEVICE_ID_AMD_19H_M78H_DF_F3 0x12fb
#define PCI_DEVICE_ID_AMD_1AH_M00H_DF_F3 0x12c3
#define PCI_DEVICE_ID_AMD_1AH_M20H_DF_F3 0x16fb
+#define PCI_DEVICE_ID_AMD_1AH_M50H_DF_F3 0x12cb
#define PCI_DEVICE_ID_AMD_1AH_M60H_DF_F3 0x124b
#define PCI_DEVICE_ID_AMD_1AH_M70H_DF_F3 0x12bb
+#define PCI_DEVICE_ID_AMD_1AH_M90H_DF_F3 0x127b
#define PCI_DEVICE_ID_AMD_MI200_DF_F3 0x14d3
#define PCI_DEVICE_ID_AMD_MI300_DF_F3 0x152b
#define PCI_DEVICE_ID_AMD_VANGOGH_USB 0x163a
base-commit: a2609b707b58561b9e52f92f3f571d0510201f2f
--
2.43.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] hwmon: (k10temp) Add thermal support for AMD Family 1Ah-based models
2025-07-23 20:23 [PATCH] hwmon: (k10temp) Add thermal support for AMD Family 1Ah-based models Avadhut Naik
@ 2025-07-23 22:26 ` Guenter Roeck
2025-07-24 15:44 ` Bjorn Helgaas
1 sibling, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2025-07-23 22:26 UTC (permalink / raw)
To: Avadhut Naik, linux-hwmon
Cc: jdelvare, yazen.ghannam, linux-kernel, Bjorn Helgaas, linux-pci
On 7/23/25 13:23, Avadhut Naik wrote:
> Add thermal info support for newer AMD Family 1Ah-based models.
>
> Signed-off-by: Avadhut Naik <avadhut.naik@amd.com>
> ---
> drivers/hwmon/k10temp.c | 2 ++
> include/linux/pci_ids.h | 2 ++
I can't touch that file without approval from pci maintainers (copied).
Guenter
> 2 files changed, 4 insertions(+)
>
> diff --git a/drivers/hwmon/k10temp.c b/drivers/hwmon/k10temp.c
> index babf2413d666..7765cd57d746 100644
> --- a/drivers/hwmon/k10temp.c
> +++ b/drivers/hwmon/k10temp.c
> @@ -556,7 +556,9 @@ static const struct pci_device_id k10temp_id_table[] = {
> { PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_19H_M78H_DF_F3) },
> { PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_1AH_M00H_DF_F3) },
> { PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_1AH_M20H_DF_F3) },
> + { PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_1AH_M50H_DF_F3) },
> { PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_1AH_M60H_DF_F3) },
> + { PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_1AH_M90H_DF_F3) },
> { PCI_VDEVICE(HYGON, PCI_DEVICE_ID_AMD_17H_DF_F3) },
> {}
> };
> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> index e2d71b6fdd84..ae87b6c72981 100644
> --- a/include/linux/pci_ids.h
> +++ b/include/linux/pci_ids.h
> @@ -583,8 +583,10 @@
> #define PCI_DEVICE_ID_AMD_19H_M78H_DF_F3 0x12fb
> #define PCI_DEVICE_ID_AMD_1AH_M00H_DF_F3 0x12c3
> #define PCI_DEVICE_ID_AMD_1AH_M20H_DF_F3 0x16fb
> +#define PCI_DEVICE_ID_AMD_1AH_M50H_DF_F3 0x12cb
> #define PCI_DEVICE_ID_AMD_1AH_M60H_DF_F3 0x124b
> #define PCI_DEVICE_ID_AMD_1AH_M70H_DF_F3 0x12bb
> +#define PCI_DEVICE_ID_AMD_1AH_M90H_DF_F3 0x127b
> #define PCI_DEVICE_ID_AMD_MI200_DF_F3 0x14d3
> #define PCI_DEVICE_ID_AMD_MI300_DF_F3 0x152b
> #define PCI_DEVICE_ID_AMD_VANGOGH_USB 0x163a
>
> base-commit: a2609b707b58561b9e52f92f3f571d0510201f2f
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] hwmon: (k10temp) Add thermal support for AMD Family 1Ah-based models
2025-07-23 20:23 [PATCH] hwmon: (k10temp) Add thermal support for AMD Family 1Ah-based models Avadhut Naik
2025-07-23 22:26 ` Guenter Roeck
@ 2025-07-24 15:44 ` Bjorn Helgaas
2025-07-24 18:39 ` Naik, Avadhut
1 sibling, 1 reply; 4+ messages in thread
From: Bjorn Helgaas @ 2025-07-24 15:44 UTC (permalink / raw)
To: Avadhut Naik; +Cc: linux-hwmon, linux, jdelvare, yazen.ghannam, linux-kernel
On Wed, Jul 23, 2025 at 08:23:38PM +0000, Avadhut Naik wrote:
> Add thermal info support for newer AMD Family 1Ah-based models.
>
> Signed-off-by: Avadhut Naik <avadhut.naik@amd.com>
> ---
> drivers/hwmon/k10temp.c | 2 ++
> include/linux/pci_ids.h | 2 ++
> 2 files changed, 4 insertions(+)
>
> diff --git a/drivers/hwmon/k10temp.c b/drivers/hwmon/k10temp.c
> index babf2413d666..7765cd57d746 100644
> --- a/drivers/hwmon/k10temp.c
> +++ b/drivers/hwmon/k10temp.c
> @@ -556,7 +556,9 @@ static const struct pci_device_id k10temp_id_table[] = {
> { PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_19H_M78H_DF_F3) },
> { PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_1AH_M00H_DF_F3) },
> { PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_1AH_M20H_DF_F3) },
> + { PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_1AH_M50H_DF_F3) },
> { PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_1AH_M60H_DF_F3) },
> + { PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_1AH_M90H_DF_F3) },
> { PCI_VDEVICE(HYGON, PCI_DEVICE_ID_AMD_17H_DF_F3) },
> {}
> };
> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> index e2d71b6fdd84..ae87b6c72981 100644
> --- a/include/linux/pci_ids.h
> +++ b/include/linux/pci_ids.h
> @@ -583,8 +583,10 @@
> #define PCI_DEVICE_ID_AMD_19H_M78H_DF_F3 0x12fb
> #define PCI_DEVICE_ID_AMD_1AH_M00H_DF_F3 0x12c3
> #define PCI_DEVICE_ID_AMD_1AH_M20H_DF_F3 0x16fb
> +#define PCI_DEVICE_ID_AMD_1AH_M50H_DF_F3 0x12cb
> #define PCI_DEVICE_ID_AMD_1AH_M60H_DF_F3 0x124b
> #define PCI_DEVICE_ID_AMD_1AH_M70H_DF_F3 0x12bb
> +#define PCI_DEVICE_ID_AMD_1AH_M90H_DF_F3 0x127b
Per the comment at top:
* Do not add new entries to this file unless the definitions
* are shared between multiple drivers.
I would suggest adding these #defines to k10temp.c itself.
> #define PCI_DEVICE_ID_AMD_MI200_DF_F3 0x14d3
> #define PCI_DEVICE_ID_AMD_MI300_DF_F3 0x152b
> #define PCI_DEVICE_ID_AMD_VANGOGH_USB 0x163a
>
> base-commit: a2609b707b58561b9e52f92f3f571d0510201f2f
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] hwmon: (k10temp) Add thermal support for AMD Family 1Ah-based models
2025-07-24 15:44 ` Bjorn Helgaas
@ 2025-07-24 18:39 ` Naik, Avadhut
0 siblings, 0 replies; 4+ messages in thread
From: Naik, Avadhut @ 2025-07-24 18:39 UTC (permalink / raw)
To: Bjorn Helgaas, Avadhut Naik
Cc: linux-hwmon, linux, jdelvare, yazen.ghannam, linux-kernel
On 7/24/2025 10:44, Bjorn Helgaas wrote:
> On Wed, Jul 23, 2025 at 08:23:38PM +0000, Avadhut Naik wrote:
>> Add thermal info support for newer AMD Family 1Ah-based models.
>>
>> Signed-off-by: Avadhut Naik <avadhut.naik@amd.com>
>> ---
>> drivers/hwmon/k10temp.c | 2 ++
>> include/linux/pci_ids.h | 2 ++
>> 2 files changed, 4 insertions(+)
>>
>> diff --git a/drivers/hwmon/k10temp.c b/drivers/hwmon/k10temp.c
>> index babf2413d666..7765cd57d746 100644
>> --- a/drivers/hwmon/k10temp.c
>> +++ b/drivers/hwmon/k10temp.c
>> @@ -556,7 +556,9 @@ static const struct pci_device_id k10temp_id_table[] = {
>> { PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_19H_M78H_DF_F3) },
>> { PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_1AH_M00H_DF_F3) },
>> { PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_1AH_M20H_DF_F3) },
>> + { PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_1AH_M50H_DF_F3) },
>> { PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_1AH_M60H_DF_F3) },
>> + { PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_1AH_M90H_DF_F3) },
>> { PCI_VDEVICE(HYGON, PCI_DEVICE_ID_AMD_17H_DF_F3) },
>> {}
>> };
>> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
>> index e2d71b6fdd84..ae87b6c72981 100644
>> --- a/include/linux/pci_ids.h
>> +++ b/include/linux/pci_ids.h
>> @@ -583,8 +583,10 @@
>> #define PCI_DEVICE_ID_AMD_19H_M78H_DF_F3 0x12fb
>> #define PCI_DEVICE_ID_AMD_1AH_M00H_DF_F3 0x12c3
>> #define PCI_DEVICE_ID_AMD_1AH_M20H_DF_F3 0x16fb
>> +#define PCI_DEVICE_ID_AMD_1AH_M50H_DF_F3 0x12cb
>> #define PCI_DEVICE_ID_AMD_1AH_M60H_DF_F3 0x124b
>> #define PCI_DEVICE_ID_AMD_1AH_M70H_DF_F3 0x12bb
>> +#define PCI_DEVICE_ID_AMD_1AH_M90H_DF_F3 0x127b
>
> Per the comment at top:
>
> * Do not add new entries to this file unless the definitions
> * are shared between multiple drivers.
>
> I would suggest adding these #defines to k10temp.c itself.
>
Okay. Will move these definitions to k10temp.c
>> #define PCI_DEVICE_ID_AMD_MI200_DF_F3 0x14d3
>> #define PCI_DEVICE_ID_AMD_MI300_DF_F3 0x152b
>> #define PCI_DEVICE_ID_AMD_VANGOGH_USB 0x163a
>>
>> base-commit: a2609b707b58561b9e52f92f3f571d0510201f2f
>> --
>> 2.43.0
>>
--
Thanks,
Avadhut Naik
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-07-24 18:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-07-23 20:23 [PATCH] hwmon: (k10temp) Add thermal support for AMD Family 1Ah-based models Avadhut Naik
2025-07-23 22:26 ` Guenter Roeck
2025-07-24 15:44 ` Bjorn Helgaas
2025-07-24 18:39 ` Naik, Avadhut
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®