mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jeremy Kerr <jk@ozlabs.org>
To: Joel Stanley <joel@jms.id.au>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Christopher Bostic <cbostic@linux.vnet.ibm.com>
Subject: Re: [PATCH 3/3] fsi/master-gpio: Add external mode
Date: Thu, 22 Jun 2017 06:07:00 +0800	[thread overview]
Message-ID: <a6a9f730-4e1a-6f57-7844-d2fe4dc03dc9@ozlabs.org> (raw)
In-Reply-To: <CACPK8XcVH19nYRP85T6rX1D3jd+1C4kr09DW3W_9kf1DJjj49Q@mail.gmail.com>

Hi Joel,

>> +static ssize_t external_mode_show(struct device *dev,
>> +               struct device_attribute *attr, char *buf)
>> +{
>> +       struct fsi_master_gpio *master = dev_get_drvdata(dev);
>> +
>> +       return snprintf(buf, PAGE_SIZE - 1, "%u",
> 
> I gave this a spin on a machine today and noticed we're missing a
> newline there. Should this be "%u\n"?

Yep, that'd make things easier to read. v2 coming.

Cheers,


Jeremy

  reply	other threads:[~2017-06-21 22:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-19  9:26 [PATCH 0/3] Add 'external mode' for GPIO-based FSI master Jeremy Kerr
2017-06-19  9:26 ` [PATCH 1/3] fsi: Add fsi_master_rescan() Jeremy Kerr
2017-06-20  2:59   ` [PATCH v2 " Jeremy Kerr
2017-06-19  9:26 ` [PATCH 2/3] fsi/master-gpio: Add locking around gpio operations during break & link enable Jeremy Kerr
2017-06-19  9:26 ` [PATCH 3/3] fsi/master-gpio: Add external mode Jeremy Kerr
2017-06-19 17:17   ` kbuild test robot
2017-06-21  6:01   ` Joel Stanley
2017-06-21 22:07     ` Jeremy Kerr [this message]
2017-06-21 22:10   ` [PATCH v2 " Jeremy Kerr
2018-01-30  4:45     ` Joel Stanley
2017-09-04  6:55 ` [PATCH 0/3] Add 'external mode' for GPIO-based FSI master Joel Stanley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a6a9f730-4e1a-6f57-7844-d2fe4dc03dc9@ozlabs.org \
    --to=jk@ozlabs.org \
    --cc=cbostic@linux.vnet.ibm.com \
    --cc=joel@jms.id.au \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®