[PATCH] sched/eevdf: Fix augmented max_slice

[PATCH] sched/eevdf: Fix augmented max_slice

[Vincent Guittot]

Similarly to se->min_slice, init se->max_slice with se->slice before
enqueueing the entity so the augmented callback computes it correctly
at parent level.

Fixes: 6e3c0a4e1ad1 ("sched/fair: Fix lag clamp")
Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
---
 kernel/sched/fair.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index b8bd308c2d5b..5d819918e870 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -1073,6 +1073,8 @@ static void __enqueue_entity(struct cfs_rq *cfs_rq, struct sched_entity *se)
 	sum_w_vruntime_add(cfs_rq, se);
 	se->min_vruntime = se->vruntime;
 	se->min_slice = se->slice;
+	se->max_slice = se->slice;
+
 	rb_add_augmented_cached(&se->run_node, &cfs_rq->tasks_timeline,
 				__entity_less, &min_vruntime_cb);
 }
-- 
2.53.0

Re: [PATCH] sched/eevdf: Fix augmented max_slice

[K Prateek Nayak]

Hello Vincent,

On 9/7/2026 6:08 PM, Vincent Guittot wrote:
> Similarly to se->min_slice, init se->max_slice with se->slice before
> enqueueing the entity so the augmented callback computes it correctly
> at parent level.
> 
> Fixes: 6e3c0a4e1ad1 ("sched/fair: Fix lag clamp")
> Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>

Feel free to include:

Reviewed-by: K Prateek Nayak <kprateek.nayak@amd.com>

> ---
>  kernel/sched/fair.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index b8bd308c2d5b..5d819918e870 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -1073,6 +1073,8 @@ static void __enqueue_entity(struct cfs_rq *cfs_rq, struct sched_entity *se)
>  	sum_w_vruntime_add(cfs_rq, se);
>  	se->min_vruntime = se->vruntime;
>  	se->min_slice = se->slice;
> +	se->max_slice = se->slice;
> +
>  	rb_add_augmented_cached(&se->run_node, &cfs_rq->tasks_timeline,
>  				__entity_less, &min_vruntime_cb);
>  }

-- 
Thanks and Regards,
Prateek

[tip: sched/urgent] sched/eevdf: Fix augmented max_slice

[tip-bot2 for Vincent Guittot]

The following commit has been merged into the sched/urgent branch of tip:

Commit-ID:     9a8bc9bb4c3fb3218b4f151f98a722fbeb5b5c34
Gitweb:        https://git.kernel.org/tip/9a8bc9bb4c3fb3218b4f151f98a722fbeb5b5c34
Author:        Vincent Guittot <vincent.guittot@linaro.org>
AuthorDate:    Mon, 07 Sep 2026 14:38:55 +02:00
Committer:     Peter Zijlstra <peterz@infradead.org>
CommitterDate: Thu, 10 Sep 2026 10:22:51 +02:00

sched/eevdf: Fix augmented max_slice

Similarly to se->min_slice, init se->max_slice with se->slice before
enqueueing the entity so the augmented callback computes it correctly
at parent level.

Fixes: 6e3c0a4e1ad1 ("sched/fair: Fix lag clamp")
Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: K Prateek Nayak <kprateek.nayak@amd.com>
Link: https://patch.msgid.link/20260907123855.1297976-1-vincent.guittot@linaro.org
---
 kernel/sched/fair.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index ade1ece..5b944f9 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -1073,6 +1073,8 @@ static void __enqueue_entity(struct cfs_rq *cfs_rq, struct sched_entity *se)
 	sum_w_vruntime_add(cfs_rq, se);
 	se->min_vruntime = se->vruntime;
 	se->min_slice = se->slice;
+	se->max_slice = se->slice;
+
 	rb_add_augmented_cached(&se->run_node, &cfs_rq->tasks_timeline,
 				__entity_less, &min_vruntime_cb);
 }