mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chanwoo Choi <chanwoo@kernel.org>
To: hanyu001@208suo.com, myungjoo.ham@samsung.com, cw00.choi@samsung.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: extcon: space required after that ','
Date: Sun, 23 Jul 2023 22:54:07 +0900	[thread overview]
Message-ID: <a75290b3-a224-b431-971f-1240e09b52e4@kernel.org> (raw)
In-Reply-To: <25d422c1ac26f0c59ef10a8a2afe057b@208suo.com>

Hi,

On 23. 7. 17. 18:03, hanyu001@208suo.com wrote:
> This patch fixes the checkpatch.pl error:
> 
> ./drivers/extcon/extcon.c:321: ERROR: space required after that ',' (ctx:VxV)
> 
> Signed-off-by: maqimei <2433033762@qq.com>

'maqimei' is your name? 

I recommend that you can check the guide of 'submitting-patches'[1].
[1] https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html

Please update your name.

> ---
>  drivers/extcon/extcon.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c
> index 6f7a60d..4ef4422 100644
> --- a/drivers/extcon/extcon.c
> +++ b/drivers/extcon/extcon.c
> @@ -318,7 +318,7 @@ static bool is_extcon_property_supported(unsigned int id, unsigned int prop)
>  }
> 
>  static int is_extcon_property_capability(struct extcon_dev *edev,
> -                unsigned int id, int index,unsigned int prop)
> +                unsigned int id, int index, unsigned int prop)
>  {
>      struct extcon_cable *cable;
>      int type, ret;

-- 
Best Regards,
Samsung Electronics
Chanwoo Choi


  reply	other threads:[~2023-07-23 13:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <tencent_5D4E47E7BC2D92FC229E6245684D90B2ED06@qq.com>
2023-07-17  9:03 ` hanyu001
2023-07-23 13:54   ` Chanwoo Choi [this message]
     [not found] ` <CGME20230717090324epcas1p3f78e1005a9775015c1b561b446df9cd5@epcms1p3>
2023-07-17 10:22   ` MyungJoo Ham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a75290b3-a224-b431-971f-1240e09b52e4@kernel.org \
    --to=chanwoo@kernel.org \
    --cc=cw00.choi@samsung.com \
    --cc=hanyu001@208suo.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=myungjoo.ham@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®