* [PATCH] drivers: extcon: space required after that ',' [not found] <tencent_5D4E47E7BC2D92FC229E6245684D90B2ED06@qq.com> @ 2023-07-17 9:03 ` hanyu001 2023-07-23 13:54 ` Chanwoo Choi [not found] ` <CGME20230717090324epcas1p3f78e1005a9775015c1b561b446df9cd5@epcms1p3> 1 sibling, 1 reply; 3+ messages in thread From: hanyu001 @ 2023-07-17 9:03 UTC (permalink / raw) To: myungjoo.ham, cw00.choi; +Cc: linux-kernel This patch fixes the checkpatch.pl error: ./drivers/extcon/extcon.c:321: ERROR: space required after that ',' (ctx:VxV) Signed-off-by: maqimei <2433033762@qq.com> --- drivers/extcon/extcon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c index 6f7a60d..4ef4422 100644 --- a/drivers/extcon/extcon.c +++ b/drivers/extcon/extcon.c @@ -318,7 +318,7 @@ static bool is_extcon_property_supported(unsigned int id, unsigned int prop) } static int is_extcon_property_capability(struct extcon_dev *edev, - unsigned int id, int index,unsigned int prop) + unsigned int id, int index, unsigned int prop) { struct extcon_cable *cable; int type, ret; ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers: extcon: space required after that ',' 2023-07-17 9:03 ` [PATCH] drivers: extcon: space required after that ',' hanyu001 @ 2023-07-23 13:54 ` Chanwoo Choi 0 siblings, 0 replies; 3+ messages in thread From: Chanwoo Choi @ 2023-07-23 13:54 UTC (permalink / raw) To: hanyu001, myungjoo.ham, cw00.choi; +Cc: linux-kernel Hi, On 23. 7. 17. 18:03, hanyu001@208suo.com wrote: > This patch fixes the checkpatch.pl error: > > ./drivers/extcon/extcon.c:321: ERROR: space required after that ',' (ctx:VxV) > > Signed-off-by: maqimei <2433033762@qq.com> 'maqimei' is your name? I recommend that you can check the guide of 'submitting-patches'[1]. [1] https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html Please update your name. > --- > drivers/extcon/extcon.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c > index 6f7a60d..4ef4422 100644 > --- a/drivers/extcon/extcon.c > +++ b/drivers/extcon/extcon.c > @@ -318,7 +318,7 @@ static bool is_extcon_property_supported(unsigned int id, unsigned int prop) > } > > static int is_extcon_property_capability(struct extcon_dev *edev, > - unsigned int id, int index,unsigned int prop) > + unsigned int id, int index, unsigned int prop) > { > struct extcon_cable *cable; > int type, ret; -- Best Regards, Samsung Electronics Chanwoo Choi ^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <CGME20230717090324epcas1p3f78e1005a9775015c1b561b446df9cd5@epcms1p3>]
* RE: [PATCH] drivers: extcon: space required after that ',' [not found] ` <CGME20230717090324epcas1p3f78e1005a9775015c1b561b446df9cd5@epcms1p3> @ 2023-07-17 10:22 ` MyungJoo Ham 0 siblings, 0 replies; 3+ messages in thread From: MyungJoo Ham @ 2023-07-17 10:22 UTC (permalink / raw) To: hanyu001, Chanwoo Choi; +Cc: linux-kernel >This patch fixes the checkpatch.pl error: > >./drivers/extcon/extcon.c:321: ERROR: space required after that ',' >(ctx:VxV) > >Signed-off-by: maqimei <2433033762@qq.com> Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com> @Chanwoo, it looks like that's from a 7 years old commit of yours :). >--- > drivers/extcon/extcon.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c >index 6f7a60d..4ef4422 100644 >--- a/drivers/extcon/extcon.c >+++ b/drivers/extcon/extcon.c >@@ -318,7 +318,7 @@ static bool is_extcon_property_supported(unsigned >int id, unsigned int prop) > } > > static int is_extcon_property_capability(struct extcon_dev *edev, >- unsigned int id, int index,unsigned int prop) >+ unsigned int id, int index, unsigned int prop) > { > struct extcon_cable *cable; > int type, ret; ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-23 13:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <tencent_5D4E47E7BC2D92FC229E6245684D90B2ED06@qq.com>
2023-07-17 9:03 ` [PATCH] drivers: extcon: space required after that ',' hanyu001
2023-07-23 13:54 ` Chanwoo Choi
[not found] ` <CGME20230717090324epcas1p3f78e1005a9775015c1b561b446df9cd5@epcms1p3>
2023-07-17 10:22 ` MyungJoo Ham
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®