mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Satyam Sharma" <satyam.sharma@gmail.com>
To: "Matthias Kaehlcke" <matthias.kaehlcke@gmail.com>,
	chas@cmf.nrl.navy.mil, ecd@atecom.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] use spinlock instead of binary mutex in idt77252 driver
Date: Mon, 23 Apr 2007 05:22:10 +0530	[thread overview]
Message-ID: <a781481a0704221652h51a73c21t4ae5ff66760ccee3@mail.gmail.com> (raw)
In-Reply-To: <20070422213959.GP5013@traven>

On 4/23/07, Matthias Kaehlcke <matthias.kaehlcke@gmail.com> wrote:
> use spinlock instead of binary mutex in idt77252 driver
>
> Signed-off-by: Matthias Kaehlcke <matthias.kaehlcke@gmail.com>
>
> --
>
> diff --git a/drivers/atm/idt77252.c b/drivers/atm/idt77252.c
> index b4b8014..e3cf141 100644
> --- a/drivers/atm/idt77252.c
> +++ b/drivers/atm/idt77252.c
> @@ -2430,7 +2430,7 @@ idt77252_open(struct atm_vcc *vcc)
>
>         set_bit(ATM_VF_ADDR, &vcc->flags);
>
> -       down(&card->mutex);
> +       mutex_lock(&card->mutex);

Note that you're actually replacing a semaphore with a mutex here (and
not a mutex with a spinlock). I guess that should be fine and
desirable as long as the semaphore was indeed being used a mutex
(binary) in this code.

      parent reply	other threads:[~2007-04-22 23:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-22 21:39 Matthias Kaehlcke
2007-04-22 23:50 ` Kyle Moffett
2007-04-23  6:55   ` Matthias Kaehlcke
2007-04-23  7:16     ` Eddie C. Dost
2007-04-23  7:40       ` Matthias Kaehlcke
2007-04-23  7:40         ` Eddie C. Dost
2007-04-23  7:57           ` Matthias Kaehlcke
2007-04-23  8:02           ` Satyam Sharma
2007-04-23  8:17   ` Christoph Hellwig
2007-04-23  8:35     ` Matthias Kaehlcke
2007-04-22 23:52 ` Satyam Sharma [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a781481a0704221652h51a73c21t4ae5ff66760ccee3@mail.gmail.com \
    --to=satyam.sharma@gmail.com \
    --cc=chas@cmf.nrl.navy.mil \
    --cc=ecd@atecom.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthias.kaehlcke@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®