Re: [PATCH] drm/rockchip: vop2: give rk3576 VP2 a primary plane

[Chaoyi Chen <chaoyi.chen@rock-chips.com>]

On 7/30/2026 11:39 AM, Tomonori Nakagawa wrote:
> On 2026/07/30 10:56, Chaoyi Chen wrote:
>> The description here is not accurate. VP2 can wire to different
>> display interfaces which depending on your board configuration.
> 
> You're right, thanks. VP2 isn't tied to DP - the VP-to-interface
> routing is board/DT dependent. The actual issue is the plane topology:
> on rk3576 the two Cluster windows (the only DRM_PLANE_TYPE_PRIMARY
> windows) both have possible_vp_mask = BIT(0) | BIT(1), so they can only
> attach to VP0/VP1. VP2's only attachable windows are the Esmart ones,
> which are all DRM_PLANE_TYPE_OVERLAY. So whenever a board's DT wires any
> output to video_port2, vop2_create_crtcs() finds no primary plane for it
> and fails with -ENOENT ("no primary plane for vp 2").
> 
> I'll reword the commit message accordingly (dropping the DP framing) in
> a v2. Does the fix itself - promoting Esmart0 to PRIMARY - look
> acceptable, or would you prefer a different window or a driver-side
> approach for VP2's primary?
> 
> 
> 

No, it looks good to me. Let's see if anyone else has any opinions.

-- 
Best, 
Chaoyi