* [PATCH] fs: nfs: add missing MODULE_DESCRIPTION() macros
@ 2024-05-27 17:58 Jeff Johnson
2024-06-20 16:17 ` Jeff Johnson
2024-06-20 16:33 ` Jeff Layton
0 siblings, 2 replies; 4+ messages in thread
From: Jeff Johnson @ 2024-05-27 17:58 UTC (permalink / raw)
To: Trond Myklebust, Anna Schumaker, Chuck Lever, Jeff Layton,
Neil Brown, Olga Kornievskaia, Dai Ngo, Tom Talpey
Cc: linux-nfs, linux-kernel, kernel-janitors, Jeff Johnson
Fix the 'make W=1' warnings:
WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nfs_common/nfs_acl.o
WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nfs_common/grace.o
WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nfs/nfs.o
WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nfs/nfsv2.o
WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nfs/nfsv3.o
WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nfs/nfsv4.o
Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
fs/nfs/inode.c | 1 +
fs/nfs/nfs2super.c | 1 +
fs/nfs/nfs3super.c | 1 +
fs/nfs/nfs4super.c | 1 +
fs/nfs_common/grace.c | 1 +
fs/nfs_common/nfsacl.c | 1 +
6 files changed, 6 insertions(+)
diff --git a/fs/nfs/inode.c b/fs/nfs/inode.c
index acef52ecb1bb..57c473e9d00f 100644
--- a/fs/nfs/inode.c
+++ b/fs/nfs/inode.c
@@ -2538,6 +2538,7 @@ static void __exit exit_nfs_fs(void)
/* Not quite true; I just maintain it */
MODULE_AUTHOR("Olaf Kirch <okir@monad.swb.de>");
+MODULE_DESCRIPTION("NFS client support");
MODULE_LICENSE("GPL");
module_param(enable_ino64, bool, 0644);
diff --git a/fs/nfs/nfs2super.c b/fs/nfs/nfs2super.c
index 467f21ee6a35..b1badc70bd71 100644
--- a/fs/nfs/nfs2super.c
+++ b/fs/nfs/nfs2super.c
@@ -26,6 +26,7 @@ static void __exit exit_nfs_v2(void)
unregister_nfs_version(&nfs_v2);
}
+MODULE_DESCRIPTION("NFSv2 client support");
MODULE_LICENSE("GPL");
module_init(init_nfs_v2);
diff --git a/fs/nfs/nfs3super.c b/fs/nfs/nfs3super.c
index 8a9be9e47f76..20a80478449e 100644
--- a/fs/nfs/nfs3super.c
+++ b/fs/nfs/nfs3super.c
@@ -27,6 +27,7 @@ static void __exit exit_nfs_v3(void)
unregister_nfs_version(&nfs_v3);
}
+MODULE_DESCRIPTION("NFSv3 client support");
MODULE_LICENSE("GPL");
module_init(init_nfs_v3);
diff --git a/fs/nfs/nfs4super.c b/fs/nfs/nfs4super.c
index 8da5a9c000f4..b29a26923ce0 100644
--- a/fs/nfs/nfs4super.c
+++ b/fs/nfs/nfs4super.c
@@ -332,6 +332,7 @@ static void __exit exit_nfs_v4(void)
nfs_dns_resolver_destroy();
}
+MODULE_DESCRIPTION("NFSv4 client support");
MODULE_LICENSE("GPL");
module_init(init_nfs_v4);
diff --git a/fs/nfs_common/grace.c b/fs/nfs_common/grace.c
index 1479583fbb62..8f034aa8c88b 100644
--- a/fs/nfs_common/grace.c
+++ b/fs/nfs_common/grace.c
@@ -139,6 +139,7 @@ exit_grace(void)
}
MODULE_AUTHOR("Jeff Layton <jlayton@primarydata.com>");
+MODULE_DESCRIPTION("lockd and nfsv4 grace period control");
MODULE_LICENSE("GPL");
module_init(init_grace)
module_exit(exit_grace)
diff --git a/fs/nfs_common/nfsacl.c b/fs/nfs_common/nfsacl.c
index 5a5bd85d08f8..ea382b75b26c 100644
--- a/fs/nfs_common/nfsacl.c
+++ b/fs/nfs_common/nfsacl.c
@@ -29,6 +29,7 @@
#include <linux/nfs3.h>
#include <linux/sort.h>
+MODULE_DESCRIPTION("NFS ACL support");
MODULE_LICENSE("GPL");
struct nfsacl_encode_desc {
---
base-commit: 2bfcfd584ff5ccc8bb7acde19b42570414bf880b
change-id: 20240527-md-fs-nfs-42f19eb60b50
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] fs: nfs: add missing MODULE_DESCRIPTION() macros
2024-05-27 17:58 [PATCH] fs: nfs: add missing MODULE_DESCRIPTION() macros Jeff Johnson
@ 2024-06-20 16:17 ` Jeff Johnson
2024-06-20 16:33 ` Jeff Layton
1 sibling, 0 replies; 4+ messages in thread
From: Jeff Johnson @ 2024-06-20 16:17 UTC (permalink / raw)
To: Trond Myklebust, Anna Schumaker, Chuck Lever, Jeff Layton,
Neil Brown, Olga Kornievskaia, Dai Ngo, Tom Talpey,
Christian Brauner, Alexander Viro,,
Jan Kara
Cc: linux-nfs, linux-kernel, kernel-janitors
On 5/27/24 10:58, Jeff Johnson wrote:
> Fix the 'make W=1' warnings:
> WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nfs_common/nfs_acl.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nfs_common/grace.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nfs/nfs.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nfs/nfsv2.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nfs/nfsv3.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nfs/nfsv4.o
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
> fs/nfs/inode.c | 1 +
> fs/nfs/nfs2super.c | 1 +
> fs/nfs/nfs3super.c | 1 +
> fs/nfs/nfs4super.c | 1 +
> fs/nfs_common/grace.c | 1 +
> fs/nfs_common/nfsacl.c | 1 +
> 6 files changed, 6 insertions(+)
>
> diff --git a/fs/nfs/inode.c b/fs/nfs/inode.c
> index acef52ecb1bb..57c473e9d00f 100644
> --- a/fs/nfs/inode.c
> +++ b/fs/nfs/inode.c
> @@ -2538,6 +2538,7 @@ static void __exit exit_nfs_fs(void)
>
> /* Not quite true; I just maintain it */
> MODULE_AUTHOR("Olaf Kirch <okir@monad.swb.de>");
> +MODULE_DESCRIPTION("NFS client support");
> MODULE_LICENSE("GPL");
> module_param(enable_ino64, bool, 0644);
>
> diff --git a/fs/nfs/nfs2super.c b/fs/nfs/nfs2super.c
> index 467f21ee6a35..b1badc70bd71 100644
> --- a/fs/nfs/nfs2super.c
> +++ b/fs/nfs/nfs2super.c
> @@ -26,6 +26,7 @@ static void __exit exit_nfs_v2(void)
> unregister_nfs_version(&nfs_v2);
> }
>
> +MODULE_DESCRIPTION("NFSv2 client support");
> MODULE_LICENSE("GPL");
>
> module_init(init_nfs_v2);
> diff --git a/fs/nfs/nfs3super.c b/fs/nfs/nfs3super.c
> index 8a9be9e47f76..20a80478449e 100644
> --- a/fs/nfs/nfs3super.c
> +++ b/fs/nfs/nfs3super.c
> @@ -27,6 +27,7 @@ static void __exit exit_nfs_v3(void)
> unregister_nfs_version(&nfs_v3);
> }
>
> +MODULE_DESCRIPTION("NFSv3 client support");
> MODULE_LICENSE("GPL");
>
> module_init(init_nfs_v3);
> diff --git a/fs/nfs/nfs4super.c b/fs/nfs/nfs4super.c
> index 8da5a9c000f4..b29a26923ce0 100644
> --- a/fs/nfs/nfs4super.c
> +++ b/fs/nfs/nfs4super.c
> @@ -332,6 +332,7 @@ static void __exit exit_nfs_v4(void)
> nfs_dns_resolver_destroy();
> }
>
> +MODULE_DESCRIPTION("NFSv4 client support");
> MODULE_LICENSE("GPL");
>
> module_init(init_nfs_v4);
> diff --git a/fs/nfs_common/grace.c b/fs/nfs_common/grace.c
> index 1479583fbb62..8f034aa8c88b 100644
> --- a/fs/nfs_common/grace.c
> +++ b/fs/nfs_common/grace.c
> @@ -139,6 +139,7 @@ exit_grace(void)
> }
>
> MODULE_AUTHOR("Jeff Layton <jlayton@primarydata.com>");
> +MODULE_DESCRIPTION("lockd and nfsv4 grace period control");
> MODULE_LICENSE("GPL");
> module_init(init_grace)
> module_exit(exit_grace)
> diff --git a/fs/nfs_common/nfsacl.c b/fs/nfs_common/nfsacl.c
> index 5a5bd85d08f8..ea382b75b26c 100644
> --- a/fs/nfs_common/nfsacl.c
> +++ b/fs/nfs_common/nfsacl.c
> @@ -29,6 +29,7 @@
> #include <linux/nfs3.h>
> #include <linux/sort.h>
>
> +MODULE_DESCRIPTION("NFS ACL support");
> MODULE_LICENSE("GPL");
>
> struct nfsacl_encode_desc {
>
> ---
> base-commit: 2bfcfd584ff5ccc8bb7acde19b42570414bf880b
> change-id: 20240527-md-fs-nfs-42f19eb60b50
>
Adding core fs maintainers.
Following up to see if anything else is needed to get this merged.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] fs: nfs: add missing MODULE_DESCRIPTION() macros
2024-05-27 17:58 [PATCH] fs: nfs: add missing MODULE_DESCRIPTION() macros Jeff Johnson
2024-06-20 16:17 ` Jeff Johnson
@ 2024-06-20 16:33 ` Jeff Layton
2024-06-20 16:51 ` Jeff Johnson
1 sibling, 1 reply; 4+ messages in thread
From: Jeff Layton @ 2024-06-20 16:33 UTC (permalink / raw)
To: Jeff Johnson, Trond Myklebust, Anna Schumaker, Chuck Lever,
Neil Brown, Olga Kornievskaia, Dai Ngo, Tom Talpey
Cc: linux-nfs, linux-kernel, kernel-janitors
On Mon, 2024-05-27 at 10:58 -0700, Jeff Johnson wrote:
> Fix the 'make W=1' warnings:
> WARNING: modpost: missing MODULE_DESCRIPTION() in
> fs/nfs_common/nfs_acl.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in
> fs/nfs_common/grace.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nfs/nfs.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nfs/nfsv2.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nfs/nfsv3.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nfs/nfsv4.o
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
> fs/nfs/inode.c | 1 +
> fs/nfs/nfs2super.c | 1 +
> fs/nfs/nfs3super.c | 1 +
> fs/nfs/nfs4super.c | 1 +
> fs/nfs_common/grace.c | 1 +
> fs/nfs_common/nfsacl.c | 1 +
> 6 files changed, 6 insertions(+)
>
> diff --git a/fs/nfs/inode.c b/fs/nfs/inode.c
> index acef52ecb1bb..57c473e9d00f 100644
> --- a/fs/nfs/inode.c
> +++ b/fs/nfs/inode.c
> @@ -2538,6 +2538,7 @@ static void __exit exit_nfs_fs(void)
>
> /* Not quite true; I just maintain it */
> MODULE_AUTHOR("Olaf Kirch <okir@monad.swb.de>");
> +MODULE_DESCRIPTION("NFS client support");
> MODULE_LICENSE("GPL");
> module_param(enable_ino64, bool, 0644);
>
> diff --git a/fs/nfs/nfs2super.c b/fs/nfs/nfs2super.c
> index 467f21ee6a35..b1badc70bd71 100644
> --- a/fs/nfs/nfs2super.c
> +++ b/fs/nfs/nfs2super.c
> @@ -26,6 +26,7 @@ static void __exit exit_nfs_v2(void)
> unregister_nfs_version(&nfs_v2);
> }
>
> +MODULE_DESCRIPTION("NFSv2 client support");
> MODULE_LICENSE("GPL");
>
> module_init(init_nfs_v2);
> diff --git a/fs/nfs/nfs3super.c b/fs/nfs/nfs3super.c
> index 8a9be9e47f76..20a80478449e 100644
> --- a/fs/nfs/nfs3super.c
> +++ b/fs/nfs/nfs3super.c
> @@ -27,6 +27,7 @@ static void __exit exit_nfs_v3(void)
> unregister_nfs_version(&nfs_v3);
> }
>
> +MODULE_DESCRIPTION("NFSv3 client support");
> MODULE_LICENSE("GPL");
>
> module_init(init_nfs_v3);
> diff --git a/fs/nfs/nfs4super.c b/fs/nfs/nfs4super.c
> index 8da5a9c000f4..b29a26923ce0 100644
> --- a/fs/nfs/nfs4super.c
> +++ b/fs/nfs/nfs4super.c
> @@ -332,6 +332,7 @@ static void __exit exit_nfs_v4(void)
> nfs_dns_resolver_destroy();
> }
>
> +MODULE_DESCRIPTION("NFSv4 client support");
> MODULE_LICENSE("GPL");
>
> module_init(init_nfs_v4);
> diff --git a/fs/nfs_common/grace.c b/fs/nfs_common/grace.c
> index 1479583fbb62..8f034aa8c88b 100644
> --- a/fs/nfs_common/grace.c
> +++ b/fs/nfs_common/grace.c
> @@ -139,6 +139,7 @@ exit_grace(void)
> }
>
> MODULE_AUTHOR("Jeff Layton <jlayton@primarydata.com>");
> +MODULE_DESCRIPTION("lockd and nfsv4 grace period control");
This module has some code that does other things too. It's basically
some core infrastructure shared by the NFS client and server. Maybe
this should read "NFS client and server infrastructure" ?
> MODULE_LICENSE("GPL");
> module_init(init_grace)
> module_exit(exit_grace)
> diff --git a/fs/nfs_common/nfsacl.c b/fs/nfs_common/nfsacl.c
> index 5a5bd85d08f8..ea382b75b26c 100644
> --- a/fs/nfs_common/nfsacl.c
> +++ b/fs/nfs_common/nfsacl.c
> @@ -29,6 +29,7 @@
> #include <linux/nfs3.h>
> #include <linux/sort.h>
>
> +MODULE_DESCRIPTION("NFS ACL support");
> MODULE_LICENSE("GPL");
>
> struct nfsacl_encode_desc {
>
> ---
> base-commit: 2bfcfd584ff5ccc8bb7acde19b42570414bf880b
> change-id: 20240527-md-fs-nfs-42f19eb60b50
>
--
Jeff Layton <jlayton@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] fs: nfs: add missing MODULE_DESCRIPTION() macros
2024-06-20 16:33 ` Jeff Layton
@ 2024-06-20 16:51 ` Jeff Johnson
0 siblings, 0 replies; 4+ messages in thread
From: Jeff Johnson @ 2024-06-20 16:51 UTC (permalink / raw)
To: Jeff Layton, Trond Myklebust, Anna Schumaker, Chuck Lever,
Neil Brown, Olga Kornievskaia, Dai Ngo, Tom Talpey
Cc: linux-nfs, linux-kernel, kernel-janitors
On 6/20/2024 9:33 AM, Jeff Layton wrote:
> On Mon, 2024-05-27 at 10:58 -0700, Jeff Johnson wrote:
...
>> diff --git a/fs/nfs_common/grace.c b/fs/nfs_common/grace.c
>> index 1479583fbb62..8f034aa8c88b 100644
>> --- a/fs/nfs_common/grace.c
>> +++ b/fs/nfs_common/grace.c
>> @@ -139,6 +139,7 @@ exit_grace(void)
>> }
>>
>> MODULE_AUTHOR("Jeff Layton <jlayton@primarydata.com>");
>> +MODULE_DESCRIPTION("lockd and nfsv4 grace period control");
>
> This module has some code that does other things too. It's basically
> some core infrastructure shared by the NFS client and server. Maybe
> this should read "NFS client and server infrastructure" ?
thanks, will update in v2
/jeff
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-06-20 16:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-27 17:58 [PATCH] fs: nfs: add missing MODULE_DESCRIPTION() macros Jeff Johnson
2024-06-20 16:17 ` Jeff Johnson
2024-06-20 16:33 ` Jeff Layton
2024-06-20 16:51 ` Jeff Johnson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®