From: Andrew Lunn <andrew@lunn.ch>
To: Alfred Lee <l00g33k@gmail.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
olteanv@gmail.com, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, sgarzare@redhat.com,
AVKrasnov@sberdevices.ru
Subject: Re: [PATCH net v3] net: dsa: mv88e6xxx: Wait for EEPROM done before HW reset
Date: Tue, 15 Aug 2023 03:16:03 +0200 [thread overview]
Message-ID: <a7f0ffc1-eb12-4e76-8e0e-7adf40912d08@lunn.ch> (raw)
In-Reply-To: <20230815001323.24739-1-l00g33k@gmail.com>
On Mon, Aug 14, 2023 at 05:13:23PM -0700, Alfred Lee wrote:
> If the switch is reset during active EEPROM transactions, as in
> just after an SoC reset after power up, the I2C bus transaction
> may be cut short leaving the EEPROM internal I2C state machine
> in the wrong state. When the switch is reset again, the bad
> state machine state may result in data being read from the wrong
> memory location causing the switch to enter unexpected mode
> rendering it inoperational.
Hi Alfred
It is normal to place a history after the --- of what changed between
each version.
> Fixes: a3dcb3e7e70c ("net: dsa: mv88e6xxx: Wait for EEPROM done after HW reset")
> Signed-off-by: Alfred Lee <l00g33k@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2023-08-15 1:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-15 0:13 Alfred Lee
2023-08-15 1:16 ` Andrew Lunn [this message]
2023-08-17 3:18 ` Jakub Kicinski
2023-08-17 3:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7f0ffc1-eb12-4e76-8e0e-7adf40912d08@lunn.ch \
--to=andrew@lunn.ch \
--cc=AVKrasnov@sberdevices.ru \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=l00g33k@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=sgarzare@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®