Re: [PATCH] dt-bindings: hwmon: Convert APM X-Gene hwmon to dtschema

Re: [PATCH] dt-bindings: hwmon: Convert APM X-Gene hwmon to dtschema

[Krzysztof Kozlowski]

On 07/03/2024 21:05, Sujal Bhor wrote:
> This patch converts the APM X-Gene hwmon bindings to DT schema (yaml).

Please do not use "This commit/patch/change", but imperative mood. See
longer explanation here:
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95

> 
> Signed-off-by: Sujal Bhor <bhorsujal@gmail.com>
> ---
>  .../hwmon/apm,xgene-slimpro-hwmon.yaml        | 36 +++++++++++++++++++
>  .../bindings/hwmon/apm-xgene-hwmon.txt        | 14 --------
>  2 files changed, 36 insertions(+), 14 deletions(-)
>  create mode 100644
> Documentation/devicetree/bindings/hwmon/apm,xgene-slimpro-hwmon.yaml
>  delete mode 100644
> Documentation/devicetree/bindings/hwmon/apm-xgene-hwmon.txt
> 
> diff --git
> a/Documentation/devicetree/bindings/hwmon/apm,xgene-slimpro-hwmon.yaml
> b/Documentation/devicetree/bindings/hwmon/apm,xgene-slimpro-hwmon.yaml

Malformed patch. I have doubts it is possible to apply it. You can try
and apply it via b4 by yourself...


> new file mode 100644
> index 000000000000..0ef9dd0c4bba
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/apm,xgene-slimpro-hwmon.yaml
> @@ -0,0 +1,36 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwmon/apm,xgene-slimpro-hwmon.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: APM X-Gene hwmon driver

Drop driver. Bindings are about hardware.

> +
> +maintainers:
> +  - Hoan Tran <hotran@apm.com>
> +
> +description: APM X-Gene SOC sensors accessed over the "SLIMpro" mailbox.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - apm,xgene-slimpro-hwmon
> +
> +  mboxes:
> +    maxItems: 1
> +    description: >
> +      Use the label reference for the mailbox as the first parameter.
> +      The second parameter is the channel number.

That's not entirely true. It depends on mbox cells, so drop description.

> +
> +required:
> +  - compatible
> +  - mboxes
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    hwmonslimpro {

hwmon or sensor (depends on what this is)


> +      compatible = "apm,xgene-slimpro-hwmon";
> +      mboxes = <&mailbox 7>;
> +    };

Best regards,
Krzysztof