* [PATCH next] staging: gpib: fix uninitialized variable in usb_gpib_command()
@ 2024-10-17 19:31 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2024-10-17 19:31 UTC (permalink / raw)
To: Dave Penkler
Cc: Greg Kroah-Hartman, linux-staging, linux-kernel, kernel-janitors
The number of bytes written is supposed to be zero at the start of this
function but only one caller, ibcmd(), initializes it to zero. For the
other three callers, setup_serial_poll(), read_serial_poll_byte() and
cleanup_serial_poll(), it's an uninitialized variable.
Fixes: fce79512a96a ("staging: gpib: Add LPVO DIY USB GPIB driver")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c b/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c
index aa7af352e709..4bcbaee65aa9 100644
--- a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c
+++ b/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c
@@ -596,6 +596,7 @@ static int usb_gpib_command(gpib_board_t *board,
set_timeout(board);
+ *bytes_written = 0;
for (i = 0 ; i < length ; i++) {
command[3] = buffer[i];
retval = send_command(board, command, 5);
--
2.45.2
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-10-17 19:31 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-10-17 19:31 [PATCH next] staging: gpib: fix uninitialized variable in usb_gpib_command() Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®