From: Chen Yu <yu.c.chen@intel.com>
To: Reinette Chatre <reinette.chatre@intel.com>,
Tony Luck <tony.luck@intel.com>
Cc: Ben Horgan <ben.horgan@arm.com>,
"James Morse" <james.morse@arm.com>,
Dave Martin <Dave.Martin@arm.com>,
Babu Moger <babu.moger@amd.com>, Fenghua Yu <fenghuay@nvidia.com>,
Borislav Petkov <bp@alien8.de>,
Thomas Gleixner <tglx@linutronix.de>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
Peter Newman <peternewman@google.com>,
chen.yu@linux.dev, x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [RFC PATCH 21/31] x86/resctrl: Parse ACPI MARC table
Date: Mon, 3 Aug 2026 00:07:04 +0800 [thread overview]
Message-ID: <a853c12aa6fc085be05d3f183d3d08d771d96abb.1785680802.git.yu.c.chen@intel.com> (raw)
In-Reply-To: <cover.1785680802.git.yu.c.chen@intel.com>
The MARC table is used to provide Memory Bandwidth Allocation Register
information. Its register addresses are mapped, and the MARC pointer
is saved in the corresponding domain information entry.
Signed-off-by: Chen Yu <yu.c.chen@intel.com>
---
arch/x86/kernel/cpu/resctrl/erdt.c | 70 ++++++++++++++++++++++++++
arch/x86/kernel/cpu/resctrl/internal.h | 10 +++-
2 files changed, 79 insertions(+), 1 deletion(-)
diff --git a/arch/x86/kernel/cpu/resctrl/erdt.c b/arch/x86/kernel/cpu/resctrl/erdt.c
index d16cd6af6648..c44e1d00b89f 100644
--- a/arch/x86/kernel/cpu/resctrl/erdt.c
+++ b/arch/x86/kernel/cpu/resctrl/erdt.c
@@ -25,8 +25,13 @@ static bool erdt_enabled;
#define ERDT_VALID_VERSION 1
#define CMRC_SUPPORTED_INDEX_FN 1
#define MMRC_SUPPORTED_INDEX_FN 1
+#define MARC_SUPPORTED_INDEX_FN 1
#define RMDD_FLAG_CPU_L3_DOMAIN BIT(0)
+#define MARC_FLAG_OPT BIT(0)
+#define MARC_FLAG_MIN BIT(1)
+#define MARC_FLAG_MAX BIT(2)
+
/* Set in a monitoring counter when it holds no valid data to report. */
#define UNAVAILABLE_COUNTER BIT_ULL(63)
#define CMRC_FLAG_UNAVAILABLE_BIT BIT(0)
@@ -283,6 +288,7 @@ static void cleanup_one_domain(struct erdt_domain_info *d)
erdt_iounmap_domain(d);
kfree(d->cmrc);
kfree(d->mmrc);
+ kfree(d->marc);
kfree(d);
}
@@ -396,6 +402,64 @@ static __init int mmrc_init(struct acpi_subtbl_hdr_16 *subtbl,
return 0;
}
+static __init int marc_init(struct acpi_subtbl_hdr_16 *subtbl,
+ struct erdt_domain_info *domain_info)
+{
+ struct acpi_erdt_marc *marc = (struct acpi_erdt_marc *)subtbl;
+
+ if (subtbl->length < sizeof(*marc)) {
+ pr_warn(FW_BUG "Truncated MARC subtable\n");
+ return -EIO;
+ }
+
+ if (marc->index_fn != MARC_SUPPORTED_INDEX_FN) {
+ pr_info("Unsupported MARC index function %d\n", marc->index_fn);
+ return -EIO;
+ }
+
+ if (marc->flags & MARC_FLAG_OPT) {
+ domain_info->base[ERDT_MMIO_MARC_OPT] =
+ erdt_ioremap(marc->reg_base_opt, marc->mba_reg_size, "MARC OPT base");
+ if (!domain_info->base[ERDT_MMIO_MARC_OPT])
+ return -EIO;
+ }
+
+ if (marc->flags & MARC_FLAG_MIN) {
+ domain_info->base[ERDT_MMIO_MARC_MIN] =
+ erdt_ioremap(marc->reg_base_min, marc->mba_reg_size, "MARC MIN base");
+ if (!domain_info->base[ERDT_MMIO_MARC_MIN])
+ goto unmap;
+ }
+
+ if (marc->flags & MARC_FLAG_MAX) {
+ domain_info->base[ERDT_MMIO_MARC_MAX] =
+ erdt_ioremap(marc->reg_base_max, marc->mba_reg_size, "MARC MAX base");
+ if (!domain_info->base[ERDT_MMIO_MARC_MAX])
+ goto unmap;
+ }
+
+ domain_info->marc = kmemdup(marc, subtbl->length, GFP_KERNEL);
+ if (!domain_info->marc)
+ goto unmap;
+
+ return 0;
+
+unmap:
+ if (domain_info->base[ERDT_MMIO_MARC_OPT]) {
+ iounmap(domain_info->base[ERDT_MMIO_MARC_OPT]);
+ domain_info->base[ERDT_MMIO_MARC_OPT] = NULL;
+ }
+ if (domain_info->base[ERDT_MMIO_MARC_MIN]) {
+ iounmap(domain_info->base[ERDT_MMIO_MARC_MIN]);
+ domain_info->base[ERDT_MMIO_MARC_MIN] = NULL;
+ }
+ if (domain_info->base[ERDT_MMIO_MARC_MAX]) {
+ iounmap(domain_info->base[ERDT_MMIO_MARC_MAX]);
+ domain_info->base[ERDT_MMIO_MARC_MAX] = NULL;
+ }
+ return -EIO;
+}
+
static inline struct acpi_subtbl_hdr_16 *rmdd_subtbl(struct acpi_erdt_rmdd *rmdd)
{
return (void *)rmdd + sizeof(*rmdd);
@@ -478,6 +542,12 @@ static __init bool parse_rmdd_table(struct acpi_subtbl_hdr_16 *rmdd_hdr)
!mmrc_init(subtbl, domain_info))
subtbl_mask |= BIT(ACPI_ERDT_TYPE_MMRC);
+ break;
+ case ACPI_ERDT_TYPE_MARC:
+ if (!(subtbl_mask & BIT(ACPI_ERDT_TYPE_MARC)) &&
+ !marc_init(subtbl, domain_info))
+ subtbl_mask |= BIT(ACPI_ERDT_TYPE_MARC);
+
break;
default:
break;
diff --git a/arch/x86/kernel/cpu/resctrl/internal.h b/arch/x86/kernel/cpu/resctrl/internal.h
index ca9124e9aea5..6855022bf07e 100644
--- a/arch/x86/kernel/cpu/resctrl/internal.h
+++ b/arch/x86/kernel/cpu/resctrl/internal.h
@@ -26,12 +26,18 @@
* @ERDT_MMIO_RMDD_CREG: RMDD control register base address
* @ERDT_MMIO_CMRC_BASE: CMRC monitoring register base address
* @ERDT_MMIO_MMRC_BASE: MMRC monitoring register base address
+ * @ERDT_MMIO_MARC_OPT: MARC optimal BW register base address
+ * @ERDT_MMIO_MARC_MIN: MARC minimum BW register base address
+ * @ERDT_MMIO_MARC_MAX: MARC maximum BW register base address
*/
enum erdt_mmio_type {
ERDT_MMIO_RMDD_CREG,
ERDT_MMIO_CMRC_BASE,
ERDT_MMIO_MMRC_BASE,
- ERDT_MMIO_LAST = ERDT_MMIO_MMRC_BASE
+ ERDT_MMIO_MARC_OPT,
+ ERDT_MMIO_MARC_MIN,
+ ERDT_MMIO_MARC_MAX,
+ ERDT_MMIO_LAST = ERDT_MMIO_MARC_MAX
};
#define ERDT_MMIO_NUM_TYPES (ERDT_MMIO_LAST + 1)
@@ -41,6 +47,7 @@ enum erdt_mmio_type {
* @base: Array of ioremapped MMIO region base addresses, indexed by ERDT_MMIO_* type
* @cmrc: Copy of the ACPI CMRC sub-table for this domain
* @mmrc: Copy of the ACPI MMRC sub-table for this domain
+ * @marc: Copy of the ACPI MARC sub-table for this domain
* @cpu_mask: CPUs belonging to this resource management domain
* @max_rmid: Maximum RMID supported by this domain
* @dom_id: L3 cache ID shared by all CPUs in this domain (-1 if unset)
@@ -50,6 +57,7 @@ struct erdt_domain_info {
void __iomem *base[ERDT_MMIO_NUM_TYPES];
struct acpi_erdt_cmrc *cmrc;
struct acpi_erdt_mmrc *mmrc;
+ struct acpi_erdt_marc *marc;
struct cpumask cpu_mask;
u32 max_rmid;
int dom_id;
--
2.43.0
next prev parent reply other threads:[~2026-08-02 16:16 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-02 15:57 [RFC PATCH 00/31] Introduce region-aware RDT support Chen Yu
2026-08-02 16:02 ` [RFC PATCH 01/31] x86/topology: Export topo_lookup_cpuid() for resctrl use Chen Yu
2026-08-02 16:02 ` [RFC PATCH 02/31] x86/resctrl: Require 64-bit x86 for resctrl support Chen Yu
2026-08-02 16:02 ` [RFC PATCH 03/31] x86/resctrl: Parse ACPI ERDT table and save CACD cpumask for RMDD domains Chen Yu
2026-08-02 16:03 ` [RFC PATCH 04/31] x86/resctrl: Attach ACPI ERDT information to L3 mon domain on CPU online Chen Yu
2026-08-02 16:03 ` [RFC PATCH 05/31] x86/resctrl: Parse ACPI CMRC table Chen Yu
2026-08-04 17:19 ` Luck, Tony
2026-08-04 18:13 ` Luck, Tony
2026-08-05 4:59 ` Chen, Yu C
2026-08-02 16:03 ` [RFC PATCH 06/31] x86/resctrl: Refactor the monitor read function Chen Yu
2026-08-02 16:04 ` [RFC PATCH 07/31] fs/resctrl: Do not invoke smp_processor_id() in preemptible context Chen Yu
2026-08-02 16:04 ` [RFC PATCH 08/31] x86/resctrl: Introduce erdt_cpu_has() and erdt_support() Chen Yu
2026-08-02 16:05 ` [RFC PATCH 09/31] x86/resctrl: Add MMIO-based LLC occupancy monitoring support Chen Yu
2026-08-02 16:05 ` [RFC PATCH 10/31] Revert "x86/resctrl: NOT_FOR_INCLUSION: Example support for multiple controls" Chen Yu
2026-08-02 16:05 ` [RFC PATCH 11/31] x86/resctrl: Rename struct resctrl_membw to struct resctrl_ctrl_scalar Chen Yu
2026-08-02 16:05 ` [RFC PATCH 12/31] x86/resctrl: Rename struct resctrl_cache to struct resctrl_ctrl_bitmap Chen Yu
2026-08-02 16:05 ` [RFC PATCH 13/31] x86/resctrl: Add per-control and per-resource flags Chen Yu
2026-08-02 16:06 ` [RFC PATCH 14/31] x86/resctrl: Add emulation controller list to resctrl_ctrl Chen Yu
2026-08-02 16:06 ` [RFC PATCH 15/31] x86/resctrl: Parse ACPI MMRC table Chen Yu
2026-08-02 16:06 ` [RFC PATCH 16/31] x86/resctrl: Replace "msr" in monitoring data identifiers Chen Yu
2026-08-02 16:06 ` [RFC PATCH 17/31] x86/resctrl: Introduce region aware MBM event definitions Chen Yu
2026-08-02 16:06 ` [RFC PATCH 18/31] x86/resctrl: Introduce memory region based MBM read callback on MMIO space Chen Yu
2026-08-02 16:06 ` [RFC PATCH 19/31] x86/resctrl: Enable the region based events by adding them into the event Chen Yu
2026-08-02 16:06 ` [RFC PATCH 20/31] x86/resctrl: Rename msr_update to hw_update Chen Yu
2026-08-02 16:07 ` Chen Yu [this message]
2026-08-02 16:07 ` [RFC PATCH 22/31] fs/resctrl: Add region-based control names and resctrl_ctrl_name_region() Chen Yu
2026-08-02 16:07 ` [RFC PATCH 23/31] x86/resctrl: Add region aware MBA controllers Chen Yu
2026-08-02 16:07 ` [RFC PATCH 24/31] x86/resctrl: Attach ACPI ERDT information to ctrl domain on CPU online Chen Yu
2026-08-02 16:07 ` [RFC PATCH 25/31] x86/resctrl: Introduce region-based MBA write implementation on MMIO space Chen Yu
2026-08-04 21:13 ` Luck, Tony
2026-08-05 6:32 ` Chen, Yu C
2026-08-02 16:07 ` [RFC PATCH 26/31] x86/resctrl: Allow control writes from any CPU for MMIO controllers Chen Yu
2026-08-02 16:07 ` [RFC PATCH 27/31] x86/resctrl: Enable region-aware MBM/MBA via the RDT_CTRL register Chen Yu
2026-08-02 16:08 ` [RFC PATCH 28/31] x86/resctrl: Emulate the legacy MBA controller via the region MAX controls Chen Yu
2026-08-02 16:08 ` [RFC PATCH 29/31] fs/resctrl: Expose emulation controllers in a resource_schemata subdir Chen Yu
2026-08-02 16:08 ` [RFC PATCH 30/31] fs/resctrl: Fix excessive padding in schemata output Chen Yu
2026-08-02 16:08 ` [RFC PATCH 31/31] x86,fs/resctrl: Update Documentation for region aware RDT Chen Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a853c12aa6fc085be05d3f183d3d08d771d96abb.1785680802.git.yu.c.chen@intel.com \
--to=yu.c.chen@intel.com \
--cc=Dave.Martin@arm.com \
--cc=babu.moger@amd.com \
--cc=ben.horgan@arm.com \
--cc=bp@alien8.de \
--cc=chen.yu@linux.dev \
--cc=dave.hansen@linux.intel.com \
--cc=fenghuay@nvidia.com \
--cc=james.morse@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peternewman@google.com \
--cc=reinette.chatre@intel.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®