From: Jarkko Nikula <jarkko.nikula@bitmer.com>
To: Joseph Telaak <joseph@telaak.dev>, Sen Wang <sen@ti.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>
Cc: linux-sound@vger.kernel.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] ASoC: ti: omap-mcbsp: Use all 8 bits of CLKGDV
Date: Tue, 17 Nov 2026 21:12:25 +0200 [thread overview]
Message-ID: <a8679a17-b4cb-49ab-86f0-af24d4b4f4cd@bitmer.com> (raw)
In-Reply-To: <20261116-omap-mcbsp-tdm-slot-v1-1-6c9f7aa45a29@telaak.dev>
Hi
On 11/17/26 12:03 AM, Joseph Telaak wrote:
> CLKGDV is bits 7:0 of SRGR1, as its comment says and as set_clkdiv()
> intends with CLKGDV(0xff), but the macro masks the value with 0x7f, so
> a divider above 128 is written modulo 128.
>
> Mask with 0xff. The only set_clkdiv() user, omap3pandora, divides by 8,
> so nothing changes for it; this lets the set_tdm_slot() support that
> follows use dividers up to 256.
>
> Signed-off-by: Joseph Telaak <joseph@telaak.dev>
> ---
> sound/soc/ti/omap-mcbsp-priv.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/ti/omap-mcbsp-priv.h b/sound/soc/ti/omap-mcbsp-priv.h
> index da519ea1f303..324c5d7d431d 100644
> --- a/sound/soc/ti/omap-mcbsp-priv.h
> +++ b/sound/soc/ti/omap-mcbsp-priv.h
> @@ -136,7 +136,7 @@ enum {
> #define XPHASE BIT(15)
>
> /************************* McBSP SRGR1 bit definitions ************************/
> -#define CLKGDV(value) ((value) & 0x7f) /* Bits 0:7 */
> +#define CLKGDV(value) ((value) & 0xff) /* Bits 0:7 */
> #define FWID(value) (((value) & 0xff) << 8) /* Bits 8:15 */
Nice, this has been unnoticed since 2012.
Acked-by: Jarkko Nikula <jarkko.nikula@bitmer.com>
next prev parent reply other threads:[~2026-11-17 19:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 22:03 [PATCH 0/2] ASoC: ti: omap-mcbsp: TDM slots for generic cards Joseph Telaak
2026-11-16 22:03 ` [PATCH 1/2] ASoC: ti: omap-mcbsp: Use all 8 bits of CLKGDV Joseph Telaak
2026-11-17 19:12 ` Jarkko Nikula [this message]
2026-11-16 22:03 ` [PATCH 2/2] ASoC: ti: omap-mcbsp: Implement set_tdm_slot Joseph Telaak
2026-11-17 19:14 ` Jarkko Nikula
2026-11-17 22:11 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8679a17-b4cb-49ab-86f0-af24d4b4f4cd@bitmer.com \
--to=jarkko.nikula@bitmer.com \
--cc=broonie@kernel.org \
--cc=joseph@telaak.dev \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=sen@ti.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®