From: Adrian Hunter <adrian.hunter@intel.com>
To: Kishon Vijay Abraham I <kishon@ti.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Tony Lindgren <tony@atomide.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Russell King <linux@armlinux.org.uk>,
linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 02/11] mmc: sdhci-omap: Remove setting ADMA capability in driver
Date: Thu, 15 Mar 2018 16:18:49 +0200 [thread overview]
Message-ID: <a867eebf-2c32-4a0f-713a-766d81d52c4c@intel.com> (raw)
In-Reply-To: <20180307132020.30951-3-kishon@ti.com>
On 07/03/18 15:20, Kishon Vijay Abraham I wrote:
> sdhci can directly get ADMA capability from MMCHS_CAPA register.
> Remove explicitly setting ADMA here as some instances might not have
> ADMA enabled. (sdhci_read_caps() is also removed from here since
> sdhci_setup_host() invokes it).
>
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> drivers/mmc/host/sdhci-omap.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-omap.c b/drivers/mmc/host/sdhci-omap.c
> index 3cce30584d2f..0c40b13fb67d 100644
> --- a/drivers/mmc/host/sdhci-omap.c
> +++ b/drivers/mmc/host/sdhci-omap.c
> @@ -923,9 +923,6 @@ static int sdhci_omap_probe(struct platform_device *pdev)
> host->mmc_host_ops.card_busy = sdhci_omap_card_busy;
> host->mmc_host_ops.execute_tuning = sdhci_omap_execute_tuning;
>
> - sdhci_read_caps(host);
> - host->caps |= SDHCI_CAN_DO_ADMA2;
> -
> ret = sdhci_setup_host(host);
> if (ret)
> goto err_put_sync;
>
next prev parent reply other threads:[~2018-03-15 14:20 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-07 13:20 [PATCH v3 00/11] mmc: sdhci-omap: Add UHS/HS200 mode support Kishon Vijay Abraham I
2018-03-07 13:20 ` [PATCH v3 01/11] mmc: sdhci-omap: Fix when capabilities are obtained from SDHCI_CAPABILITIES reg Kishon Vijay Abraham I
2018-03-15 14:17 ` Adrian Hunter
2018-03-07 13:20 ` [PATCH v3 02/11] mmc: sdhci-omap: Remove setting ADMA capability in driver Kishon Vijay Abraham I
2018-03-15 14:18 ` Adrian Hunter [this message]
2018-03-07 13:20 ` [PATCH v3 03/11] mmc: sdhci-omap: Workaround for Errata i843 Kishon Vijay Abraham I
2018-03-15 14:24 ` Adrian Hunter
2018-03-07 13:20 ` [PATCH v3 04/11] mmc: sdhci-omap: Invoke sdhci_get_of_property to read sdhci dt properties Kishon Vijay Abraham I
2018-03-15 14:27 ` Adrian Hunter
2018-03-07 13:20 ` [PATCH v3 05/11] mmc: sdhci: Disable HS200 mode if controller can't support 1.8v Kishon Vijay Abraham I
2018-03-15 10:58 ` Adrian Hunter
2018-03-07 13:20 ` [PATCH v3 06/11] mmc: sdhci: Add quirk to disable HW timeout Kishon Vijay Abraham I
2018-03-15 11:26 ` Adrian Hunter
2018-03-07 13:20 ` [PATCH v3 07/11] mmc: sdhci: Program a relatively accurate SW timeout value Kishon Vijay Abraham I
2018-03-15 13:13 ` Adrian Hunter
2018-03-16 6:29 ` Kishon Vijay Abraham I
2018-03-16 14:21 ` Adrian Hunter
2018-03-19 9:20 ` Kishon Vijay Abraham I
2018-03-19 10:00 ` Adrian Hunter
2018-03-19 10:19 ` Kishon Vijay Abraham I
2018-03-20 9:48 ` Kishon Vijay Abraham I
2018-04-04 12:48 ` Adrian Hunter
2018-03-07 13:20 ` [PATCH v3 08/11] mmc: sdhci-omap: Workaround for Errata i834 Kishon Vijay Abraham I
2018-03-07 13:20 ` [PATCH v3 09/11] dt-bindings: sdhci-omap: Add K2G specific binding Kishon Vijay Abraham I
2018-03-07 13:20 ` [PATCH v3 10/11] mmc: sdhci-omap: Add support for MMC/SD controller in k2g SoC Kishon Vijay Abraham I
2018-03-07 13:20 ` [PATCH v3 11/11] mmc: sdhci-omap: Add sdhci_omap specific ops for enable_sdio_irq Kishon Vijay Abraham I
2018-03-15 14:34 ` Adrian Hunter
2018-03-07 15:12 ` [PATCH v3 00/11] mmc: sdhci-omap: Add UHS/HS200 mode support Tony Lindgren
2018-03-15 8:47 ` Ulf Hansson
2018-03-15 8:52 ` Adrian Hunter
2018-03-15 10:02 ` Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a867eebf-2c32-4a0f-713a-766d81d52c4c@intel.com \
--to=adrian.hunter@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®