Re: [PATCH UNTESTED 5/5] arm64: dts: rockchip: Enable HDMI0 on rock-5a

[Cristian Ciocaltea <cristian.ciocaltea@collabora.com>]

On 10/19/24 7:42 AM, FUKAUMI Naoki wrote:
> Hi,
> 
> On 10/19/24 06:39, Cristian Ciocaltea wrote:
>> Add the necessary DT changes to enable HDMI0 on Rock 5A.
>>
>> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
>> ---
>>   arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts | 47 ++++++++++++++
>> ++++++++++
>>   1 file changed, 47 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts b/arch/
>> arm64/boot/dts/rockchip/rk3588s-rock-5a.dts
>> index
>> 87fce8d9a964cd53d179ce214ae1c0ff505a2dce..1fd122250b0c70e729b7a2239ab5f288a6387a70 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts
>> +++ b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts
>> @@ -5,6 +5,7 @@
>>   #include <dt-bindings/gpio/gpio.h>
>>   #include <dt-bindings/leds/common.h>
>>   #include <dt-bindings/pinctrl/rockchip.h>
>> +#include <dt-bindings/soc/rockchip,vop2.h>
>>   #include "rk3588s.dtsi"
>>     / {
>> @@ -35,6 +36,17 @@ chosen {
>>           stdout-path = "serial2:1500000n8";
>>       };
>>   +    hdmi0-con {
>> +        compatible = "hdmi-connector";
>> +        type = "a";
>> +
>> +        port {
>> +            hdmi0_con_in: endpoint {
>> +                remote-endpoint = <&hdmi0_out_con>;
>> +            };
>> +        };
>> +    };
>> +
>>       leds {
>>           compatible = "gpio-leds";
>>           pinctrl-names = "default";
>> @@ -296,6 +308,26 @@ &gmac1_rgmii_clk
>>       status = "okay";
>>   };
>>   +&hdmi0 {
>> +    status = "okay";
>> +};
> 
> on ROCK 5A, HPD pin is different.
> 
> how about this?
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts b/arch/
> arm64/boot/dts/rockchip/rk3588s-rock-5a.dts
> index f4293d666368..600028fcad88 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts
> @@ -314,6 +314,9 @@ &gmac1_rgmii_clk
>  };
> 
>  &hdmi0 {
> +    pinctrl-names = "default";
> +    pinctrl-0 = <&hdmim0_tx0_cec &hdmim1_tx0_hpd
> +             &hdmim0_tx0_scl &hdmim0_tx0_sda>;
>      status = "okay";
>  };
> 

Thanks for figuring this out!

Regards,
Cristian