mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Lin Wang <wanglin@open-hieco.net>
To: Yazen Ghannam <yazen.ghannam@amd.com>
Cc: Borislav Petkov <bp@alien8.de>,
	Mario Limonciello <mario.limonciello@amd.com>,
	Pu Wen <puwen@hygon.cn>, Thomas Gleixner <tglx@kernel.org>,
	Ingo Molnar <mingo@redhat.com>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>, Tony Luck <tony.luck@intel.com>,
	x86@kernel.org, linux-edac@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 7/7] x86/hygon: Add Family 0x18 SMN access
Date: Mon, 19 Oct 2026 09:45:05 +0800	[thread overview]
Message-ID: <a8af3fba-72a8-438b-bf32-1885d99fcc10@open-hieco.net> (raw)
In-Reply-To: <20261017154140.GF359037@yaz-khff2.amd.com>

Hi Yazen,

On 10/17/2026 11:41 PM, Yazen Ghannam wrote:
>> +EXPORT_SYMBOL_GPL(hygon_smn_read);
>> +
>> +int hygon_smn_write(u16 node, u32 address, u32 value)
>> +{
>> +	return smn_rw(node, address, &value, true);
>> +}
>> +EXPORT_SYMBOL_GPL(hygon_smn_write);
>> +
> Same point as before for exported functions.

I'll also keep the SMN read/write helpers local until they have
in-tree users, and remove their public declarations, stubs and exports.

Thanks for the review and the Reviewed-by.

Lin

      reply	other threads:[~2026-10-19  1:45 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-09  9:01 [PATCH v7 0/7] x86/hygon: Add Family 0x18 DF node enumeration and " Lin Wang
2026-10-09  9:01 ` [PATCH v7 1/7] x86/hygon: Add Family 0x18 DF node enumeration Lin Wang
2026-10-17 14:52   ` Yazen Ghannam
2026-10-19  1:54     ` Lin Wang
2026-10-09  9:01 ` [PATCH v7 2/7] x86/hygon: Map CPU NodeIds to DF nodes Lin Wang
2026-10-17 15:10   ` Yazen Ghannam
2026-10-19  1:29     ` Lin Wang
2026-10-09  9:01 ` [PATCH v7 3/7] EDAC/amd64: Stop matching Hygon CPUs Lin Wang
2026-10-17 15:16   ` Yazen Ghannam
2026-10-09  9:01 ` [PATCH v7 4/7] RAS/AMD/ATL: Match AMD CPUs only Lin Wang
2026-10-17 15:20   ` Yazen Ghannam
2026-10-09  9:01 ` [PATCH v7 5/7] x86/amd_nb: Restrict the northbridge framework to AMD CPUs Lin Wang
2026-10-09  9:01 ` [PATCH v7 6/7] x86/amd_node: Restrict SMN setup " Lin Wang
2026-10-17 15:33   ` Yazen Ghannam
2026-10-19  1:40     ` Lin Wang
2026-10-09  9:01 ` [PATCH v7 7/7] x86/hygon: Add Family 0x18 SMN access Lin Wang
2026-10-17 15:41   ` Yazen Ghannam
2026-10-19  1:45     ` Lin Wang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a8af3fba-72a8-438b-bf32-1885d99fcc10@open-hieco.net \
    --to=wanglin@open-hieco.net \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=mingo@redhat.com \
    --cc=puwen@hygon.cn \
    --cc=tglx@kernel.org \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    --cc=yazen.ghannam@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®