From: Joe Perches <joe@perches.com>
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>,
Liao Chang <liaochang1@huawei.com>
Cc: apw@canonical.com, dwaipayanray1@gmail.com,
linux-kernel@vger.kernel.org, bagasdotme@gmail.com,
pbonzini@redhat.com
Subject: Re: [PATCH -next v2] checkpatch: Add check for array allocator family argument order
Date: Fri, 04 Nov 2022 07:33:39 -0700 [thread overview]
Message-ID: <a8b903f83433c710fff6f80b5bd5353b9be663a9.camel@perches.com> (raw)
In-Reply-To: <CAKXUXMxi_aqnvCmYjakQzoYvYqqwrvMnFt-czLV1iUnO0TnScg@mail.gmail.com>
On Fri, 2022-11-04 at 09:35 +0100, Lukas Bulwahn wrote:
> On Fri, Nov 4, 2022 at 8:08 AM Liao Chang <liaochang1@huawei.com> wrote:
> >
> > These array allocator family are sometimes misused with the first and
> > second arguments switchted.
>
> Just a nit:
>
> s/switchted/switched/
>
> But probably you actually mean "swapped". I think there is a slight
> difference between the two words, "switched" and "swapped". And here
> the arguments are swapped. Note: I am also not a native speaker.
>
> For the implementation change:
>
> Acked-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
>
> How many new findings are now identified with this extended check on
> linux-next? Could you run checkpatch on all files of linux-next and
> share the new findings? Then we can do a quick scan if some instances
> should be immediately fixed or some janitor should follow through with
> such a task.
There are ~25.
It's fairly trivial Lukas and only cosmetic.
https://lore.kernel.org/lkml/d92ada3062bc1c3a7557bfa0499fc4a8cee3aa10.camel@perches.com/
next prev parent reply other threads:[~2022-11-04 14:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-04 7:05 Liao Chang
2022-11-04 8:35 ` Lukas Bulwahn
2022-11-04 14:33 ` Joe Perches [this message]
2022-11-07 1:25 ` liaochang (A)
2022-11-04 17:08 ` Christophe JAILLET
2022-11-05 17:24 ` Joe Perches
2022-11-05 21:36 ` Christophe JAILLET
2022-11-07 1:25 ` liaochang (A)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8b903f83433c710fff6f80b5bd5353b9be663a9.camel@perches.com \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=bagasdotme@gmail.com \
--cc=dwaipayanray1@gmail.com \
--cc=liaochang1@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®