From: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
To: syzbot <syzbot@kernel.org>,
syzkaller-bugs@googlegroups.com, Slawomir Stepien <sst@poczta.fm>,
linux-wireless@vger.kernel.org, Daniel Drake <dsd@gentoo.org>
Cc: johannes.berg@intel.com, kees@kernel.org,
linux-kernel@vger.kernel.org, nihaal@cse.iitm.ac.in,
syzbot@lists.linux.dev
Subject: Re: [PATCH] wifi: zd1211rw: reject secondary interfaces to prevent conflicts
Date: Wed, 29 Jul 2026 11:53:32 -0700 [thread overview]
Message-ID: <a8e1200f-5f79-4c86-915c-96464596fd0e@oss.qualcomm.com> (raw)
In-Reply-To: <0720e3ad-d98e-47d7-89af-4d22416b0fbc@mail.kernel.org>
On 7/29/2026 1:04 AM, syzbot wrote:
> @@ -1353,6 +1353,13 @@ static int probe(struct usb_interface *intf, const struct usb_device_id *id)
> struct zd_usb *usb;
> struct ieee80211_hw *hw = NULL;
>
> + /* ZD1211 devices are single-function. Reject secondary interfaces
this does not follow linux block comment style
/* should be on a separate line
(at one time networking code had a different style, but not now)
> + * to prevent multiple instances from conflicting on hardcoded endpoints
> + * and triggering recursive locking warnings.
> + */
> + if (intf->cur_altsetting->desc.bInterfaceNumber != 0)
> + return -ENODEV;
> +
> print_id(udev);
>
> if (id->driver_info & DEVICE_INSTALLER)
>
>
> base-commit: 1590cf0329716306e948a8fc29f1d3ee87d3989f
next prev parent reply other threads:[~2026-07-29 18:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-29 8:04 syzbot
2026-07-29 18:53 ` Jeff Johnson [this message]
2026-07-31 17:36 ` Jeff Johnson
2026-07-31 19:45 ` Vlastimil Babka (SUSE)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8e1200f-5f79-4c86-915c-96464596fd0e@oss.qualcomm.com \
--to=jeff.johnson@oss.qualcomm.com \
--cc=dsd@gentoo.org \
--cc=johannes.berg@intel.com \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nihaal@cse.iitm.ac.in \
--cc=sst@poczta.fm \
--cc=syzbot@kernel.org \
--cc=syzbot@lists.linux.dev \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®