From: Joe Perches <joe@perches.com>
To: "Thorsten Leemhuis" <linux@leemhuis.info>,
"Kai Wasserbäch" <kai@dev.carbon-project.org>,
linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andy Whitcroft <apw@canonical.com>,
Dwaipayan Ray <dwaipayanray1@gmail.com>,
Lukas Bulwahn <lukas.bulwahn@gmail.com>
Subject: Re: [PATCH 2/2] checkpatch: warn when Reported-by: is not followed by Link:
Date: Fri, 09 Dec 2022 09:00:15 -0800 [thread overview]
Message-ID: <a8f383e35a4194c5b137a787f2f0e133e11a80c5.camel@perches.com> (raw)
In-Reply-To: <c0f9e6d8-d402-df54-475d-0552dd5576dd@leemhuis.info>
On Fri, 2022-12-09 at 10:54 +0100, Thorsten Leemhuis wrote:
> On 08.12.22 21:21, Joe Perches wrote:
> > On Thu, 2022-12-08 at 20:32 +0100, Kai Wasserbäch wrote:
[]
> > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> > []
> > > @@ -3144,6 +3144,20 @@ sub process {
> > > "Co-developed-by and Signed-off-by: name/email do not match \n" . "$here\n" . $rawline . "\n" .$rawlines[$linenr]);
> >
> > I believe this use of '"$here\n" . $rawline . "\n"' to be a defect.
> > I think this should just use $herecurr
> >
> > And the unnecessary space before a newline is an abomination ;)
> >
> > "Co-developed-by and Signed-off-by: name/email do not match\n" . $herecurr . $rawlines[$linenr]);
>
> Well, that's existing code. Want me to add a separate patch that fixes
> both of these aspects up in that area?
Sure, thanks.
next prev parent reply other threads:[~2022-12-09 17:00 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-04 11:33 [PATCH 0/2] feat: checkpatch: prohibit Buglink: and warn about missing Link: Kai Wasserbäch
2022-12-04 11:33 ` [PATCH 1/2] feat: checkpatch: error on usage of a Buglink tag in the commit log Kai Wasserbäch
2022-12-04 11:33 ` [PATCH 2/2] feat: checkpatch: Warn about Reported-by: not being followed by a Link: Kai Wasserbäch
2022-12-08 19:32 ` [PATCH 1/2] checkpatch: warn when unknown tags are used for links Kai Wasserbäch
2022-12-08 19:58 ` Joe Perches
2022-12-09 9:33 ` Thorsten Leemhuis
2022-12-09 16:57 ` Joe Perches
2022-12-08 19:32 ` [PATCH 2/2] checkpatch: warn when Reported-by: is not followed by Link: Kai Wasserbäch
2022-12-08 20:21 ` Joe Perches
2022-12-08 21:11 ` Thorsten Leemhuis
2022-12-08 21:34 ` Joe Perches
2022-12-09 8:33 ` Thorsten Leemhuis
2022-12-09 9:54 ` Thorsten Leemhuis
2022-12-09 17:00 ` Joe Perches [this message]
2022-12-15 14:43 ` [PATCH 0/3, v3] feat: checkpatch: warn about dicouraged link tags and missing links Kai Wasserbäch
2022-12-15 14:43 ` [PATCH 1/3] checkpatch: warn when unknown tags are used for links Kai Wasserbäch
2022-12-15 14:43 ` [PATCH 2/3] checkpatch: warn when Reported-by: is not followed by Link: Kai Wasserbäch
2022-12-15 18:00 ` Joe Perches
2022-12-18 14:54 ` Thorsten Leemhuis
2022-12-15 14:43 ` [PATCH 3/3] checkpatch: use proper way for show problematic line Kai Wasserbäch
2023-01-20 12:35 ` [PATCH v4 0/3] checkpatch.pl: warn about discouraged tags and missing Link: tags Thorsten Leemhuis
2023-01-20 12:35 ` [PATCH v4 1/3] checkpatch: warn when unknown tags are used for links Thorsten Leemhuis
2023-02-27 13:25 ` Matthieu Baerts
2023-03-02 5:36 ` Thorsten Leemhuis
2023-01-20 12:35 ` [PATCH v4 2/3] checkpatch: warn when Reported-by: is not followed by Link: Thorsten Leemhuis
2023-03-02 4:46 ` Jakub Kicinski
2023-03-02 5:17 ` Thorsten Leemhuis
2023-03-02 5:40 ` Jakub Kicinski
2023-03-02 8:27 ` Dmitry Vyukov
2023-03-02 9:04 ` Thorsten Leemhuis
2023-03-02 9:11 ` Dmitry Vyukov
2023-03-02 9:48 ` Thorsten Leemhuis
2023-03-03 2:10 ` Andrew Morton
2023-03-06 8:53 ` Dmitry Vyukov
2023-03-07 11:36 ` Thorsten Leemhuis
2023-01-20 12:35 ` [PATCH v4 3/3] checkpatch: use proper way for show problematic line Thorsten Leemhuis
2023-01-20 15:20 ` [PATCH v4 0/3] checkpatch.pl: warn about discouraged tags and missing Link: tags Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8f383e35a4194c5b137a787f2f0e133e11a80c5.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=dwaipayanray1@gmail.com \
--cc=kai@dev.carbon-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@leemhuis.info \
--cc=lukas.bulwahn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®