From: Thorsten Leemhuis <linux@leemhuis.info>
To: Joe Perches <joe@perches.com>, Andy Whitcroft <apw@canonical.com>,
Dwaipayan Ray <dwaipayanray1@gmail.com>,
Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc: "Kai Wasserbäch" <kai@dev.carbon-project.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH v4 0/3] checkpatch.pl: warn about discouraged tags and missing Link: tags
Date: Fri, 20 Jan 2023 13:35:17 +0100 [thread overview]
Message-ID: <cover.1674217480.git.linux@leemhuis.info> (raw)
In-Reply-To: <cover.1670152844.git.kai@dev.carbon-project.org>
Hi, please consider the following checkpatch.pl patches for review.
The first two changes make checkpatch.pl check for a few mistakes wrt to
links to bug reports Linus recently complained about a few times.
Avoiding those is also important for my regression tracking efforts a
lot, as the automated tracking performed by regzbot relies on the proper
usage of the Link: tag.
The third patch fixes a few small oddities noticed in existing code
during review of the two changes.
Ciao, Thorsten
---
v3->v4:
- address review feedback from Joe (do not allow leading spaces in
matches, check if Link: is actually followed by a URL in one go,
and use m{} for matching https://) (Thorsten)
- catch Reported-and-tested-by as well (Thorsten)
v2->v3:
- address review feedback from Joe (grammer fixes, use of $herecurr, use
of --no-merges in commit log quote) (Thorsten)
- warn when people try to add version information to the commit log
using code suggested by Joe (Thorsten)
- add a patch to make existing code in a nearby area use $herecurr where
it should, which Joe noticed during review
v1->v2:
- add commit messages explaining the reasoning (Thorsten)
- approach the usage of wrong tags with an allow list as suggested by
Joe (Thorsten)
Kai Wasserbäch (2):
checkpatch: warn when unknown tags are used for links
checkpatch: warn when Reported-by: is not followed by Link:
Thorsten Leemhuis (1):
checkpatch: use proper way for show problematic line
scripts/checkpatch.pl | 34 +++++++++++++++++++++++++++++-----
1 file changed, 29 insertions(+), 5 deletions(-)
base-commit: 5dc4c995db9eb45f6373a956eb1f69460e69e6d4
--
2.39.0
next prev parent reply other threads:[~2023-01-20 12:35 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-04 11:33 [PATCH 0/2] feat: checkpatch: prohibit Buglink: and warn about missing Link: Kai Wasserbäch
2022-12-04 11:33 ` [PATCH 1/2] feat: checkpatch: error on usage of a Buglink tag in the commit log Kai Wasserbäch
2022-12-04 11:33 ` [PATCH 2/2] feat: checkpatch: Warn about Reported-by: not being followed by a Link: Kai Wasserbäch
2022-12-08 19:32 ` [PATCH 1/2] checkpatch: warn when unknown tags are used for links Kai Wasserbäch
2022-12-08 19:58 ` Joe Perches
2022-12-09 9:33 ` Thorsten Leemhuis
2022-12-09 16:57 ` Joe Perches
2022-12-08 19:32 ` [PATCH 2/2] checkpatch: warn when Reported-by: is not followed by Link: Kai Wasserbäch
2022-12-08 20:21 ` Joe Perches
2022-12-08 21:11 ` Thorsten Leemhuis
2022-12-08 21:34 ` Joe Perches
2022-12-09 8:33 ` Thorsten Leemhuis
2022-12-09 9:54 ` Thorsten Leemhuis
2022-12-09 17:00 ` Joe Perches
2022-12-15 14:43 ` [PATCH 0/3, v3] feat: checkpatch: warn about dicouraged link tags and missing links Kai Wasserbäch
2022-12-15 14:43 ` [PATCH 1/3] checkpatch: warn when unknown tags are used for links Kai Wasserbäch
2022-12-15 14:43 ` [PATCH 2/3] checkpatch: warn when Reported-by: is not followed by Link: Kai Wasserbäch
2022-12-15 18:00 ` Joe Perches
2022-12-18 14:54 ` Thorsten Leemhuis
2022-12-15 14:43 ` [PATCH 3/3] checkpatch: use proper way for show problematic line Kai Wasserbäch
2023-01-20 12:35 ` Thorsten Leemhuis [this message]
2023-01-20 12:35 ` [PATCH v4 1/3] checkpatch: warn when unknown tags are used for links Thorsten Leemhuis
2023-02-27 13:25 ` Matthieu Baerts
2023-03-02 5:36 ` Thorsten Leemhuis
2023-01-20 12:35 ` [PATCH v4 2/3] checkpatch: warn when Reported-by: is not followed by Link: Thorsten Leemhuis
2023-03-02 4:46 ` Jakub Kicinski
2023-03-02 5:17 ` Thorsten Leemhuis
2023-03-02 5:40 ` Jakub Kicinski
2023-03-02 8:27 ` Dmitry Vyukov
2023-03-02 9:04 ` Thorsten Leemhuis
2023-03-02 9:11 ` Dmitry Vyukov
2023-03-02 9:48 ` Thorsten Leemhuis
2023-03-03 2:10 ` Andrew Morton
2023-03-06 8:53 ` Dmitry Vyukov
2023-03-07 11:36 ` Thorsten Leemhuis
2023-01-20 12:35 ` [PATCH v4 3/3] checkpatch: use proper way for show problematic line Thorsten Leemhuis
2023-01-20 15:20 ` [PATCH v4 0/3] checkpatch.pl: warn about discouraged tags and missing Link: tags Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1674217480.git.linux@leemhuis.info \
--to=linux@leemhuis.info \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=dwaipayanray1@gmail.com \
--cc=joe@perches.com \
--cc=kai@dev.carbon-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome