* [PATCH -next] usb: typec: ucsi: Fix unmet dependencies for UCSI_HUAWEI_GAOKUN
@ 2025-04-17 12:28 Yue Haibing
2025-04-17 13:44 ` Heikki Krogerus
0 siblings, 1 reply; 2+ messages in thread
From: Yue Haibing @ 2025-04-17 12:28 UTC (permalink / raw)
To: heikki.krogerus, gregkh, yuehaibing, mitltlatltl; +Cc: linux-usb, linux-kernel
WARNING: unmet direct dependencies detected for DRM_AUX_HPD_BRIDGE
Depends on [n]: HAS_IOMEM [=y] && DRM [=n] && DRM_BRIDGE [=n] && OF [=n]
Selected by [m]:
- UCSI_HUAWEI_GAOKUN [=m] && USB_SUPPORT [=y] && TYPEC [=m] && TYPEC_UCSI [=m] && EC_HUAWEI_GAOKUN [=m]
DRM_AUX_HPD_BRIDGE depends on DRM_BRIDGE and OF, only select it with
both for UCSI_HUAWEI_GAOKUN.
Fixes: 00327d7f2c8c ("usb: typec: ucsi: add Huawei Matebook E Go ucsi driver")
Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
---
drivers/usb/typec/ucsi/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/typec/ucsi/Kconfig b/drivers/usb/typec/ucsi/Kconfig
index e94956d27325..8bf8fefb4f07 100644
--- a/drivers/usb/typec/ucsi/Kconfig
+++ b/drivers/usb/typec/ucsi/Kconfig
@@ -94,7 +94,7 @@ config UCSI_LENOVO_YOGA_C630
config UCSI_HUAWEI_GAOKUN
tristate "UCSI Interface Driver for Huawei Matebook E Go"
depends on EC_HUAWEI_GAOKUN
- select DRM_AUX_HPD_BRIDGE
+ select DRM_AUX_HPD_BRIDGE if DRM_BRIDGE && OF
help
This driver enables UCSI support on the Huawei Matebook E Go tablet,
which is a sc8280xp-based 2-in-1 tablet.
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH -next] usb: typec: ucsi: Fix unmet dependencies for UCSI_HUAWEI_GAOKUN
2025-04-17 12:28 [PATCH -next] usb: typec: ucsi: Fix unmet dependencies for UCSI_HUAWEI_GAOKUN Yue Haibing
@ 2025-04-17 13:44 ` Heikki Krogerus
0 siblings, 0 replies; 2+ messages in thread
From: Heikki Krogerus @ 2025-04-17 13:44 UTC (permalink / raw)
To: Yue Haibing; +Cc: gregkh, mitltlatltl, linux-usb, linux-kernel
On Thu, Apr 17, 2025 at 08:28:43PM +0800, Yue Haibing wrote:
> WARNING: unmet direct dependencies detected for DRM_AUX_HPD_BRIDGE
> Depends on [n]: HAS_IOMEM [=y] && DRM [=n] && DRM_BRIDGE [=n] && OF [=n]
> Selected by [m]:
> - UCSI_HUAWEI_GAOKUN [=m] && USB_SUPPORT [=y] && TYPEC [=m] && TYPEC_UCSI [=m] && EC_HUAWEI_GAOKUN [=m]
>
> DRM_AUX_HPD_BRIDGE depends on DRM_BRIDGE and OF, only select it with
> both for UCSI_HUAWEI_GAOKUN.
>
> Fixes: 00327d7f2c8c ("usb: typec: ucsi: add Huawei Matebook E Go ucsi driver")
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/usb/typec/ucsi/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/ucsi/Kconfig b/drivers/usb/typec/ucsi/Kconfig
> index e94956d27325..8bf8fefb4f07 100644
> --- a/drivers/usb/typec/ucsi/Kconfig
> +++ b/drivers/usb/typec/ucsi/Kconfig
> @@ -94,7 +94,7 @@ config UCSI_LENOVO_YOGA_C630
> config UCSI_HUAWEI_GAOKUN
> tristate "UCSI Interface Driver for Huawei Matebook E Go"
> depends on EC_HUAWEI_GAOKUN
> - select DRM_AUX_HPD_BRIDGE
> + select DRM_AUX_HPD_BRIDGE if DRM_BRIDGE && OF
> help
> This driver enables UCSI support on the Huawei Matebook E Go tablet,
> which is a sc8280xp-based 2-in-1 tablet.
> --
> 2.34.1
--
heikki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-04-17 13:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-04-17 12:28 [PATCH -next] usb: typec: ucsi: Fix unmet dependencies for UCSI_HUAWEI_GAOKUN Yue Haibing
2025-04-17 13:44 ` Heikki Krogerus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®