From: Oleksij Rempel <o.rempel@pengutronix.de>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Vladimir Oltean <olteanv@gmail.com>,
Woojung Huh <woojung.huh@microchip.com>,
"Russell King (Oracle)" <linux@armlinux.org.uk>,
Heiner Kallweit <hkallweit1@gmail.com>,
stable@vger.kernel.org, kernel@pengutronix.de,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
UNGLinuxDriver@microchip.com
Subject: Re: [PATCH net v1 1/2] net: dsa: microchip: let phylink manage PHY EEE configuration on KSZ switches
Date: Tue, 29 Apr 2025 08:51:04 +0200 [thread overview]
Message-ID: <aBB22NnNE4p6isiC@pengutronix.de> (raw)
In-Reply-To: <aA_DyKw8AVPdmu-Y@pengutronix.de>
On Mon, Apr 28, 2025 at 08:07:04PM +0200, Oleksij Rempel wrote:
> On Mon, Apr 28, 2025 at 06:51:19PM +0200, Andrew Lunn wrote:
> > > +/**
> > > + * ksz_phylink_mac_disable_tx_lpi() - Dummy handler to disable TX LPI
> > > + * @config: phylink config structure
> > > + *
> > > + * For ports with integrated PHYs, LPI is managed internally by hardware.
> >
> > Could you expand that.
> >
> > Does it mean the hardware will look at the results of the autoneg and
> > disable/enable LPI depending on those results?
>
> Yes.
>
> > I also assume this means it is not possible to force LPI on/off, independent
> > of autoneg?
>
> Correct. set_eee call in this driver is filtering (tx_lpi == false) to
> reflect HW functionality.
I'll update this patch to include this information.
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2025-04-29 6:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-28 12:51 [PATCH net v1 0/2] address EEE regressions on KSZ switches since v6.9 (v6.14+) Oleksij Rempel
2025-04-28 12:51 ` [PATCH net v1 1/2] net: dsa: microchip: let phylink manage PHY EEE configuration on KSZ switches Oleksij Rempel
2025-04-28 16:51 ` Andrew Lunn
2025-04-28 18:07 ` Oleksij Rempel
2025-04-29 6:51 ` Oleksij Rempel [this message]
2025-04-28 12:51 ` [PATCH net v1 2/2] net: phy: micrel: remove KSZ9477 EEE quirks now handled by phylink Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aBB22NnNE4p6isiC@pengutronix.de \
--to=o.rempel@pengutronix.de \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®