* [PATCH v1 1/1] media: raspberrypi: rp1-cfe: Remove (explicitly) unused header
@ 2025-03-31 7:21 Andy Shevchenko
2025-04-03 8:10 ` Tomi Valkeinen
2025-05-02 14:11 ` Andy Shevchenko
0 siblings, 2 replies; 3+ messages in thread
From: Andy Shevchenko @ 2025-03-31 7:21 UTC (permalink / raw)
To: Hans Verkuil, Tomi Valkeinen, linux-media, linux-rpi-kernel,
linux-arm-kernel, linux-kernel
Cc: Raspberry Pi Kernel Maintenance, Mauro Carvalho Chehab,
Florian Fainelli, Broadcom internal kernel review list,
Andy Shevchenko
The fwnode.h is not supposed to be used by the drivers as it
has the definitions for the core parts for different device
property provider implementations. Drop it.
Note, that fwnode API for drivers is provided in property.h
which is included here.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/media/platform/raspberrypi/rp1-cfe/cfe.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/media/platform/raspberrypi/rp1-cfe/cfe.c b/drivers/media/platform/raspberrypi/rp1-cfe/cfe.c
index 69a5f23e7954..fcadb2143c88 100644
--- a/drivers/media/platform/raspberrypi/rp1-cfe/cfe.c
+++ b/drivers/media/platform/raspberrypi/rp1-cfe/cfe.c
@@ -12,7 +12,6 @@
#include <linux/device.h>
#include <linux/dma-mapping.h>
#include <linux/err.h>
-#include <linux/fwnode.h>
#include <linux/init.h>
#include <linux/interrupt.h>
#include <linux/io.h>
--
2.47.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/1] media: raspberrypi: rp1-cfe: Remove (explicitly) unused header
2025-03-31 7:21 [PATCH v1 1/1] media: raspberrypi: rp1-cfe: Remove (explicitly) unused header Andy Shevchenko
@ 2025-04-03 8:10 ` Tomi Valkeinen
2025-05-02 14:11 ` Andy Shevchenko
1 sibling, 0 replies; 3+ messages in thread
From: Tomi Valkeinen @ 2025-04-03 8:10 UTC (permalink / raw)
To: Andy Shevchenko, Hans Verkuil, linux-media, linux-rpi-kernel,
linux-arm-kernel, linux-kernel
Cc: Raspberry Pi Kernel Maintenance, Mauro Carvalho Chehab,
Florian Fainelli, Broadcom internal kernel review list
Hi,
On 31/03/2025 10:21, Andy Shevchenko wrote:
> The fwnode.h is not supposed to be used by the drivers as it
> has the definitions for the core parts for different device
> property provider implementations. Drop it.
>
> Note, that fwnode API for drivers is provided in property.h
> which is included here.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/media/platform/raspberrypi/rp1-cfe/cfe.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/media/platform/raspberrypi/rp1-cfe/cfe.c b/drivers/media/platform/raspberrypi/rp1-cfe/cfe.c
> index 69a5f23e7954..fcadb2143c88 100644
> --- a/drivers/media/platform/raspberrypi/rp1-cfe/cfe.c
> +++ b/drivers/media/platform/raspberrypi/rp1-cfe/cfe.c
> @@ -12,7 +12,6 @@
> #include <linux/device.h>
> #include <linux/dma-mapping.h>
> #include <linux/err.h>
> -#include <linux/fwnode.h>
> #include <linux/init.h>
> #include <linux/interrupt.h>
> #include <linux/io.h>
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Tomi
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/1] media: raspberrypi: rp1-cfe: Remove (explicitly) unused header
2025-03-31 7:21 [PATCH v1 1/1] media: raspberrypi: rp1-cfe: Remove (explicitly) unused header Andy Shevchenko
2025-04-03 8:10 ` Tomi Valkeinen
@ 2025-05-02 14:11 ` Andy Shevchenko
1 sibling, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2025-05-02 14:11 UTC (permalink / raw)
To: Hans Verkuil, Tomi Valkeinen, linux-media, linux-rpi-kernel,
linux-arm-kernel, linux-kernel
Cc: Raspberry Pi Kernel Maintenance, Mauro Carvalho Chehab,
Florian Fainelli, Broadcom internal kernel review list
On Mon, Mar 31, 2025 at 10:21:36AM +0300, Andy Shevchenko wrote:
> The fwnode.h is not supposed to be used by the drivers as it
> has the definitions for the core parts for different device
> property provider implementations. Drop it.
>
> Note, that fwnode API for drivers is provided in property.h
> which is included here.
Any comments? Can it be applied?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-05-02 14:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-03-31 7:21 [PATCH v1 1/1] media: raspberrypi: rp1-cfe: Remove (explicitly) unused header Andy Shevchenko
2025-04-03 8:10 ` Tomi Valkeinen
2025-05-02 14:11 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®