From: Wasim Nazir <quic_wasimn@quicinc.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
<linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <kernel@quicinc.com>,
<kernel@oss.qualcomm.com>
Subject: Re: [PATCH v7 1/6] dt-bindings: arm: qcom: Add bindings for QCS9075 SOC based board
Date: Thu, 22 May 2025 00:48:23 +0530 [thread overview]
Message-ID: <aC4m/+UAHx5gwLdE@hu-wasimn-hyd.qualcomm.com> (raw)
In-Reply-To: <9df2f9f3-289f-4916-a293-ad5d97d530fe@kernel.org>
On Wed, May 21, 2025 at 06:26:40PM +0200, Krzysztof Kozlowski wrote:
> On 21/05/2025 17:35, Wasim Nazir wrote:
> > On Wed, May 21, 2025 at 04:20:53PM +0200, Krzysztof Kozlowski wrote:
> >> On 21/05/2025 16:08, Wasim Nazir wrote:
> >>> QCS9075 is compatible Industrial-IOT grade variant of SA8775p SOC.
> >>> Unlike QCS9100, it doesn't have safety monitoring feature of
> >>> Safety-Island(SAIL) subsystem, which affects thermal management.
> >>>
> >>> qcs9075-iq-9075-evk board is based on QCS9075 SOC.
> >>>
> >>> Signed-off-by: Wasim Nazir <quic_wasimn@quicinc.com>
> >>> ---
> >>> Documentation/devicetree/bindings/arm/qcom.yaml | 7 +++++++
> >>> 1 file changed, 7 insertions(+)
> >>>
> >>
> >> This was already acked twice by two DT maintainers. Apparently we need
> >> the third one.
> >
> > The previous acknowledgment has been removed due to changes in the code.
> > Since, here I have removed the som compatible so though of getting it
> > reviewed again. Som compatible is removed to make it align with other
> > sa8775p & its derivative targets which we are trying to refactor along with
> > Ride changes in other series.
>
> Nothing was explained in cover letter and dropping tags needs explicit
> mentioning. Nothing explained about first tag being dropped, either!
> Read really carefully submitting patches and your internal guideline
> before sending patches.
I'm sorry about that; it wasn't intentional. I'll make sure to take care
of it next time. I do try to mention changes in the changelog, but I
understand now that it's not sufficient.
>
> But that was not about it. It was about us spending 1 or 5 minutes on
> your patch every time, because you send something not ready which your
> company decides to change thus we need to spend time again, and then you
> change it again, which we need to spend time again... do you get the point?
>
I have made the code changes to align with our discussion in the other
series [1] of changes for Ride. Let me know if we need further
discussion on this to conclude on DT structure for sa8775p & IQ9 targets.
[1]
https://lore.kernel.org/all/aCdAuTS4pg7arxwC@hu-wasimn-hyd.qualcomm.com/
> That is not fair. Your marketing changes should not cause more effort on
> us. And this is not the first time.
I truly appreciate all your efforts. I understand there have been
mistakes on our end, but we are learning a lot from this process. We are
noting valuable points to make our internal processes more efficient and
reduce multiple iterations.
>
> At least I do not agree on that. Anyway, I explained my point of view to
> Bjorn and Konrad. I am not going to review this. Maybe you will be lucky
> with the third DT maintainer.
>
> Best regards,
> Krzysztof
Regards,
Wasim
next prev parent reply other threads:[~2025-05-21 19:18 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-21 14:07 [PATCH v7 0/6] qcom: Add support for IQ-9075-evk board Wasim Nazir
2025-05-21 14:08 ` [PATCH v7 1/6] dt-bindings: arm: qcom: Add bindings for QCS9075 SOC based board Wasim Nazir
2025-05-21 14:20 ` Krzysztof Kozlowski
2025-05-21 15:35 ` Wasim Nazir
2025-05-21 16:26 ` Krzysztof Kozlowski
2025-05-21 19:18 ` Wasim Nazir [this message]
2025-05-21 14:08 ` [PATCH v7 2/6] arm64: dts: qcom: iq9: Introduce new memory map for qcs9100/qcs9075 Wasim Nazir
2025-05-21 14:08 ` [PATCH v7 3/6] arm64: dts: qcom: qcs9075: Introduce QCS9075 SOM Wasim Nazir
2025-05-21 14:08 ` [PATCH v7 4/6] arm64: dts: qcom: Add support for qcs9075 IQ-9075-EVK Wasim Nazir
2025-05-21 16:57 ` Konrad Dybcio
2025-05-21 19:29 ` Wasim Nazir
2025-05-21 14:08 ` [PATCH v7 5/6] arm64: dts: qcom: Add support L4C LDO " Wasim Nazir
2025-05-21 14:21 ` Krzysztof Kozlowski
2025-05-21 14:08 ` [PATCH v7 6/6] arm64: dts: qcom: Add UFS support " Wasim Nazir
2025-05-21 14:21 ` Krzysztof Kozlowski
2025-05-21 14:23 ` Krzysztof Kozlowski
2025-05-21 15:44 ` Wasim Nazir
2025-05-21 14:33 ` Dmitry Baryshkov
2025-05-21 15:38 ` Wasim Nazir
2025-05-22 18:54 ` [PATCH v7 0/6] qcom: Add support for IQ-9075-evk board Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aC4m/+UAHx5gwLdE@hu-wasimn-hyd.qualcomm.com \
--to=quic_wasimn@quicinc.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@oss.qualcomm.com \
--cc=kernel@quicinc.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®