From: Andy Shevchenko <andy@kernel.org>
To: David Lechner <dlechner@baylibre.com>
Cc: "Michael Hennerich" <Michael.Hennerich@analog.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"Nuno Sá" <nuno.sa@analog.com>, "Da Xue" <da@libre.computer>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: adc: ad7949: use spi_is_bpw_supported()
Date: Wed, 11 Jun 2025 18:15:17 +0300 [thread overview]
Message-ID: <aEmdhV0ATRuUeGaL@smile.fi.intel.com> (raw)
In-Reply-To: <20250611-iio-adc-ad7949-use-spi_is_bpw_supported-v1-1-c4e15bfd326e@baylibre.com>
On Wed, Jun 11, 2025 at 10:04:58AM -0500, David Lechner wrote:
> Use spi_is_bpw_supported() instead of directly accessing spi->controller
> ->bits_per_word_mask. bits_per_word_mask may be 0, which implies that
> 8-bits-per-word is supported. spi_is_bpw_supported() takes this into
> account while spi_ctrl_mask == SPI_BPW_MASK(8) does not.
> Closes: https://lore.kernel.org/linux-spi/c8b8a963-6cef-4c9b-bfef-dab2b7bd0b0f@sirena.org.uk/
Reported-by yourself. I'm wondering if the Closes adds a value in this case.
Otherwise I can do the same to maybe 10% of my patches, for instance. But
I don't think I put Closes tag on whatever improvement potential bug fix
I do report (read: notice) myself.
> Signed-off-by: David Lechner <dlechner@baylibre.com>
Code wise LGTM,
Reviewed-by: Andy Shevchenko <andy@kernel.org>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-06-11 15:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-11 15:04 David Lechner
2025-06-11 15:15 ` Andy Shevchenko [this message]
2025-06-11 15:21 ` David Lechner
2025-06-11 16:55 ` Jonathan Cameron
2025-06-11 17:00 ` David Lechner
2025-06-14 11:40 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aEmdhV0ATRuUeGaL@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=da@libre.computer \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®