* [PATCH v1 1/1] pinctrl: intel: fix build warnings about export.h
@ 2025-06-11 18:09 Andy Shevchenko
2025-06-12 5:12 ` Mika Westerberg
0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2025-06-11 18:09 UTC (permalink / raw)
To: Andy Shevchenko, Mika Westerberg, linux-gpio, linux-kernel
Cc: Andy Shevchenko, Linus Walleij
After commit a934a57a42f64a4 ("scripts/misc-check: check missing #include
<linux/export.h> when W=1") and 7d95680d64ac8e836c ("scripts/misc-check:
check unnecessary #include <linux/export.h> when W=1"), we get some build
warnings with W=1:
pinctrl-intel.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing
So fix these build warnings for the driver code.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/pinctrl/intel/pinctrl-intel.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pinctrl/intel/pinctrl-intel.c b/drivers/pinctrl/intel/pinctrl-intel.c
index d889c7c878e2..15f91fa198a3 100644
--- a/drivers/pinctrl/intel/pinctrl-intel.c
+++ b/drivers/pinctrl/intel/pinctrl-intel.c
@@ -9,6 +9,7 @@
#include <linux/acpi.h>
#include <linux/cleanup.h>
+#include <linux/export.h>
#include <linux/gpio/driver.h>
#include <linux/interrupt.h>
#include <linux/log2.h>
--
2.47.2
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v1 1/1] pinctrl: intel: fix build warnings about export.h
2025-06-11 18:09 [PATCH v1 1/1] pinctrl: intel: fix build warnings about export.h Andy Shevchenko
@ 2025-06-12 5:12 ` Mika Westerberg
2025-06-12 12:31 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Mika Westerberg @ 2025-06-12 5:12 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: linux-gpio, linux-kernel, Andy Shevchenko, Linus Walleij
On Wed, Jun 11, 2025 at 09:09:56PM +0300, Andy Shevchenko wrote:
> After commit a934a57a42f64a4 ("scripts/misc-check: check missing #include
> <linux/export.h> when W=1") and 7d95680d64ac8e836c ("scripts/misc-check:
> check unnecessary #include <linux/export.h> when W=1"), we get some build
> warnings with W=1:
>
> pinctrl-intel.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing
>
> So fix these build warnings for the driver code.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v1 1/1] pinctrl: intel: fix build warnings about export.h
2025-06-12 5:12 ` Mika Westerberg
@ 2025-06-12 12:31 ` Andy Shevchenko
0 siblings, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2025-06-12 12:31 UTC (permalink / raw)
To: Mika Westerberg; +Cc: linux-gpio, linux-kernel, Andy Shevchenko, Linus Walleij
On Thu, Jun 12, 2025 at 08:12:58AM +0300, Mika Westerberg wrote:
> On Wed, Jun 11, 2025 at 09:09:56PM +0300, Andy Shevchenko wrote:
> > After commit a934a57a42f64a4 ("scripts/misc-check: check missing #include
> > <linux/export.h> when W=1") and 7d95680d64ac8e836c ("scripts/misc-check:
> > check unnecessary #include <linux/export.h> when W=1"), we get some build
> > warnings with W=1:
> >
> > pinctrl-intel.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing
> >
> > So fix these build warnings for the driver code.
>
> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Pushed to my review and testing queue, thanks!
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-06-12 12:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-06-11 18:09 [PATCH v1 1/1] pinctrl: intel: fix build warnings about export.h Andy Shevchenko
2025-06-12 5:12 ` Mika Westerberg
2025-06-12 12:31 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®