[PATCH v5] staging: media: atomisp: fix tab/space issues in output1.0

[PATCH v5] staging: media: atomisp: fix tab/space issues in output1.0

[LiangCheng Wang]

Fix indentation style issues by replacing spaces with tabs,
according to Linux kernel coding style.

This cleanup improves code readability and follows Linux kernel
coding standards.

Signed-off-by: LiangCheng Wang <zaq14760@gmail.com>
---
This patch addresses tab/space indentation issues in the
output_1.0 directory of the AtomISP driver under staging.

This patch is part of a broader effort to clean up the AtomISP
driver and is scoped only to tab/space fixes in one directory
to keep review manageable.

Further style fixes for other directories and issue types will
be submitted in subsequent patch revisions or series.

Fixes were identified using:

./scripts/checkpatch.pl -f $(find drivers/staging/media/atomisp/pci/isp/kernels/output/output_1.0/ -type f \( -name "*.c" -o -name "*.h" \))
grep -Prn '^[ ]+' drivers/staging/media/atomisp/pci/isp/kernels/output/output_1.0

Only lines with space-based indentation (instead of tab) were changed.

Suggested-by: Andy Shevchenko <andy@kernel.org>
Link: https://lore.kernel.org/r/CAHp75VeijMvnbrCmRuqTeo_maxevCA9rB-r5URHaX+TrDNvyGA@mail.gmail.com
---
Changes in v5:
- Replaced space-based indentation with tabs in output_1.0 directory
- Used checkpatch.pl and grep to identify formatting issues
- No functional changes made
- This patch is now focused solely on tab/space issues
- Link to v4: https://lore.kernel.org/r/20250624-bar-v4-1-9f9f9ae9f868@gmail.com

Changes in v4:
- Moved assignment operator '=' to the same line for static struct definitions
- Remove unnecessary line breaks in function definitions
- Update commit message to reflect all the coding style fixes
- Link to v3: https://lore.kernel.org/r/20250622-bar-v3-1-4cc91ef01c3a@gmail.com

Changes in v3:
- Removed extra spaces between type and asterisk (e.g., `*to`) in function
  declarations, as pointed out by Andy Shevchenko
- Update commit message to reflect all the coding style fixes
- Link to v2: https://lore.kernel.org/r/20250621-bar-v2-1-4e6cfc779614@gmail.com

Changes in v2:
- Fix patch subject prefix to "staging: media: atomisp:" to comply with media CI style.
- No other functional changes.

Link to v1: https://lore.kernel.org/r/20250621-bar-v1-1-5a3e7004462c@gmail.com
---
 .../isp/kernels/output/output_1.0/ia_css_output.host.c   | 16 ++++++++--------
 .../isp/kernels/output/output_1.0/ia_css_output.host.h   | 14 +++++++-------
 2 files changed, 15 insertions(+), 15 deletions(-)

diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/output/output_1.0/ia_css_output.host.c b/drivers/staging/media/atomisp/pci/isp/kernels/output/output_1.0/ia_css_output.host.c
index d09365e0c47104dbffbd455bfd649b9079f88c9c..8d440856471ca73089569be51644c7ac421607ce 100644
--- a/drivers/staging/media/atomisp/pci/isp/kernels/output/output_1.0/ia_css_output.host.c
+++ b/drivers/staging/media/atomisp/pci/isp/kernels/output/output_1.0/ia_css_output.host.c
@@ -34,9 +34,9 @@ static const struct ia_css_output1_configuration default_output1_configuration
 
 void
 ia_css_output_encode(
-    struct sh_css_isp_output_params *to,
-    const struct ia_css_output_config *from,
-    unsigned int size)
+	struct sh_css_isp_output_params *to,
+	const struct ia_css_output_config *from,
+	unsigned int size)
 {
 	(void)size;
 	to->enable_hflip = from->enable_hflip;
@@ -74,7 +74,7 @@ int ia_css_output0_config(struct sh_css_isp_output_isp_config       *to,
 }
 
 int ia_css_output1_config(struct sh_css_isp_output_isp_config       *to,
-		          const struct ia_css_output1_configuration *from,
+			  const struct ia_css_output1_configuration *from,
 			  unsigned int size)
 {
 	return ia_css_output_config(to, (const struct ia_css_output_configuration *)from, size);
@@ -124,8 +124,8 @@ int ia_css_output1_configure(const struct ia_css_binary     *binary,
 
 void
 ia_css_output_dump(
-    const struct sh_css_isp_output_params *output,
-    unsigned int level)
+	const struct sh_css_isp_output_params *output,
+	unsigned int level)
 {
 	if (!output) return;
 	ia_css_debug_dtrace(level, "Horizontal Output Flip:\n");
@@ -138,8 +138,8 @@ ia_css_output_dump(
 
 void
 ia_css_output_debug_dtrace(
-    const struct ia_css_output_config *config,
-    unsigned int level)
+	const struct ia_css_output_config *config,
+	unsigned int level)
 {
 	ia_css_debug_dtrace(level,
 			    "config.enable_hflip=%d",
diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/output/output_1.0/ia_css_output.host.h b/drivers/staging/media/atomisp/pci/isp/kernels/output/output_1.0/ia_css_output.host.h
index 25408f1aede55a61a33a55ad38d5afc3a594a756..e7d44f809003d8692292e9571ac777ea3f2d87b9 100644
--- a/drivers/staging/media/atomisp/pci/isp/kernels/output/output_1.0/ia_css_output.host.h
+++ b/drivers/staging/media/atomisp/pci/isp/kernels/output/output_1.0/ia_css_output.host.h
@@ -17,9 +17,9 @@ extern const struct ia_css_output_config default_output_config;
 
 void
 ia_css_output_encode(
-    struct sh_css_isp_output_params *to,
-    const struct ia_css_output_config *from,
-    unsigned int size);
+	struct sh_css_isp_output_params *to,
+	const struct ia_css_output_config *from,
+	unsigned int size);
 
 int ia_css_output_config(struct sh_css_isp_output_isp_config      *to,
 			 const struct ia_css_output_configuration *from,
@@ -44,12 +44,12 @@ int ia_css_output1_configure(const struct ia_css_binary     *binary,
 
 void
 ia_css_output_dump(
-    const struct sh_css_isp_output_params *output,
-    unsigned int level);
+	const struct sh_css_isp_output_params *output,
+	unsigned int level);
 
 void
 ia_css_output_debug_dtrace(
-    const struct ia_css_output_config *config,
-    unsigned int level);
+	const struct ia_css_output_config *config,
+	unsigned int level);
 
 #endif /* __IA_CSS_OUTPUT_HOST_H */

---
base-commit: 3f75bfff44be0646580fe4efda45d646f9c1693b
change-id: 20250621-bar-573b8b40fb80

Best regards,
-- 
LiangCheng Wang <zaq14760@gmail.com>

Re: [PATCH v5] staging: media: atomisp: fix tab/space issues in output1.0

[Andy Shevchenko]

On Wed, Jun 25, 2025 at 11:04:31PM +0800, LiangCheng Wang wrote:
> Fix indentation style issues by replacing spaces with tabs,
> according to Linux kernel coding style.
> 
> This cleanup improves code readability and follows Linux kernel
> coding standards.
> 
> Signed-off-by: LiangCheng Wang <zaq14760@gmail.com>
> ---
> This patch addresses tab/space indentation issues in the
> output_1.0 directory of the AtomISP driver under staging.
> 
> This patch is part of a broader effort to clean up the AtomISP
> driver and is scoped only to tab/space fixes in one directory
> to keep review manageable.
> 
> Further style fixes for other directories and issue types will
> be submitted in subsequent patch revisions or series.
> 
> Fixes were identified using:
> 
> ./scripts/checkpatch.pl -f $(find drivers/staging/media/atomisp/pci/isp/kernels/output/output_1.0/ -type f \( -name "*.c" -o -name "*.h" \))
> grep -Prn '^[ ]+' drivers/staging/media/atomisp/pci/isp/kernels/output/output_1.0
> 
> Only lines with space-based indentation (instead of tab) were changed.

> Suggested-by: Andy Shevchenko <andy@kernel.org>
> Link: https://lore.kernel.org/r/CAHp75VeijMvnbrCmRuqTeo_maxevCA9rB-r5URHaX+TrDNvyGA@mail.gmail.com

These two lines should be just above your SoB in the commit message. Currently
they will most likely be ignored (at least by `git am ...`.

...

>  void
>  ia_css_output_encode(
> -    struct sh_css_isp_output_params *to,
> -    const struct ia_css_output_config *from,
> -    unsigned int size)
> +	struct sh_css_isp_output_params *to,
> +	const struct ia_css_output_config *from,
> +	unsigned int size)

In cases like this you might want to also reshuffle the lines:

void ia_css_output_encode(struct sh_css_isp_output_params *to,
			  const struct ia_css_output_config *from,
			  unsigned int size)

...

Have you tried simply to run slang-format against the whole driver using the
clang-format configuration from the kernel source tree?

With it done, you may just make it as a single patch.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v5] staging: media: atomisp: fix tab/space issues in output1.0

[Andy Shevchenko]

On Wed, Jun 25, 2025 at 06:15:12PM +0300, Andy Shevchenko wrote:
> On Wed, Jun 25, 2025 at 11:04:31PM +0800, LiangCheng Wang wrote:

...

> Have you tried simply to run slang-format against the whole driver using the

clang-format

> clang-format configuration from the kernel source tree?

.clang-format

> With it done, you may just make it as a single patch.

-- 
With Best Regards,
Andy Shevchenko