* [PATCH] mfd: mt6370: Fix the interrupt naming typo
@ 2025-07-09 2:00 cy_huang
2025-07-09 8:36 ` Andy Shevchenko
2025-07-10 8:08 ` (subset) " Lee Jones
0 siblings, 2 replies; 4+ messages in thread
From: cy_huang @ 2025-07-09 2:00 UTC (permalink / raw)
To: Lee Jones
Cc: Matthias Brugger, AngeloGioacchino Del Regno, ChiaEn Wu,
Andy Shevchenko, ChiYuan Huang, linux-kernel, linux-arm-kernel,
linux-mediatek
From: ChiYuan Huang <cy_huang@richtek.com>
Modify the lowercase character to uppercase.
Fixes: b2adf788e603 ("mfd: mt6370: Add MediaTek MT6370 support")
Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>
---
drivers/mfd/mt6370.c | 2 +-
drivers/mfd/mt6370.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mfd/mt6370.c b/drivers/mfd/mt6370.c
index c126ccb25d66..c7c2efe3598c 100644
--- a/drivers/mfd/mt6370.c
+++ b/drivers/mfd/mt6370.c
@@ -95,7 +95,7 @@ static const struct regmap_irq mt6370_irqs[] = {
REGMAP_IRQ_REG_LINE(MT6370_IRQ_FLED1_SHORT, 8),
REGMAP_IRQ_REG_LINE(MT6370_IRQ_FLED2_STRB, 8),
REGMAP_IRQ_REG_LINE(MT6370_IRQ_FLED1_STRB, 8),
- REGMAP_IRQ_REG_LINE(mT6370_IRQ_FLED2_STRB_TO, 8),
+ REGMAP_IRQ_REG_LINE(MT6370_IRQ_FLED2_STRB_TO, 8),
REGMAP_IRQ_REG_LINE(MT6370_IRQ_FLED1_STRB_TO, 8),
REGMAP_IRQ_REG_LINE(MT6370_IRQ_FLED2_TOR, 8),
REGMAP_IRQ_REG_LINE(MT6370_IRQ_FLED1_TOR, 8),
diff --git a/drivers/mfd/mt6370.h b/drivers/mfd/mt6370.h
index 094e59e4af4e..dd9ccc0a53f1 100644
--- a/drivers/mfd/mt6370.h
+++ b/drivers/mfd/mt6370.h
@@ -69,7 +69,7 @@
#define MT6370_IRQ_FLED1_SHORT 79
#define MT6370_IRQ_FLED2_STRB 80
#define MT6370_IRQ_FLED1_STRB 81
-#define mT6370_IRQ_FLED2_STRB_TO 82
+#define MT6370_IRQ_FLED2_STRB_TO 82
#define MT6370_IRQ_FLED1_STRB_TO 83
#define MT6370_IRQ_FLED2_TOR 84
#define MT6370_IRQ_FLED1_TOR 85
--
2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] mfd: mt6370: Fix the interrupt naming typo
2025-07-09 2:00 [PATCH] mfd: mt6370: Fix the interrupt naming typo cy_huang
@ 2025-07-09 8:36 ` Andy Shevchenko
2025-07-09 11:02 ` ChiYuan Huang
2025-07-10 8:08 ` (subset) " Lee Jones
1 sibling, 1 reply; 4+ messages in thread
From: Andy Shevchenko @ 2025-07-09 8:36 UTC (permalink / raw)
To: cy_huang
Cc: Lee Jones, Matthias Brugger, AngeloGioacchino Del Regno,
ChiaEn Wu, linux-kernel, linux-arm-kernel, linux-mediatek
On Wed, Jul 9, 2025 at 5:00 AM <cy_huang@richtek.com> wrote:
>
> Modify the lowercase character to uppercase.
...
> Fixes: b2adf788e603 ("mfd: mt6370: Add MediaTek MT6370 support")
Doesn't look like a real fix to me, although code looks good.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] mfd: mt6370: Fix the interrupt naming typo
2025-07-09 8:36 ` Andy Shevchenko
@ 2025-07-09 11:02 ` ChiYuan Huang
0 siblings, 0 replies; 4+ messages in thread
From: ChiYuan Huang @ 2025-07-09 11:02 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Lee Jones, Matthias Brugger, AngeloGioacchino Del Regno,
ChiaEn Wu, linux-kernel, linux-arm-kernel, linux-mediatek
On Wed, Jul 09, 2025 at 11:36:25AM +0300, Andy Shevchenko wrote:
> On Wed, Jul 9, 2025 at 5:00 AM <cy_huang@richtek.com> wrote:
> >
> > Modify the lowercase character to uppercase.
>
> ...
>
> > Fixes: b2adf788e603 ("mfd: mt6370: Add MediaTek MT6370 support")
>
> Doesn't look like a real fix to me, although code looks good.
>
Yap, it's just typo. So should I remove the 'Fixes' tag and resend?
Or keep waiting for other's feedback?
> --
> With Best Regards,
> Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: (subset) [PATCH] mfd: mt6370: Fix the interrupt naming typo
2025-07-09 2:00 [PATCH] mfd: mt6370: Fix the interrupt naming typo cy_huang
2025-07-09 8:36 ` Andy Shevchenko
@ 2025-07-10 8:08 ` Lee Jones
1 sibling, 0 replies; 4+ messages in thread
From: Lee Jones @ 2025-07-10 8:08 UTC (permalink / raw)
To: Lee Jones, cy_huang
Cc: Matthias Brugger, AngeloGioacchino Del Regno, ChiaEn Wu,
Andy Shevchenko, linux-kernel, linux-arm-kernel, linux-mediatek
On Wed, 09 Jul 2025 10:00:48 +0800, cy_huang@richtek.com wrote:
> Modify the lowercase character to uppercase.
>
>
Applied, thanks!
[1/1] mfd: mt6370: Fix the interrupt naming typo
commit: 08f69ce8aecef8ed4048818f985b4a8a87bc283b
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-07-10 8:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-07-09 2:00 [PATCH] mfd: mt6370: Fix the interrupt naming typo cy_huang
2025-07-09 8:36 ` Andy Shevchenko
2025-07-09 11:02 ` ChiYuan Huang
2025-07-10 8:08 ` (subset) " Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®