Re: [PATCH v3 RESEND] media: i2c: Add OV05C10 camera sensor driver

[Sakari Ailus <sakari.ailus@linux.intel.com>]

Hi Pratap,

On Wed, Jul 02, 2025 at 12:47:40PM -0400, Nirujogi, Pratap wrote:
> > > If you have a spec of OV05C10 (I assume you do, as the developer of this
> > > driver), it is not a issue.
> > > Take P0:0x14 as an example, it's named as DPLL_NC_SEL in spec and set to
> > > 0x78 in your reglist ov05c10_2888x1808_regs. If define all named
> > > registers rather than the confusing magic hardcode, the driver code will
> > > be more readable and easy to review.
> > > I think this is what Sakari thought.
> > 
> > Yes. And even if it happens that a register write slips to a wrong list,
> > we can fix it later.
> > 
> I agree with the suggestion on proper naming of register offsets, but
> unfortunately we lack access to the spec. We are completely relying on the
> sensor vendor for these sequences, which they are not willing to share the
> details.

I find it difficult to believe a company such as AMD would use a camera
sensor without having documentation on it. It is essentially required for
hardware design, too.

Have you asked around?

-- 
Kind regards,

Sakari Ailus